scsi: fnic: Fix indentation and remove unnecessary parenthesis
Subsystems (2)
Karan Tilak Kumar
maintainerPATCH 1/1 scsi: fnic: Fix indentation and remove unnecessary parenthesis
Fix indentation in fdls_disc.c to fix kernel test robot warnings. Remove unnecessary parentheses to fix checkpatch check.
--- drivers/scsi/fnic/fdls_disc.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-)
drivers/scsi/fnic/fdls_disc.c +13 -13
@@ -318,8 +318,8 @@ void fdls_schedule_oxid_free_retry_work(struct work_struct *work) "Schedule oxid free. oxid idx: %d\n", idx);spin_unlock_irqrestore (&fnic->fnic_lock, fnic->lock_flags); - reclaim_entry = (struct reclaim_entry_s *) -kzalloc (sizeof (struct reclaim_entry_s ),GFP_KERNEL ); + reclaim_entry = (struct reclaim_entry_s *) +kzalloc (sizeof (struct reclaim_entry_s ),GFP_KERNEL );spin_lock_irqsave (&fnic->fnic_lock, fnic->lock_flags);if (!reclaim_entry) {
@@ -338,7 +338,7 @@ void fdls_schedule_oxid_free_retry_work(struct work_struct *work)/* unlikely scenario, free the allocated memory and continue */ kfree (reclaim_entry); } -} + }spin_unlock_irqrestore (&fnic->fnic_lock, fnic->lock_flags); }
@@ -1563,9 +1563,9 @@ void fdls_send_fabric_logo(struct fnic_iport_s *iport) iport->fabric.flags &= ~FNIC_FDLS_FABRIC_ABORT_ISSUED ; -FNIC_FCS_DBG (KERN_INFO , fnic->host, fnic->fnic_num, -"0x%x: FDLS send fabric LOGO with oxid: 0x%x" , - iport->fcid, oxid); +FNIC_FCS_DBG (KERN_INFO , fnic->host, fnic->fnic_num, +"0x%x: FDLS send fabric LOGO with oxid: 0x%x" , + iport->fcid, oxid);fnic_send_fcoe_frame (iport, frame, frame_size);
@@ -4655,13 +4655,13 @@ fnic_fdls_validate_and_get_frame_type(struct fnic_iport_s *iport, d_id =ntoh24 (fchdr->fh_d_id);/* some common validation */ -if (fdls_get_state (fabric) >FDLS_STATE_FABRIC_FLOGI ) { -if ((iport->fcid != d_id) || (!FNIC_FC_FRAME_CS_CTL (fchdr))) { -FNIC_FCS_DBG (KERN_INFO , fnic->host, fnic->fnic_num, -"invalid frame received. Dropping frame" ); -return -1 ; - } +if (fdls_get_state (fabric) >FDLS_STATE_FABRIC_FLOGI ) { +if (iport->fcid != d_id || (!FNIC_FC_FRAME_CS_CTL (fchdr))) { +FNIC_FCS_DBG (KERN_INFO , fnic->host, fnic->fnic_num, +"invalid frame received. Dropping frame" ); +return -1 ; } + }/* BLS ABTS response */ if ((fchdr->fh_r_ctl == FC_RCTL_BA_ACC)
@@ -4678,7 +4678,7 @@ fnic_fdls_validate_and_get_frame_type(struct fnic_iport_s *iport,"Received unexpected ABTS RSP(oxid:0x%x) from 0x%x. Dropping frame" , oxid, s_id);return -1 ; - } + }return FNIC_FABRIC_BLS_ABTS_RSP ; }else if (fdls_is_oxid_fdmi_req (oxid)) {return FNIC_FDMI_BLS_ABTS_RSP ;
Signature · 1 line
2.47.1
Martin K. Petersen
AppliedKaran,
Quoted 2 lines
Fix indentation in
fdls_disc.cto fix kernel test robot warnings. Remove unnecessary parentheses to fix checkpatch check.
Applied to 6.15/scsi-staging, thanks!
PS. Next time, please send your fixes as a patch series.
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Karan Tilak Kumar (kartilak)
maintainerQuoted 7 lines · Martin K. Petersen
Karan,
Quoted 2 lines
Fix indentation in
fdls_disc.cto fix kernel test robot warnings. Remove unnecessary parentheses to fix checkpatch check.
Quoted 7 lines
Applied to 6.15/scsi-staging, thanks!
PS. Next time, please send your fixes as a patch series.
--
Martin K. Petersen Oracle Linux Engineering
Thanks Martin. Sure, I'll keep that in mind.
Sorry for the inconvenience.
Regards,
Karan