KVM: x86/tdp_mmu: Remove tdp_mmu_for_each_pte()
PATCH 1/1 KVM: x86/tdp_mmu: Remove tdp_mmu_for_each_pte()
That macro acts as a different name for for_each_tdp_pte, apart from adding cognitive load it doesn't bring any value. Let's remove it.
Signed-off-by Nikolay Borisov <[email protected]>
--- arch/x86/kvm/mmu/tdp_mmu.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
arch/x86/kvm/mmu/tdp_mmu.c +3 -6
@@ -774,9 +774,6 @@ static inline void tdp_mmu_iter_set_spte(struct kvm *kvm, struct tdp_iter *iter,continue ; \ else -#define tdp_mmu_for_each_pte (_iter, _kvm, _root, _start, _end) \ - for_each_tdp_pte(_iter, _kvm, _root, _start, _end) - static inline bool __must_check tdp_mmu_iter_need_resched(struct kvm *kvm,struct tdp_iter *iter) {
@@ -1235,7 +1232,7 @@ int kvm_tdp_mmu_map(struct kvm_vcpu *vcpu, struct kvm_page_fault *fault)rcu_read_lock (); -tdp_mmu_for_each_pte (iter, kvm, root, fault->gfn, fault->gfn +1 ) { +for_each_tdp_pte (iter, kvm, root, fault->gfn, fault->gfn +1 ) {int r;if (fault->nx_huge_page_workaround_enabled)
@@ -1904,7 +1901,7 @@ int kvm_tdp_mmu_get_walk(struct kvm_vcpu *vcpu, u64 addr, u64 *sptes, *root_level = vcpu->arch.mmu->root_role.level; -tdp_mmu_for_each_pte (iter, vcpu->kvm, root, gfn, gfn +1 ) { +for_each_tdp_pte (iter, vcpu->kvm, root, gfn, gfn +1 ) { leaf = iter.level; sptes[leaf] = iter.old_spte; }
@@ -1931,7 +1928,7 @@ u64 *kvm_tdp_mmu_fast_pf_get_last_sptep(struct kvm_vcpu *vcpu, gfn_t gfn,struct tdp_iter iter;tdp_ptep_t sptep =NULL ; -tdp_mmu_for_each_pte (iter, vcpu->kvm, root, gfn, gfn +1 ) { +for_each_tdp_pte (iter, vcpu->kvm, root, gfn, gfn +1 ) { *spte = iter.old_spte; sptep = iter.sptep; }
Signature · 1 line
2.43.0
Quoted 2 lines · Nikolay Borisov
That macro acts as a different name for
for_each_tdp_pte, apart from adding cognitive load it doesn't bring any value. Let's remove it.
Applied to kvm-x86 mmu, thanks!
[1/1] KVM: x86/tdp_mmu: Remove tdp_mmu_for_each_pte()
https://github.com/kvm-x86/linux/commit/0dab791f05ce