Skip to contentSkip to conversation

samples/damon: a typo in the kconfig - sameple

PATCH Applied SeongJae Park 3 participants 8 messages Feb 26, 2025 – Feb 27, 2025

Subsystems (2)
lore
Share & tools
lore

SeongJae Park

author maintainer
#0 lore raw

PATCH 1/1 samples/damon: a typo in the kconfig - sameple

From: bus710 <[email protected]>

There is a typo in the Kconfig file of the damon sample module. Correct it: s/sample/sample/

---

Chagens from v1
(https://patch.msgid.link/[email protected])
- Wordsmith the message

 samples/damon/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
samples/damon/Kconfig +2 -2
index 63f6dcd71daa..564c49ed69a2 100644
@@ -3,7 +3,7 @@
 menu "DAMON Samples"
 
 config SAMPLE_DAMON_WSSE
-	bool "DAMON sameple module for working set size estimation"
+	bool "DAMON sample module for working set size estimation"
 	depends on DAMON && DAMON_VADDR
 	help
 	  This builds DAMON sample module for working set size estimation.
@@ -15,7 +15,7 @@ config SAMPLE_DAMON_WSSE
 	  If unsure, say N.
 
 config SAMPLE_DAMON_PRCL
-	bool "DAMON sameple module for access-aware proactive reclamation"
+	bool "DAMON sample module for access-aware proactive reclamation"
 	depends on DAMON && DAMON_VADDR
 	help
 	  This builds DAMON sample module for access-aware proactive

base-commit: 489e7430013060843b4f7f1ad3935ff58fbd5bfb

Signature · 1 line
2.39.5
author maintainer
#3 lore raw
Quoted 5 lines · On Wed, 26 Feb 2025 13:37:03 -0800 Andrew Morton <[email protected]>…
Quoted 1 line · On Wed, 26 Feb 2025 10:42:04 -0800 SeongJae Park <[email protected]> wrote:

From: bus710 <[email protected]>

Full names are preferred, please. Actually I think it's "required".

Thank you for letting me clearly know this. I'll request full names to DAMON patch authors from next time.

bus710, we could still update the patch before it is merged into the mainline. If you could, please let us know your full name and if we can update the patch with that.

Quoted 2 lines

I'll apply it anyway due to the patch's minor nature, thanks.

I agree this is a simple enough patch that the name doesn't really matter. Thank you Andrew :)

Thanks,
SJ

#4 lore raw
Quoted 17 lines · SeongJae Park
Quoted 5 lines · On Wed, 26 Feb 2025 13:37:03 -0800 Andrew Morton <[email protected]>…
Quoted 1 line · On Wed, 26 Feb 2025 10:42:04 -0800 SeongJae Park <[email protected]> wrote:

From: bus710 <[email protected]>

Full names are preferred, please. Actually I think it's "required".

Thank you for letting me clearly know this. I'll request full names to DAMON patch authors from next time.

bus710, we could still update the patch before it is merged into the mainline. If you could, please let us know your full name and if we can update the patch with that.

Quoted 1 line
Quoted 8 lines
Quoted 1 line

I'll apply it anyway due to the patch's minor nature, thanks.

I agree this is a simple enough patch that the name doesn't really matter. Thank you Andrew :)

Thanks,
SJ

Oh, yes. I was a little worried if I added too much noise for such a small work, but I shouldn't miss this opportunity to leave my name in Linux history.
Let me prepare a new patch as soon as possible.

Reviewed-by SeongJae Park
#5 lore raw
Quoted 25 lines · On Wed, Feb 26, 2025 at 3:07 PM bus710 <[email protected]> wrote:
Quoted 23 lines · SeongJae Park
Quoted 5 lines · On Wed, 26 Feb 2025 13:37:03 -0800 Andrew Morton <[email protected]>…
Quoted 1 line · On Wed, 26 Feb 2025 10:42:04 -0800 SeongJae Park <[email protected]> wrote:

From: bus710 <[email protected]>

Full names are preferred, please. Actually I think it's "required".

Thank you for letting me clearly know this. I'll request full names to DAMON patch authors from next time.

bus710, we could still update the patch before it is merged into the mainline. If you could, please let us know your full name and if we can update the patch with that.

Quoted 2 lines

I'll apply it anyway due to the patch's minor nature, thanks.

I agree this is a simple enough patch that the name doesn't really matter. Thank you Andrew :)

Quoted 7 lines
Quoted 2 lines

Thanks,
SJ

Oh, yes. I was a little worried if I added too much noise for such a small work, but I shouldn't miss this opportunity to leave my name in Linux history.
Let me prepare a new patch as soon as possible.

Hi all,

Please find the attached patch.
Based on the latest one, from @Andrew Morton I just replaced my ID with my real name as well as updated the subject.

Thank you,
Seongjun Kim

From: Seongjun Kim <[email protected]>
Subject: [PATCH v2] samples/damon: a typo in the kconfig - sameple
Date: Wed, 26 Feb 2025 10:42:04 -0800

There is a typo in the Kconfig file of the damon sample module. Correct
it: s/sameple/sample/

---

 samples/damon/Kconfig |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
samples/damon/Kconfig renamed from samples/damon/Kconfig~samples-damon-a-typo-in-the-kconfig-sameple +2 -2
@@ -3,7 +3,7 @@
 menu "DAMON Samples"
 
 config SAMPLE_DAMON_WSSE
-       bool "DAMON sameple module for working set size estimation"
+       bool "DAMON sample module for working set size estimation"
        depends on DAMON && DAMON_VADDR
        help
          This builds DAMON sample module for working set size estimation.
@@ -15,7 +15,7 @@ config SAMPLE_DAMON_WSSE
          If unsure, say N.
 
 config SAMPLE_DAMON_PRCL
-       bool "DAMON sameple module for access-aware proactive reclamation"
+       bool "DAMON sample module for access-aware proactive reclamation"
        depends on DAMON && DAMON_VADDR
        help
          This builds DAMON sample module for access-aware proactive

_

#6 lore raw

I was wondering how others live with the git send-email all the time, so I searched for alternatives.
Then I found out that some people use terminal email clients like Mutt, and learned that the inline patch is the right way, not attached.
Let me do the inline patch if there are more chances in the future.

Quoted 43 lines · On Wed, Feb 26, 2025 at 11:03 PM bus710 <[email protected]> wrote:
Quoted 25 lines · On Wed, Feb 26, 2025 at 3:07 PM bus710 <[email protected]> wrote:
Quoted 23 lines · SeongJae Park
Quoted 5 lines · On Wed, 26 Feb 2025 13:37:03 -0800 Andrew Morton <[email protected]>…
Quoted 1 line · On Wed, 26 Feb 2025 10:42:04 -0800 SeongJae Park <[email protected]> wrote:

From: bus710 <[email protected]>

Full names are preferred, please. Actually I think it's "required".

Thank you for letting me clearly know this. I'll request full names to DAMON patch authors from next time.

bus710, we could still update the patch before it is merged into the mainline. If you could, please let us know your full name and if we can update the patch with that.

Quoted 2 lines

I'll apply it anyway due to the patch's minor nature, thanks.

I agree this is a simple enough patch that the name doesn't really matter. Thank you Andrew :)

Quoted 7 lines
Quoted 2 lines

Thanks,
SJ

Oh, yes. I was a little worried if I added too much noise for such a small work, but I shouldn't miss this opportunity to leave my name in Linux history.
Let me prepare a new patch as soon as possible.

Hi all,

Please find the attached patch.
Based on the latest one, from @Andrew Morton I just replaced my ID with my real name as well as updated the subject.

Thank you,
Seongjun Kim

author maintainer
#7 lore raw
Quoted 4 lines · On Thu, 27 Feb 2025 07:35:00 -0800 bus710 <[email protected]> wrote:

I was wondering how others live with the git send-email all the time, so I searched for alternatives.
Then I found out that some people use terminal email clients like Mutt,

Yes, dealing with mails is not easy for beginners. I therefore introduced you hkml before:
https://lore.kernel.org/[email protected]

If Mutt setup doesn't go well, and you haven't tried hkml yet, you could give hkml a try, too.

Quoted 3 lines

and learned that the inline patch is the right way, not attached.
Let me do the inline patch if there are more chances in the future.

Yes, that should be the right approach.

Thanks,
SJ

[...]