Skip to contentSkip to conversation

scsi: scsi_error: Add comments to scsi_check_sense()

PATCH Applied Damien Le Moal 2 participants 2 messages Feb 28, 2025 – Mar 4, 2025 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: scsi_error: Add comments to scsi_check_sense()

Add a comment block describing the COMPLETED case with asc/ascq 0x55/0xa to mention that it relates to command duration limits very special policy 0xD command completion.

---
 drivers/scsi/scsi_error.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/scsi/scsi_error.c +7 -0
index 815e7d63f3e2..d08ed65abfa6 100644
@@ -711,6 +711,13 @@ enum scsi_disposition scsi_check_sense(struct scsi_cmnd *scmd)
 		return SUCCESS;
 
 	case COMPLETED:
+		/*
+		 * A command using command duration limits (CDL) with a
+		 * descriptor set with policy 0xD may be completed with success
+		 * and the sense data DATA CURRENTLY UNAVAILABLE, indicating
+		 * that the command was in fact aborted because it exceeded its
+		 * duration limit. Never retry these commands.
+		 */
 		if (sshdr.asc == 0x55 && sshdr.ascq == 0x0a) {
 			set_scsi_ml_byte(scmd, SCSIML_STAT_DL_TIMEOUT);
 			req->cmd_flags |= REQ_FAILFAST_DEV;
Signature · 1 line
2.48.1
#1 lore raw

Damien,

Quoted 3 lines

Add a comment block describing the COMPLETED case with asc/ascq 0x55/0xa to mention that it relates to command duration limits very special policy 0xD command completion.

Applied to 6.15/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering