perf/hw_breakpoint: Return EOPNOTSUPP for unsupported breakpoint type
PATCH 1/1 perf/hw_breakpoint: Return EOPNOTSUPP for unsupported breakpoint type
Currently, __reserve_bp_slot() returns -ENOSPC for unsupported breakpoint types on the architecture. For example, powerpc does not support hardware instruction breakpoints. This causes the perf_skip BPF selftest to fail, as neither ENOENT nor EOPNOTSUPP is returned by perf_event_open for unsupported breakpoint types. As a result, the test that should be skipped for this arch is not correctly identified.
To resolve this, hw_breakpoint_event_init() should exit early by checking for unsupported breakpoint types using hw_breakpoint_slots_cached() and return the appropriate error (-EOPNOTSUPP).
--- kernel/events/hw_breakpoint.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
kernel/events/hw_breakpoint.c +3 -2
@@ -950,9 +950,10 @@ static int hw_breakpoint_event_init(struct perf_event *bp)return -ENOENT ;/* -* no branch sampling for breakpoint events +* Check if breakpoint type is supported before proceeding. +* Also, no branch sampling for breakpoint events. */ -if (has_branch_stack (bp)) +if (!hw_breakpoint_slots_cached (find_slot_idx (bp->attr.bp_type)) ||has_branch_stack (bp))return -EOPNOTSUPP ; err =register_perf_hw_breakpoint (bp);
Signature · 1 line
2.43.5
The following commit has been merged into the perf/core branch of tip:
The following commit has been merged into the perf/core branch of tip:
Commit-ID: 21d96cea578f83e43ec9016e5bba8703b290c748 Gitweb: https://git.kernel.org/tip/21d96cea578f83e43ec9016e5bba8703b290c748 Author: Saket Kumar Bhaskar <[email protected]> AuthorDate: Mon, 03 Mar 2025 14:54:51 +05:30 Committer: Ingo Molnar <[email protected]> CommitterDate: Mon, 03 Mar 2025 11:23:15 +01:00
perf/hw_breakpoint: Return EOPNOTSUPP for unsupported breakpoint type
Currently, __reserve_bp_slot() returns -ENOSPC for unsupported breakpoint types on the architecture. For example, powerpc does not support hardware instruction breakpoints. This causes the perf_skip BPF selftest to fail, as neither ENOENT nor EOPNOTSUPP is returned by perf_event_open for unsupported breakpoint types. As a result, the test that should be skipped for this arch is not correctly identified.
To resolve this, hw_breakpoint_event_init() should exit early by checking for unsupported breakpoint types using hw_breakpoint_slots_cached() and return the appropriate error (-EOPNOTSUPP).
--- kernel/events/hw_breakpoint.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
kernel/events/hw_breakpoint.c +3 -2
@@ -950,9 +950,10 @@ static int hw_breakpoint_event_init(struct perf_event *bp)return -ENOENT ;/* -* no branch sampling for breakpoint events +* Check if breakpoint type is supported before proceeding. +* Also, no branch sampling for breakpoint events. */ -if (has_branch_stack (bp)) +if (!hw_breakpoint_slots_cached (find_slot_idx (bp->attr.bp_type)) ||has_branch_stack (bp))return -EOPNOTSUPP ; err =register_perf_hw_breakpoint (bp);
The following commit has been merged into the perf/core branch of tip:
The following commit has been merged into the perf/core branch of tip:
Commit-ID: 4118628d0ce005e5651174b9d5fc0209a8d49ee0 Gitweb: https://git.kernel.org/tip/4118628d0ce005e5651174b9d5fc0209a8d49ee0 Author: Saket Kumar Bhaskar <[email protected]> AuthorDate: Mon, 03 Mar 2025 14:54:51 +05:30 Committer: Ingo Molnar <[email protected]> CommitterDate: Mon, 03 Mar 2025 13:24:12 +01:00
perf/hw_breakpoint: Return EOPNOTSUPP for unsupported breakpoint type
Currently, __reserve_bp_slot() returns -ENOSPC for unsupported breakpoint types on the architecture. For example, powerpc does not support hardware instruction breakpoints. This causes the perf_skip BPF selftest to fail, as neither ENOENT nor EOPNOTSUPP is returned by perf_event_open for unsupported breakpoint types. As a result, the test that should be skipped for this arch is not correctly identified.
To resolve this, hw_breakpoint_event_init() should exit early by checking for unsupported breakpoint types using hw_breakpoint_slots_cached() and return the appropriate error (-EOPNOTSUPP).
--- kernel/events/hw_breakpoint.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
kernel/events/hw_breakpoint.c +3 -2
@@ -950,9 +950,10 @@ static int hw_breakpoint_event_init(struct perf_event *bp)return -ENOENT ;/* -* no branch sampling for breakpoint events +* Check if breakpoint type is supported before proceeding. +* Also, no branch sampling for breakpoint events. */ -if (has_branch_stack (bp)) +if (!hw_breakpoint_slots_cached (find_slot_idx (bp->attr.bp_type)) ||has_branch_stack (bp))return -EOPNOTSUPP ; err =register_perf_hw_breakpoint (bp);
Ian Rogers
reviewerQuoted 9 lines · Saket Kumar Bhaskar
Currently,
__reserve_bp_slot()returns-ENOSPCfor unsupported breakpoint types on the architecture. For example, powerpc does not support hardware instruction breakpoints. This causes theperf_skipBPF selftest to fail, as neither ENOENT nor EOPNOTSUPP is returned byperf_event_openfor unsupported breakpoint types. As a result, the test that should be skipped for this arch is not correctly identified.
Quoted 4 lines
To resolve this,
hw_breakpoint_event_init()should exit early by checking for unsupported breakpoint types usinghw_breakpoint_slots_cached()and return the appropriate error (-EOPNOTSUPP).
Hi Saket,
This looks good to me! Did you happen to run "perf test" as there are a couple of tests there covering breakpoint behavior and I wonder if we may need to update them? Particularly there are some comments about PowerPC just not working:
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/perf/tests/bp_account.c#n24
Thanks,
Ian
Quoted 25 lines
Signed-off-by Saket Kumar Bhaskar <[email protected]>--- kernel/events/hw_breakpoint.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)kernel/events/hw_breakpoint.c +3
-3@@ -950,9 +950,10 @@ static int hw_breakpoint_event_init(struct perf_event *bp)return -ENOENT ;/* -* no branch sampling for breakpoint events +* Check if breakpoint type is supported before proceeding. +* Also, no branch sampling for breakpoint events. */ -if (has_branch_stack (bp)) +if (!hw_breakpoint_slots_cached (find_slot_idx (bp->attr.bp_type)) ||has_branch_stack (bp))return -EOPNOTSUPP ; err =register_perf_hw_breakpoint (bp); --2.43.5
The following commit has been merged into the perf/core branch of tip:
The following commit has been merged into the perf/core branch of tip:
Commit-ID: 061c991697062f3bf87b72ed553d1d33a0e370dd Gitweb: https://git.kernel.org/tip/061c991697062f3bf87b72ed553d1d33a0e370dd Author: Saket Kumar Bhaskar <[email protected]> AuthorDate: Mon, 03 Mar 2025 14:54:51 +05:30 Committer: Ingo Molnar <[email protected]> CommitterDate: Tue, 04 Mar 2025 09:42:13 +01:00
perf/hw_breakpoint: Return EOPNOTSUPP for unsupported breakpoint type
Currently, __reserve_bp_slot() returns -ENOSPC for unsupported breakpoint types on the architecture. For example, powerpc does not support hardware instruction breakpoints. This causes the perf_skip BPF selftest to fail, as neither ENOENT nor EOPNOTSUPP is returned by perf_event_open for unsupported breakpoint types. As a result, the test that should be skipped for this arch is not correctly identified.
To resolve this, hw_breakpoint_event_init() should exit early by checking for unsupported breakpoint types using hw_breakpoint_slots_cached() and return the appropriate error (-EOPNOTSUPP).
--- kernel/events/hw_breakpoint.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
kernel/events/hw_breakpoint.c +3 -2
@@ -950,9 +950,10 @@ static int hw_breakpoint_event_init(struct perf_event *bp)return -ENOENT ;/* -* no branch sampling for breakpoint events +* Check if breakpoint type is supported before proceeding. +* Also, no branch sampling for breakpoint events. */ -if (has_branch_stack (bp)) +if (!hw_breakpoint_slots_cached (find_slot_idx (bp->attr.bp_type)) ||has_branch_stack (bp))return -EOPNOTSUPP ; err =register_perf_hw_breakpoint (bp);