dt-bindings: arm: qcom: Add Xiaomi Redmi Note 8
PATCH 1/2 dt-bindings: arm: qcom: Add Xiaomi Redmi Note 8
Document the Xiaomi Redmi Note 8, which is based off the SM6125 SoC
--- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/qcom.yaml +1 -0
@@ -1020,6 +1020,7 @@ properties: - items: - enum: - sony,pdx201 + - xiaomi,ginkgo - xiaomi,laurel-sprout - const: qcom,sm6125
Signature · 1 line
2.47.0
PATCH 2/2 arm64: dts: qcom: sm6125: Initial support for xiaomi-ginkgo
Add support for the Xiaomi Redmi Note 8 based on the SM6125 SoC.
Defined features:
- dmesg output to bootloader preconfigured display
- USB
- eMMC
- SD card
- SMD RPM regulators
- Volume Up, Down and Power buttons
--- arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/sm6125-xiaomi-ginkgo.dts | 294 ++++++++++++++++++ 2 files changed, 295 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
arch/arm64/boot/dts/qcom/Makefile +1 -0
@@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm4450-qrd.dtb dtb-$(CONFIG_ARCH_QCOM) += sm6115-fxtec-pro1x.dtb dtb-$(CONFIG_ARCH_QCOM) += sm6115p-lenovo-j606f.dtb dtb-$(CONFIG_ARCH_QCOM) += sm6125-sony-xperia-seine-pdx201.dtb +dtb-$(CONFIG_ARCH_QCOM) += sm6125-xiaomi-ginkgo.dtb dtb-$(CONFIG_ARCH_QCOM) += sm6125-xiaomi-laurel-sprout.dtb dtb-$(CONFIG_ARCH_QCOM) += sm6350-sony-xperia-lena-pdx213.dtb dtb-$(CONFIG_ARCH_QCOM) += sm6375-sony-xperia-murray-pdx225.dtb
arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts new file +294 -0
294 lines not on this page · raw message
Signature · 1 line
2.47.0
Rob Herring (Arm)
maintainerQuoted 7 lines · Gabriel Gonzales
Document the Xiaomi Redmi Note 8, which is based off the SM6125 SoC
Signed-off-by Gabriel Gonzales <[email protected]>--- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+)
My bot found new DTB warnings on the .dts files added or changed in this series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for [email protected]:
arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dtb: geniqup@4ac0000: #address-cells: 2 was expected
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dtb: geniqup@4ac0000: #size-cells: 2 was expected
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dtb: geniqup@4cc0000: #address-cells: 2 was expected
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dtb: geniqup@4cc0000: #size-cells: 2 was expected
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#
Rob Herring
maintainerQuoted 1 line · Gabriel Gonzales
Document the Xiaomi Redmi Note 8, which is based off the SM6125 SoC
Period.
Perhaps mention where ginkgo comes from. It's not clear if one looks at just the commit msg or just the schema.
Quoted 21 lines
Signed-off-by Gabriel Gonzales <[email protected]>--- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/arm/qcom.yaml +1
-0@@ -1020,6 +1020,7 @@ properties: - items: - enum: - sony,pdx201 + - xiaomi,ginkgo - xiaomi,laurel-sprout - const: qcom,sm6125Signature · 1 line
2.47.0
v2 cover Add Xiaomi Redmi Note 8 support
In reply to Gabriel GonzalesThis patchset introduces support for the Redmi Note 8 (codenamed ginkgo). This series is a follow-up to v1 (message-id in in-reply-to header) which was sent without a cover letter.
Changes in v2:
- Add missing cover letter
- Fix up commit message for schema
Gabriel Gonzales (2):
dt-bindings: arm: qcom: Add Xiaomi Redmi Note 8
arm64: dts: qcom: sm6125: Initial support for xiaomi-ginkgo
.../devicetree/bindings/arm/qcom.yaml | 1 + arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/sm6125-xiaomi-ginkgo.dts | 294 ++++++++++++++++++ 3 files changed, 296 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
Signature · 1 line
2.48.1
PATCH v2 1/2 dt-bindings: arm: qcom: Add Xiaomi Redmi Note 8
Document the Xiaomi Redmi Note 8 (codenamed ginkgo), which is based off the SM6125 SoC.
--- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/qcom.yaml +1 -0
@@ -1020,6 +1020,7 @@ properties: - items: - enum: - sony,pdx201 + - xiaomi,ginkgo - xiaomi,laurel-sprout - const: qcom,sm6125
Signature · 1 line
2.48.1
Quoted 3 lines · Gabriel Gonzales
Document the Xiaomi Redmi Note 8 (codenamed ginkgo), which is based off the SM6125 SoC.
Do not attach (thread) your patchsets to some other threads (unrelated or older versions). This buries them deep in the mailbox and might interfere with applying entire sets.
Quoted 4 lines
Signed-off-by Gabriel Gonzales <[email protected]>--- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+)
---
<form letter>
This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, you can skip it (please do not feel offended by me posting it here - no bad intentions intended). If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply.
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
</form letter>
Best regards,
Krzysztof
PATCH v2 2/2 arm64: dts: qcom: sm6125: Initial support for xiaomi-ginkgo
In reply to Gabriel GonzalesAdd support for the Xiaomi Redmi Note 8 based on the SM6125 SoC.
Defined features:
- dmesg output to bootloader preconfigured display
- USB
- eMMC
- SD card
- SMD RPM regulators
- Volume Up, Down and Power buttons
--- arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/sm6125-xiaomi-ginkgo.dts | 294 ++++++++++++++++++ 2 files changed, 295 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
arch/arm64/boot/dts/qcom/Makefile +1 -0
@@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm4450-qrd.dtb dtb-$(CONFIG_ARCH_QCOM) += sm6115-fxtec-pro1x.dtb dtb-$(CONFIG_ARCH_QCOM) += sm6115p-lenovo-j606f.dtb dtb-$(CONFIG_ARCH_QCOM) += sm6125-sony-xperia-seine-pdx201.dtb +dtb-$(CONFIG_ARCH_QCOM) += sm6125-xiaomi-ginkgo.dtb dtb-$(CONFIG_ARCH_QCOM) += sm6125-xiaomi-laurel-sprout.dtb dtb-$(CONFIG_ARCH_QCOM) += sm6350-sony-xperia-lena-pdx213.dtb dtb-$(CONFIG_ARCH_QCOM) += sm6375-sony-xperia-murray-pdx225.dtb
arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts new file +294 -0
294 lines not on this page · raw message
Signature · 1 line
2.48.1
Re: [PATCH v2 2/2] arm64: dts: qcom: sm6125: Initial support for xiaomi-ginkgo
Quoted 42 lines · Gabriel Gonzales
Add support for the Xiaomi Redmi Note 8 based on the SM6125 SoC.
Defined features:
- dmesg output to bootloader preconfigured display
- USB
- eMMC
- SD card
- SMD RPM regulators
- Volume Up, Down and Power buttonsSigned-off-by Gabriel Gonzales <[email protected]>--- arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/sm6125-xiaomi-ginkgo.dts | 294 ++++++++++++++++++ 2 files changed, 295 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dtsarch/arm64/boot/dts/qcom/Makefile +1
-0@@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm4450-qrd.dtb dtb-$(CONFIG_ARCH_QCOM) += sm6115-fxtec-pro1x.dtb dtb-$(CONFIG_ARCH_QCOM) += sm6115p-lenovo-j606f.dtb dtb-$(CONFIG_ARCH_QCOM) += sm6125-sony-xperia-seine-pdx201.dtb +dtb-$(CONFIG_ARCH_QCOM) += sm6125-xiaomi-ginkgo.dtb dtb-$(CONFIG_ARCH_QCOM) += sm6125-xiaomi-laurel-sprout.dtb dtb-$(CONFIG_ARCH_QCOM) += sm6350-sony-xperia-lena-pdx213.dtb dtb-$(CONFIG_ARCH_QCOM) += sm6375-sony-xperia-murray-pdx225.dtbarch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts new file +7
-0@@ -0,0 +1,294 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) 2025, Gabriel Gonzales <[email protected]> + */ + +/dts-v1/; +
arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts line 17
Quoted 10 lines
arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts new file +10
-0+#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/input/input.h> +#include <dt-bindings/input/gpio-keys.h> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h> +#include "sm6125.dtsi" +#include "pm6125.dtsi" + +/ { + /* required for bootloader to select correct board */ + qcom,msm-id = <394 0>; /* sm6125 v1 */
#include <dt-bindings/arm/qcom,ids.h>
QCOM_ID_SM6125 and drop the comment
Quoted 1 line
arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts new file +1
-0+ qcom,board-id = <22 0>;
[...]
arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts line 100
Quoted 5 lines
+&hsusb_phy1 {
arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts new file +4
-0+ vdd-supply = <&vreg_l7a>; + vdda-pll-supply = <&vreg_l10a>; + vdda-phy-dpdm-supply = <&vreg_l15a>; + status = "okay";
Please add a before 'status', file-wide
[...]
arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts line 285
Quoted 2 lines
+&tlmm {
arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts new file +1
-0+ gpio-reserved-ranges = <22 2>, <28 6>;
Would you happen to know what's on the other end of these?
Konrad
Re: [PATCH v2 2/2] arm64: dts: qcom: sm6125: Initial support for xiaomi-ginkgo
Quoted 6 lines · Konrad Dybcio
Quoted 5 lines
+&hsusb_phy1 {
+ vdd-supply = <&vreg_l7a>;
+ vdda-pll-supply = <&vreg_l10a>;
+ vdda-phy-dpdm-supply = <&vreg_l15a>;
+ status = "okay";Please add a before 'status', file-wide
'a-status'?
[...]
Quoted 4 lines
Quoted 2 lines
+&tlmm {
+ gpio-reserved-ranges = <22 2>, <28 6>;Would you happen to know what's on the other end of these?
Unfortunately, no.
[...]
Gabriel
Re: [PATCH v2 2/2] arm64: dts: qcom: sm6125: Initial support for xiaomi-ginkgo
Quoted 10 lines · Gabriel Gonzales
Quoted 6 lines · Konrad Dybcio
Quoted 5 lines
+&hsusb_phy1 {
+ vdd-supply = <&vreg_l7a>;
+ vdda-pll-supply = <&vreg_l10a>;
+ vdda-phy-dpdm-supply = <&vreg_l15a>;
+ status = "okay";Please add a before 'status', file-wide
'a-status'?
A newline.. the brain didn't synchronize with the hands
Quoted 9 lines
[...]
Quoted 4 lines
Quoted 2 lines
+&tlmm {
+ gpio-reserved-ranges = <22 2>, <28 6>;Would you happen to know what's on the other end of these?
Unfortunately, no.
Usually it's some secure i2c connection and pins for the SPI host that the fingerprint reader sits on
Konrad
Re: [PATCH v2 2/2] arm64: dts: qcom: sm6125: Initial support for xiaomi-ginkgo
Quoted 3 lines · Konrad Dybcio
Quoted 1 line
'a-status'?
A newline.. the brain didn't synchronize with the hands
How about nodes which only have 'status' as a property name? Do they still need to be placed before a NL or keep as-is?
Rob Herring (Arm)
maintainerRe: [PATCH v2 0/2] Add Xiaomi Redmi Note 8 support
In reply to Gabriel GonzalesQuoted 10 lines · Gabriel Gonzales
This patchset introduces support for the Redmi Note 8 (codenamed ginkgo). This series is a follow-up to v1 (message-id in in-reply-to header) which was sent without a cover letter.
Changes in v2:
- Add missing cover letter
- Fix up commit message for schemaGabriel Gonzales (2):
dt-bindings: arm: qcom: Add Xiaomi Redmi Note 8
arm64: dts: qcom: sm6125: Initial support for xiaomi-ginkgo
Quoted 11 lines
.../devicetree/bindings/arm/qcom.yaml | 1 + arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/sm6125-xiaomi-ginkgo.dts | 294 ++++++++++++++++++ 3 files changed, 296 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts--
2.48.1
My bot found new DTB warnings on the .dts files added or changed in this series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for [email protected]:
arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dtb: geniqup@4ac0000: #address-cells: 2 was expected
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dtb: geniqup@4ac0000: #size-cells: 2 was expected
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dtb: geniqup@4cc0000: #address-cells: 2 was expected
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dtb: geniqup@4cc0000: #size-cells: 2 was expected
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#
v3 cover Add Xiaomi Redmi Note 8 support
In reply to Gabriel GonzalesThis patchset introduces support for the Redmi Note 8 (codenamed ginkgo).
Changes in v2:
- Add missing cover letter
- Fix up commit message for schema
Changes in v3:
- Use qcom ids instead of hardcoded msm-id (and other changes suggested by Konrad)
- Switch up model properties and qcom properties position
Gabriel Gonzales (2):
dt-bindings: arm: qcom: Add Xiaomi Redmi Note 8
arm64: dts: qcom: sm6125: Initial support for xiaomi-ginkgo
.../devicetree/bindings/arm/qcom.yaml | 1 + arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/sm6125-xiaomi-ginkgo.dts | 295 ++++++++++++++++++ 3 files changed, 297 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
Signature · 1 line
2.48.1
PATCH v3 1/2 dt-bindings: arm: qcom: Add Xiaomi Redmi Note 8
Document the Xiaomi Redmi Note 8 (codenamed ginkgo), which is based off the SM6125 SoC.
--- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/qcom.yaml +1 -0
@@ -1020,6 +1020,7 @@ properties: - items: - enum: - sony,pdx201 + - xiaomi,ginkgo - xiaomi,laurel-sprout - const: qcom,sm6125
Signature · 1 line
2.48.1
Quoted 5 lines · Gabriel Gonzales
Document the Xiaomi Redmi Note 8 (codenamed ginkgo), which is based off the SM6125 SoC.
Signed-off-by Gabriel Gonzales <[email protected]>
How did you resolve my first comment to your v2?
Best regards,
Krzysztof
PATCH v3 2/2 arm64: dts: qcom: sm6125: Initial support for xiaomi-ginkgo
In reply to Gabriel GonzalesAdd support for the Xiaomi Redmi Note 8 based on the SM6125 SoC.
Defined features:
- dmesg output to bootloader preconfigured display
- USB
- eMMC
- SD card
- SMD RPM regulators
- Volume Up, Down and Power buttons
--- arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/sm6125-xiaomi-ginkgo.dts | 295 ++++++++++++++++++ 2 files changed, 296 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
arch/arm64/boot/dts/qcom/Makefile +1 -0
@@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm4450-qrd.dtb dtb-$(CONFIG_ARCH_QCOM) += sm6115-fxtec-pro1x.dtb dtb-$(CONFIG_ARCH_QCOM) += sm6115p-lenovo-j606f.dtb dtb-$(CONFIG_ARCH_QCOM) += sm6125-sony-xperia-seine-pdx201.dtb +dtb-$(CONFIG_ARCH_QCOM) += sm6125-xiaomi-ginkgo.dtb dtb-$(CONFIG_ARCH_QCOM) += sm6125-xiaomi-laurel-sprout.dtb dtb-$(CONFIG_ARCH_QCOM) += sm6350-sony-xperia-lena-pdx213.dtb dtb-$(CONFIG_ARCH_QCOM) += sm6375-sony-xperia-murray-pdx225.dtb
arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts new file +295 -0
295 lines not on this page · raw message
Signature · 1 line
2.48.1
Rob Herring (Arm)
maintainerRe: [PATCH v3 0/2] Add Xiaomi Redmi Note 8 support
In reply to Gabriel GonzalesQuoted 13 lines · Gabriel Gonzales
This patchset introduces support for the Redmi Note 8 (codenamed ginkgo).
Changes in v2:
- Add missing cover letter
- Fix up commit message for schema
Changes in v3:
- Use qcom ids instead of hardcoded msm-id (and other changes suggested by Konrad)
- Switch up model properties and qcom properties positionGabriel Gonzales (2):
dt-bindings: arm: qcom: Add Xiaomi Redmi Note 8
arm64: dts: qcom: sm6125: Initial support for xiaomi-ginkgo
Quoted 11 lines
.../devicetree/bindings/arm/qcom.yaml | 1 + arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/sm6125-xiaomi-ginkgo.dts | 295 ++++++++++++++++++ 3 files changed, 297 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts--
2.48.1
My bot found new DTB warnings on the .dts files added or changed in this series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for [email protected]:
arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dtb: /: qcom,msm-id:0: [394] is too short
from schema $id: http://devicetree.org/schemas/arm/qcom.yaml#arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dtb: geniqup@4ac0000: #address-cells: 2 was expected
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dtb: geniqup@4ac0000: #size-cells: 2 was expected
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dtb: geniqup@4cc0000: #address-cells: 2 was expected
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dtb: geniqup@4cc0000: #size-cells: 2 was expected
from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,geni-se.yaml#
Re: [PATCH v3 0/2] Add Xiaomi Redmi Note 8 support
In reply to Gabriel GonzalesQuoted 10 lines · Gabriel Gonzales
This patchset introduces support for the Redmi Note 8 (codenamed ginkgo).
Changes in v2:
- Add missing cover letter
- Fix up commit message for schema
Changes in v3:
- Use qcom ids instead of hardcoded msm-id (and other changes suggested by Konrad)
- Switch up model properties and qcom properties position[...]
Applied, thanks!
[1/2] dt-bindings: arm: qcom: Add Xiaomi Redmi Note 8
commit: 4ca8d6f898a85070934490071e429e97bc4e219b
[2/2] arm64: dts: qcom: sm6125: Initial support for xiaomi-ginkgo
commit: 9b1a6c925c88ed9331a2cae64fb3580e05345dedBest regards,
Signature · 1 line
Bjorn Andersson <[email protected]>
Re: [PATCH v3 0/2] Add Xiaomi Redmi Note 8 support
In reply to Gabriel GonzalesQuoted 8 lines · Gabriel Gonzales
This patchset introduces support for the Redmi Note 8 (codenamed ginkgo).
Changes in v2:
- Add missing cover letter
- Fix up commit message for schema
Changes in v3:
- Use qcom ids instead of hardcoded msm-id (and other changes suggested by Konrad)
- Switch up model properties and qcom properties position
Hi, I noticed that the msm-id is failing the dt-bindings check (need two values, with the first one being the SoC ID and the second one being the revision - 0x10000 as there was only ever a single rev of 6125)
I also found this dt:
which suggests that the board ID you used may be incorrect
(you put in 22 and the link above says 34 - FWIW 0x22 == 34, maybe that's related?)
Could you please give the below a shot and see if it still boots?
From ccef64e4058ba657ada5000ec3c2aa9b682c552b Mon Sep 17 00:00:00 2001
From: Konrad Dybcio <[email protected]>
Date: Fri, 8 Aug 2025 11:45:06 +0200
Subject: [PATCH] arm64: dts: qcom: sm6125-xiaomi-ginkgo: Fix up msm/board ID
Include a version in the SoC ID (mostly to appease the bindings checker) and fix up the board-id according to match the device's BSP kernel.
--- arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts +2 -2
@@ -19,8 +19,8 @@ / { chassis-type = "handset"; /* required for bootloader to select correct board */ - qcom,msm-id = <QCOM_ID_SM6125>; - qcom,board-id = <22 0>; + qcom,msm-id = <QCOM_ID_SM6125 0x10000>; + qcom,board-id = <34 0>; chosen { #address-cells = <2>;
Signature · 3 lines
2.50.1 Konrad