platform/x86: thinkpad_acpi: Add new sysfs to check user presence sensing status
Subsystems (2)
PATCH 1/1 platform/x86: thinkpad_acpi: Add new sysfs to check user presence sensing status
Some Thinkpad products support Human Presence Detection (HPD) features. Add new sysfs entry so that userspace can determine if feature is supported or not.
--- .../admin-guide/laptops/thinkpad-acpi.rst | 20 +++++ drivers/platform/x86/thinkpad_acpi.c | 79 +++++++++++++++++++ 2 files changed, 99 insertions(+)
Documentation/admin-guide/laptops/thinkpad-acpi.rst +20 -0
@@ -1576,6 +1576,26 @@ percentage level, above which charging will stop. The exact semantics of the attributes may be found in Documentation/ABI/testing/sysfs-class-power. +User Presence Sensing Detection +------ + +sysfs: hpd_bios_enabled + +Some Thinkpad products support Human Presence Detection (HPD) features. +Added new sysfs entry so that userspace can determine if feature related to +HPD should be enabled or disabled. + +The available commands are:: + + cat /sys/devices/platform/thinkpad_acpi/hpd_bios_enabled + +BIOS status is mentioned as below: +- 0 = Disable +- 1 = Enable + +The property is read-only. If the platform doesn't have support the sysfs +class is not created. + Multiple Commands, Module Parameters ------------------------------------
drivers/platform/x86/thinkpad_acpi.c +79 -0
97 lines not on this page · raw message
Signature · 1 line
2.43.0
Quoted 5 lines · Nitin Joshi
Some Thinkpad products support Human Presence Detection (HPD) features. Add new sysfs entry so that userspace can determine if feature is supported or not.
Reviewed-by Mark Pearson <[email protected]>
Just in case we're breaking protocol - I have reviewed this off mailing list with Nitin and gave it the thumbs up. The tag is correct.
Mark
Quoted 147 lines
Signed-off-by Nitin Joshi <[email protected]>--- .../admin-guide/laptops/thinkpad-acpi.rst | 20 +++++ drivers/platform/x86/thinkpad_acpi.c | 79 +++++++++++++++++++ 2 files changed, 99 insertions(+)Documentation/admin-guide/laptops/thinkpad-acpi.rst +20
-0@@ -1576,6 +1576,26 @@ percentage level, above which charging will stop. The exact semantics of the attributes may be found in Documentation/ABI/testing/sysfs-class-power. +User Presence Sensing Detection +------ + +sysfs: hpd_bios_enabled + +Some Thinkpad products support Human Presence Detection (HPD) features. +Added new sysfs entry so that userspace can determine if feature related to +HPD should be enabled or disabled. + +The available commands are:: + + cat /sys/devices/platform/thinkpad_acpi/hpd_bios_enabled + +BIOS status is mentioned as below: +- 0 = Disable +- 1 = Enable + +The property is read-only. If the platform doesn't have support the sysfs +class is not created. + Multiple Commands, Module Parameters ------------------------------------drivers/platform/x86/thinkpad_acpi.c +74
-0@@ -11039,6 +11039,80 @@ static const struct attribute_group auxmac_attr_group = { .attrs = auxmac_attributes, }; +/************************************************************************* +* CHPD subdriver, for the Lenovo Human Presence Detection feature. +*/ +#define CHPD_GET_SENSOR_STATUS 0x00200000 +#define CHPD_GET_BIOS_UI_STATUS 0x00100000 + +static bool has_user_presence_sensing; +static int hpd_bios_status; +static int chpd_command (int command,int *output) +{ +acpi_handle chpd_handle; + +if (ACPI_FAILURE (acpi_get_handle (hkey_handle,"CHPD" , &chpd_handle))) { +/* Platform doesn't support CHPD */ +return -ENODEV ; + } + +if (!acpi_evalf (chpd_handle, output,NULL ,"dd" , command)) +return -EIO ; + +return 0 ; +} + +/* sysfs hpd bios status */ +static ssize_t hpd_bios_enabled_show (struct device *dev, +struct device_attribute *attr, +char *buf) +{ +return sysfs_emit (buf,"%d\n" , hpd_bios_status); +} +static DEVICE_ATTR_RO (hpd_bios_enabled); + +static struct attribute *chpd_attributes[] = { + &dev_attr_hpd_bios_enabled.attr, +NULL +}; + +static umode_t chpd_attr_is_visible (struct kobject *kobj, +struct attribute *attr,int n) +{ +return has_user_presence_sensing ? attr->mode :0 ; +} + +static const struct attribute_group chpd_attr_group = { + .is_visible = chpd_attr_is_visible, + .attrs = chpd_attributes, +}; + +static int tpacpi_chpd_init (struct ibm_init_struct *iibm) +{ +int err, output; + + err =chpd_command (CHPD_GET_SENSOR_STATUS , &output); +if (err) +return err; + +if (output ==1 ) +return -ENODEV ; + + has_user_presence_sensing = true; +/* Get User Presence Sensing BIOS status */ + err =chpd_command (CHPD_GET_BIOS_UI_STATUS , &output); +if (err) +return err; + + hpd_bios_status = (output >>1 ) &BIT (0 ); + +return err; +} + +static struct ibm_struct chpd_driver_data = { + .name ="chpd" , +}; +/* --------------------------------------------------------------------- */ static struct attribute *tpacpi_driver_attributes[] = {
drivers/platform/x86/thinkpad_acpi.c +5
-0@@ -11098,6 +11172,7 @@ static const struct attribute_group *tpacpi_groups[] = { &kbdlang_attr_group, &dprc_attr_group, &auxmac_attr_group, + &chpd_attr_group, NULL, };@@ -11694,6 +11769,10 @@ static struct ibm_init_struct ibms_init[]__initdata = { .init = auxmac_init, .data = &auxmac_data, }, + { + .init = tpacpi_chpd_init, + .data = &chpd_driver_data, + }, };static int
__initset_ibm_param(const char *val, const struct kernel_param *kp)Signature · 1 line
2.43.0
Hi Nitin, Mark,
Quoted 9 lines · Mark Pearson
Quoted 5 lines · Nitin Joshi
Some Thinkpad products support Human Presence Detection (HPD) features. Add new sysfs entry so that userspace can determine if feature is supported or not.
Reviewed-by Mark Pearson <[email protected]>Just in case we're breaking protocol - I have reviewed this off mailing list with Nitin and gave it the thumbs up. The tag is correct.
Adding a Reviewed-by tag based on internal reviews done before submitting v1 is fine, no worries.
I do wonder what the use-case for this exactly is?
The current documentation of "so that userspace can determine if feature related to HPD should be enabled or disabled."
is a bit vague. The reason I'm asking is because I'm wondering if this is the best API to expose this to userspace.
Also if I understand things correctly this is only about checking if:
1) There is HPD support on the machine at all (if yes this file will exist)
2) If HPD is supported on this machine, is it also enabled or disabled in the BIOS?
IOW this is not about actually getting the HPD result, which would be "human present" or "human not present", right ?
Any plans to export the actual HPD result ?
Also if this is just about checking the BIOS setting why not just use the think-lmi driver / firmware-attribute sysfs API for that ?
Quoted 15 lines
Quoted 15 lines
Signed-off-by Nitin Joshi <[email protected]>--- .../admin-guide/laptops/thinkpad-acpi.rst | 20 +++++ drivers/platform/x86/thinkpad_acpi.c | 79 +++++++++++++++++++ 2 files changed, 99 insertions(+)Documentation/admin-guide/laptops/thinkpad-acpi.rst +0
-0@@ -1576,6 +1576,26 @@ percentage level, above which charging will stop. The exact semantics of the attributes may be found in Documentation/ABI/testing/sysfs-class-power.
Quoted 8 lines
Documentation/admin-guide/laptops/thinkpad-acpi.rst percentage level, above which charging will stop. · line 1586
Quoted 8 lines
Documentation/admin-guide/laptops/thinkpad-acpi.rst +8
-0+User Presence Sensing Detection +------ + +sysfs: hpd_bios_enabled + +Some Thinkpad products support Human Presence Detection (HPD) features. +Added new sysfs entry so that userspace can determine if feature related to +HPD should be enabled or disabled.
"Added new sysfs entry ..." sounds more like something for a commit message then for in an ABI Documentation file. In 5 years the "adding new sysfs" language is going to look really weird in this file.
Please just describe the function + intended uses without using "Adding new".
Quoted 83 lines
Quoted 83 lines
Documentation/admin-guide/laptops/thinkpad-acpi.rst +12
-0+ +The available commands are:: + + cat /sys/devices/platform/thinkpad_acpi/hpd_bios_enabled + +BIOS status is mentioned as below: +- 0 = Disable +- 1 = Enable + +The property is read-only. If the platform doesn't have support the sysfs +class is not created. + Multiple Commands, Module Parameters ------------------------------------drivers/platform/x86/thinkpad_acpi.c +58
-0@@ -11039,6 +11039,80 @@ static const struct attribute_group auxmac_attr_group = { .attrs = auxmac_attributes, }; +/************************************************************************* +* CHPD subdriver, for the Lenovo Human Presence Detection feature. +*/ +#define CHPD_GET_SENSOR_STATUS 0x00200000 +#define CHPD_GET_BIOS_UI_STATUS 0x00100000 + +static bool has_user_presence_sensing; +static int hpd_bios_status; +static int chpd_command (int command,int *output) +{ +acpi_handle chpd_handle; + +if (ACPI_FAILURE (acpi_get_handle (hkey_handle,"CHPD" , &chpd_handle))) { +/* Platform doesn't support CHPD */ +return -ENODEV ; + } + +if (!acpi_evalf (chpd_handle, output,NULL ,"dd" , command)) +return -EIO ; + +return 0 ; +} + +/* sysfs hpd bios status */ +static ssize_t hpd_bios_enabled_show (struct device *dev, +struct device_attribute *attr, +char *buf) +{ +return sysfs_emit (buf,"%d\n" , hpd_bios_status); +} +static DEVICE_ATTR_RO (hpd_bios_enabled); + +static struct attribute *chpd_attributes[] = { + &dev_attr_hpd_bios_enabled.attr, +NULL +}; + +static umode_t chpd_attr_is_visible (struct kobject *kobj, +struct attribute *attr,int n) +{ +return has_user_presence_sensing ? attr->mode :0 ; +} + +static const struct attribute_group chpd_attr_group = { + .is_visible = chpd_attr_is_visible, + .attrs = chpd_attributes, +}; + +static int tpacpi_chpd_init (struct ibm_init_struct *iibm) +{ +int err, output; + + err =chpd_command (CHPD_GET_SENSOR_STATUS , &output); +if (err) +return err; + +if (output ==1 ) +return -ENODEV ;
Quoted 8 lines
drivers/platform/x86/thinkpad_acpi.c static const struct attribute_group auxmac_attr_group = { · line 11107
Quoted 8 lines
drivers/platform/x86/thinkpad_acpi.c +8
-0+ + has_user_presence_sensing = true; +/* Get User Presence Sensing BIOS status */ + err =chpd_command (CHPD_GET_BIOS_UI_STATUS , &output); +if (err) +return err; + + hpd_bios_status = (output >>1 ) &BIT (0 );
Please add a define for this rather then just hardcoding a shift by 1.
Quoted 30 lines
Quoted 30 lines
drivers/platform/x86/thinkpad_acpi.c +8
-0+ +return err; +} + +static struct ibm_struct chpd_driver_data = { + .name ="chpd" , +}; +/* --------------------------------------------------------------------- */ static struct attribute *tpacpi_driver_attributes[] = {
drivers/platform/x86/thinkpad_acpi.c +5
-0@@ -11098,6 +11172,7 @@ static const struct attribute_group *tpacpi_groups[] = { &kbdlang_attr_group, &dprc_attr_group, &auxmac_attr_group, + &chpd_attr_group, NULL, };@@ -11694,6 +11769,10 @@ static struct ibm_init_struct ibms_init[]__initdata = { .init = auxmac_init, .data = &auxmac_data, }, + { + .init = tpacpi_chpd_init, + .data = &chpd_driver_data, + }, };
Quoted 4 lines
Quoted 3 lines
static int
__initset_ibm_param(const char *val, const struct kernel_param *kp)Signature · 1 line
2.43.0
Regards,
Hans
Hi Hans,
Thank you very much for your comments.
Quoted 21 lines
-----Original Message-----
From: Hans de Goede <[email protected]>
Sent: Wednesday, March 5, 2025 8:37 PM
To: Mark Pearson <[email protected]>; Nitin Joshi <[email protected]>; Ilpo Järvinen <[email protected]>
Cc: [email protected]; ibm-acpi- [email protected]; [email protected]; Nitin Joshi1 <[email protected]>
Subject: [External] Re: [PATCH] platform/x86:thinkpad_acpi: Add new sysfs to check user presence sensing statusHi Nitin, Mark,
Quoted 3 lines · Mark Pearson
Quoted 1 line · Nitin Joshi
Some Thinkpad products support Human Presence Detection (HPD)
features.
Quoted 3 lines
Quoted 3 lines
Add new sysfs entry so that userspace can determine if feature is supported or not.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Reviewed-by Mark Pearson <[email protected]>Just in case we're breaking protocol - I have reviewed this off mailing list with
Nitin and gave it the thumbs up. The tag is correct.
Adding a Reviewed-by tag based on internal reviews done before submitting v1 is fine, no worries.
Noted , Thank you !
Quoted 3 lines
I do wonder what the use-case for this exactly is?
This setting will be used to enable or disable features like "Lock on Leave" etc from user-space.
Quoted 10 lines
The current documentation of "so that userspace can determine if feature related to HPD should be enabled or disabled."
is a bit vague. The reason I'm asking is because I'm wondering if this is the best API to expose this to userspace.
Also if I understand things correctly this is only about checking if:
1) There is HPD support on the machine at all (if yes this file will exist)
I am also checking sensor status i.e CHPD_GET_SENSOR_STATUS from BIOS. So , if there is no sensor present then file will not exist .
Quoted 2 lines
2) If HPD is supported on this machine, is it also enabled or disabled in the BIOS?
User need to explicitly enable or disable it in BIOS for example user need to disable it , if does not want to use "HPD" related features like "Lock on Leave" etc .
Quoted 4 lines
IOW this is not about actually getting the HPD result, which would be "human present" or "human not present", right ?
Yes , your understanding is correct .
Quoted 1 line
Any plans to export the actual HPD result ?
Yes , there is discussion on-going with Intel to export actual HPD result but there is no fixed time plan as of now.
Quoted 3 lines
Also if this is just about checking the BIOS setting why not just use the think-lmi driver / firmware-attribute sysfs API for that ?
Sorry, I completely missed it .
Yes, as of now , we can use firmware-attribute sysfs to check enable and disable status . In case , we need additional information after actual HPD data is available then we can revisit this patch .
Is this acceptable ? Sorry, if any inconvenience !
Quoted 24 lines
Quoted 17 lines
Quoted 17 lines
Signed-off-by Nitin Joshi <[email protected]>--- .../admin-guide/laptops/thinkpad-acpi.rst | 20 +++++ drivers/platform/x86/thinkpad_acpi.c | 79 +++++++++++++++++++ 2 files changed, 99 insertions(+)Documentation/admin-guide/laptops/thinkpad-acpi.rst +0
-0@@ -1576,6 +1576,26 @@ percentage level, above which charging will stop. The exact semantics of the attributes may be found in
Documentation/ABI/testing/sysfs-class-power.Quoted 6 lines
Documentation/admin-guide/laptops/thinkpad-acpi.rst percentage level, above which charging will stop.
Quoted 6 lines
Documentation/admin-guide/laptops/thinkpad-acpi.rst +6
-0+User Presence Sensing Detection +------ + +sysfs: hpd_bios_enabled + +Some Thinkpad products support Human Presence Detection (HPD)features.
Quoted 9 lines
Quoted 2 lines
Documentation/admin-guide/laptops/thinkpad-acpi.rst
Quoted 2 lines
Documentation/admin-guide/laptops/thinkpad-acpi.rst +2
-0+Added new sysfs entry so that userspace can determine if feature +related to HPD should be enabled or disabled."Added new sysfs entry ..." sounds more like something for a commit message then for in an ABI Documentation file. In 5 years the "adding new sysfs" language is going to look really weird in this file.
Please just describe the function + intended uses without using "Adding new".
Noted , Thanks !
Quoted 84 lines
Quoted 15 lines
Quoted 15 lines
Documentation/admin-guide/laptops/thinkpad-acpi.rst +12
-0+ +The available commands are:: + + cat /sys/devices/platform/thinkpad_acpi/hpd_bios_enabled + +BIOS status is mentioned as below: +- 0 = Disable +- 1 = Enable + +The property is read-only. If the platform doesn't have support the +sysfs class is not created. + Multiple Commands, Module Parameters ------------------------------------Quoted 11 lines
drivers/platform/x86/thinkpad_acpi.c static const struct attribute_group · line 11043
Quoted 11 lines
drivers/platform/x86/thinkpad_acpi.c +0
-0@@ -11039,6 +11039,80 @@ static const struct attribute_group auxmac_attr_group = { .attrs = auxmac_attributes, };+/***************************************************************
****Quoted 11 lines
drivers/platform/x86/thinkpad_acpi.c static const struct attribute_group auxmac_attr_group = {
Quoted 11 lines
drivers/platform/x86/thinkpad_acpi.c +11
-0+****** +* CHPD subdriver, for the Lenovo Human Presence Detection feature. +*/ +#define CHPD_GET_SENSOR_STATUS 0x00200000 +#define CHPD_GET_BIOS_UI_STATUS 0x00100000 + +static bool has_user_presence_sensing;static int hpd_bios_status; +static int chpd_command (int command,int *output) { +acpi_handle chpd_handle; + + if (ACPI_FAILURE(acpi_get_handle(hkey_handle, "CHPD",
&chpd_handle))) {Quoted 44 lines
Quoted 44 lines
drivers/platform/x86/thinkpad_acpi.c +44
-0+/* Platform doesn't support CHPD */ +return -ENODEV ; + } + +if (!acpi_evalf (chpd_handle, output,NULL ,"dd" , command)) +return -EIO ; + +return 0 ; +} + +/* sysfs hpd bios status */ +static ssize_t hpd_bios_enabled_show (struct device *dev, +struct device_attribute *attr, +char *buf) +{ +return sysfs_emit (buf,"%d\n" , hpd_bios_status); }static +DEVICE_ATTR_RO (hpd_bios_enabled); + +static struct attribute *chpd_attributes[] = { + &dev_attr_hpd_bios_enabled.attr, +NULL +}; + +static umode_t chpd_attr_is_visible (struct kobject *kobj, +struct attribute *attr,int n) +{ +return has_user_presence_sensing ? attr->mode :0 ; } + +static const struct attribute_group chpd_attr_group = { + .is_visible = chpd_attr_is_visible, + .attrs = chpd_attributes, +}; + +static int tpacpi_chpd_init (struct ibm_init_struct *iibm) { +int err, output; + + err =chpd_command (CHPD_GET_SENSOR_STATUS , &output); +if (err) +return err; + +if (output ==1 ) +return -ENODEV ; + + has_user_presence_sensing = true;
Quoted 9 lines
Quoted 6 lines
drivers/platform/x86/thinkpad_acpi.c static const struct attribute_group auxmac_attr_group = { · line 11107
Quoted 6 lines
drivers/platform/x86/thinkpad_acpi.c +6
-0+/* Get User Presence Sensing BIOS status */ + err =chpd_command (CHPD_GET_BIOS_UI_STATUS , &output); +if (err) +return err; + + hpd_bios_status = (output >>1 ) &BIT (0 );Please add a define for this rather then just hardcoding a shift by 1.
Ack , Thank you !
Quoted 39 lines
Quoted 32 lines
Quoted 32 lines
drivers/platform/x86/thinkpad_acpi.c +8
-1+ +return err; +} + +static struct ibm_struct chpd_driver_data = { + .name ="chpd" , +}; +/* --------------------------------------------------------------------- */
static struct attribute *tpacpi_driver_attributes[] = { @@ -11098,6
+11172,7 @@ static const structattribute_group*tpacpi_groups[] = {drivers/platform/x86/thinkpad_acpi.c +5
-0&kbdlang_attr_group, &dprc_attr_group, &auxmac_attr_group, + &chpd_attr_group, NULL, };@@ -11694,6 +11769,10 @@ static struct ibm_init_struct ibms_init[]__initdata = { .init = auxmac_init, .data = &auxmac_data, }, + { + .init = tpacpi_chpd_init, + .data = &chpd_driver_data, + }, };Quoted 5 lines
Quoted 4 lines
static int
__initset_ibm_param(const char *val, const structkernel_param*kp)
--
2.43.0
Quoted 3 lines
Regards,
Hans
Thanks & Regards,
Nitin Joshi