pinctrl: spacemit: destroy mutex at driver detach
Subsystems (4)
PATCH 1/1 pinctrl: spacemit: destroy mutex at driver detach
From: Bartosz Golaszewski <[email protected]>
The mutex initialized in probe() is never cleaned up. Use devm_mutex_init() to destroy it automatically.
Signed-off-by Bartosz Golaszewski <[email protected]>
--- drivers/pinctrl/spacemit/pinctrl-k1.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/pinctrl/spacemit/pinctrl-k1.c +5 -1
@@ -9,6 +9,7 @@#include <linux/seq_file.h> #include <linux/spinlock.h> #include <linux/module.h> +#include <linux/mutex.h> #include <linux/pinctrl/pinconf-generic.h> #include <linux/pinctrl/pinconf.h>
@@ -749,7 +750,10 @@ static int spacemit_pinctrl_probe(struct platform_device *pdev) pctrl->data = pctrl_data; pctrl->dev = dev;raw_spin_lock_init (&pctrl->lock); -mutex_init (&pctrl->mutex); + + ret =devm_mutex_init (dev, &pctrl->mutex); +if (ret) +return ret;platform_set_drvdata (pdev, pctrl);
Signature · 1 line
2.45.2
Quoted 5 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
The mutex initialized in
probe()is never cleaned up. Usedevm_mutex_init()to destroy it automatically.
Reviewed-by Yixun Lan <[email protected]>
Quoted 32 lines
Signed-off-by Bartosz Golaszewski <[email protected]>--- drivers/pinctrl/spacemit/pinctrl-k1.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)drivers/pinctrl/spacemit/pinctrl-k1.c +5
-1@@ -9,6 +9,7 @@#include <linux/seq_file.h> #include <linux/spinlock.h> #include <linux/module.h> +#include <linux/mutex.h> #include <linux/pinctrl/pinconf-generic.h> #include <linux/pinctrl/pinconf.h> @@ -749,7 +750,10 @@ static int spacemit_pinctrl_probe(struct platform_device *pdev) pctrl->data = pctrl_data; pctrl->dev = dev;raw_spin_lock_init (&pctrl->lock); -mutex_init (&pctrl->mutex); + + ret =devm_mutex_init (dev, &pctrl->mutex); +if (ret) +return ret;platform_set_drvdata (pdev, pctrl);Signature · 1 line
2.45.2
Signature · 3 lines
Yixun Lan (dlan) Gentoo Linux Developer GPG Key ID AABEFD55
Quoted 7 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
The mutex initialized in
probe()is never cleaned up. Usedevm_mutex_init()to destroy it automatically.Signed-off-by Bartosz Golaszewski <[email protected]>---
Reviewed-by Javier Martinez Canillas <[email protected]>
Signature · 5 lines
Best regards, Javier Martinez Canillas Core Platforms Red Hat
Quoted 6 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
The mutex initialized in
probe()is never cleaned up. Usedevm_mutex_init()to destroy it automatically.Signed-off-by Bartosz Golaszewski <[email protected]>
Patch applied!
Yours,
Linus Walleij