Skip to contentSkip to conversation

kbuild: install-extmod-build: Fix build when specifying KBUILD_OUTPUT

PATCH In review Inochi Amaoto 2 participants 2 messages Mar 6, 2025 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 kbuild: install-extmod-build: Fix build when specifying KBUILD_OUTPUT

Since commit 5f73e7d0386d ("kbuild: refactor cross-compiling linux-headers package"), the linux-headers pacman package fails to build when "O=" is set. The build system complains:

/mnt/chroot/linux/scripts/Makefile.build:41: mnt/chroots/linux-mainline/pacman/linux-upstream/pkg/linux-upstream-headers/usr//lib/modules/6.14.0-rc3-00350-g771dba31fffc/build/scripts/Makefile: No such file or directory

This is because the "srcroot" variable is set to "." and the "build" variable is set to the absolute path. This makes the "src" variables point to wrong directory.

Change the "build" variable to a relative path to "." to fix build.

Fixes 5f73e7d0386d ("kbuild: refactor cross-compiling linux-headers package")

---
Changed from v1:
- https://lore.kernel.org/all/[email protected]/
1. fix shellcheck warning C2086

---
 scripts/package/install-extmod-build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/package/install-extmod-build +1 -1
index 2966473b4660..b96538787f3d 100755
@@ -63,7 +63,7 @@ if [ "${CC}" != "${HOSTCC}" ]; then
 	# Clear VPATH and srcroot because the source files reside in the output
 	# directory.
 	# shellcheck disable=SC2016 # $(MAKE) and $(build) will be expanded by Make
-	"${MAKE}" run-command KBUILD_RUN_COMMAND='+$(MAKE) HOSTCC='"${CC}"' VPATH= srcroot=. $(build)='"${destdir}"/scripts
+	"${MAKE}" run-command KBUILD_RUN_COMMAND='+$(MAKE) HOSTCC='"${CC}"' VPATH= srcroot=. $(build)='"$(realpath --relative-base=. "${destdir}")"/scripts
 
 	rm -f "${destdir}/scripts/Kbuild"
 fi

--
2.48.1

#1 lore raw
Quoted 14 lines · Inochi Amaoto

Since commit 5f73e7d0386d ("kbuild: refactor cross-compiling linux-headers package"), the linux-headers pacman package fails to build when "O=" is set. The build system complains:

/mnt/chroot/linux/scripts/Makefile.build:41: mnt/chroots/linux-mainline/pacman/linux-upstream/pkg/linux-upstream-headers/usr//lib/modules/6.14.0-rc3-00350-g771dba31fffc/build/scripts/Makefile: No such file or directory

This is because the "srcroot" variable is set to "." and the "build" variable is set to the absolute path. This makes the "src" variables point to wrong directory.

Change the "build" variable to a relative path to "." to fix build.

Quoted 6 lines
Fixes 5f73e7d0386d ("kbuild: refactor cross-compiling linux-headers package")

---
Changed from v1:
- https://lore.kernel.org/all/[email protected]/
1. fix shellcheck warning C2086

Applied to linux-kbuild/fixes.
Thanks.

Quoted 20 lines
---
 scripts/package/install-extmod-build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/package/install-extmod-build +1 -2
index 2966473b4660..b96538787f3d 100755
@@ -63,7 +63,7 @@ if [ "${CC}" != "${HOSTCC}" ]; then
        # Clear VPATH and srcroot because the source files reside in the output
        # directory.
        # shellcheck disable=SC2016 # $(MAKE) and $(build) will be expanded by Make
-       "${MAKE}" run-command KBUILD_RUN_COMMAND='+$(MAKE) HOSTCC='"${CC}"' VPATH= srcroot=. $(build)='"${destdir}"/scripts
+       "${MAKE}" run-command KBUILD_RUN_COMMAND='+$(MAKE) HOSTCC='"${CC}"' VPATH= srcroot=. $(build)='"$(realpath --relative-base=. "${destdir}")"/scripts
 
        rm -f "${destdir}/scripts/Kbuild"
 fi
--

2.48.1

Signature · 2 lines
Best Regards
Masahiro Yamada