media: v4l2-core: Replace the check for firmware registered I²C devices
PATCH v2 1/1 media: v4l2-core: Replace the check for firmware registered I²C devices
Replace the check for firmware registered I²C devices as the firmware node independently on type should be retrieved via dev_fwnode().
---
v2: fixed obvious typo (media CI)
drivers/media/v4l2-core/v4l2-i2c.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/v4l2-core/v4l2-i2c.c +2 -1
@@ -5,6 +5,7 @@#include <linux/i2c.h> #include <linux/module.h> +#include <linux/property.h> #include <media/v4l2-common.h> #include <media/v4l2-device.h>
@@ -24,7 +25,7 @@ void v4l2_i2c_subdev_unregister(struct v4l2_subdev *sd)* registered by us, and would not be * re-created by just probing the V4L2 driver. */ -if (client && !client->dev.of_node && !client->dev.fwnode) +if (client && !dev_fwnode (&client->dev))i2c_unregister_device (client); }
Signature · 1 line
2.47.2
Quoted 7 lines · Patchwork Integration
Dear Andy Shevchenko:
Thanks for your patches! Unfortunately the Media CI robot detected some issues:
# Test media-patchstyle:./0001-media-v4l2-core-Replace-the-check-for-firmware-regis.patch media style
ERROR: ./0001-media-v4l2-core-Replace-the-check-for-firmware-regis.patch: Missing 'media:' prefix in Subject
LOL, what?
Quoted 5 lines
Please fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded.
For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/72774130/artifacts/report.htm .
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 10 lines · Andy Shevchenko
Quoted 7 lines · Patchwork Integration
Dear Andy Shevchenko:
Thanks for your patches! Unfortunately the Media CI robot detected some issues:
# Test media-patchstyle:./0001-media-v4l2-core-Replace-the-check-for-firmware-regis.patch media style
ERROR: ./0001-media-v4l2-core-Replace-the-check-for-firmware-regis.patch: Missing 'media:' prefix in SubjectLOL, what?
Hmm, the 'I²C' bit in the Subject header causes it to be UTF-8. The Subject line in patchwork (1) is now:
Subject: [PATCH v2 1/1] =?utf-8?q?media=3A_v4l2-core=3A_Replace_the_check_fo?=
=?utf-8?q?r_firmware_registered_I=C2=B2C_devices?=
so the check for the 'media:' prefix in the Subject line fails.
Interestingly, if I commit the patch (git am) to a test branch, then run 'git format-patch -n1' the Subject line now reads:
Subject: [PATCH 1/1] =?UTF-8?q?media:=20v4l2-core:=20Replace=20the=20check?=
=?UTF-8?q?=20for=20firmware=20registered=20I=C2=B2C=20devices?=
and that restored the ':'.
Ricardo, can you look at this?
I also noticed that the v1 and v2 patches ended up in my spam folder. Whether that is related to UTF-8 in the Subject is not clear (my provider marks way too many legit posts as spam).
Andy, can you post a v3 with just 'I2C' in the subject instead of 'I²C'? If nothing else, I'd like to know if that's the reason it ended up in my spam folder.
Regards,
Hans
(1) https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/
Quoted 7 lines
Quoted 6 lines
Please fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded.
For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/72774130/artifacts/report.htm .
Quoted 24 lines · Hans Verkuil
Quoted 10 lines · Andy Shevchenko
Quoted 7 lines · Patchwork Integration
Dear Andy Shevchenko:
Thanks for your patches! Unfortunately the Media CI robot detected some issues:
# Test media-patchstyle:./0001-media-v4l2-core-Replace-the-check-for-firmware-regis.patch media style
ERROR: ./0001-media-v4l2-core-Replace-the-check-for-firmware-regis.patch: Missing 'media:' prefix in SubjectLOL, what?
Hmm, the 'I²C' bit in the Subject header causes it to be UTF-8. The Subject line in patchwork (1) is now:
Subject: [PATCH v2 1/1] =?utf-8?q?media=3A_v4l2-core=3A_Replace_the_check_fo?=
=?utf-8?q?r_firmware_registered_I=C2=B2C_devices?=so the check for the 'media:' prefix in the Subject line fails.
Interestingly, if I commit the patch (git am) to a test branch, then run 'git format-patch -n1' the Subject line now reads:
Quoted 6 lines
Subject: [PATCH 1/1] =?UTF-8?q?media:=20v4l2-core:=20Replace=20the=20check?=
=?UTF-8?q?=20for=20firmware=20registered=20I=C2=B2C=20devices?=and that restored the ':'.
Ricardo, can you look at this?
STOP breaking media-ci :P [1]
Thanks for the report. We were not ready to handle that encoding. I am now leveraging "git log" and it seems to work fine.
https://gitlab.freedesktop.org/linux-media/media-ci/-/merge_requests/246
Regards
Quoted 5 lines
I also noticed that the v1 and v2 patches ended up in my spam folder. Whether that is related to UTF-8 in the Subject is not clear (my provider marks way too many legit posts as spam).
Quoted 17 lines
Andy, can you post a v3 with just 'I2C' in the subject instead of 'I²C'? If nothing else, I'd like to know if that's the reason it ended up in my spam folder.
Regards,
Hans
(1) https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/
Quoted 7 lines
Quoted 6 lines
Please fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded.
For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/72774130/artifacts/report.htm .
[1] No, seriously, thanks for taking the time to report back, it really helps!
Signature · 1 line
Ricardo Ribalda
Quoted 28 lines · Hans Verkuil
Quoted 10 lines · Andy Shevchenko
Quoted 7 lines · Patchwork Integration
Dear Andy Shevchenko:
Thanks for your patches! Unfortunately the Media CI robot detected some issues:
# Test media-patchstyle:./0001-media-v4l2-core-Replace-the-check-for-firmware-regis.patch media style
ERROR: ./0001-media-v4l2-core-Replace-the-check-for-firmware-regis.patch: Missing 'media:' prefix in SubjectLOL, what?
Hmm, the 'I²C' bit in the Subject header causes it to be UTF-8. The Subject line in patchwork (1) is now:
Subject: [PATCH v2 1/1] =?utf-8?q?media=3A_v4l2-core=3A_Replace_the_check_fo?=
=?utf-8?q?r_firmware_registered_I=C2=B2C_devices?=so the check for the 'media:' prefix in the Subject line fails.
Interestingly, if I commit the patch (git am) to a test branch, then run 'git format-patch -n1' the Subject line now reads:
Subject: [PATCH 1/1] =?UTF-8?q?media:=20v4l2-core:=20Replace=20the=20check?=
=?UTF-8?q?=20for=20firmware=20registered=20I=C2=B2C=20devices?=and that restored the ':'.
Quoted 8 lines
Ricardo, can you look at this?
I also noticed that the v1 and v2 patches ended up in my spam folder. Whether that is related to UTF-8 in the Subject is not clear (my provider marks way too many legit posts as spam).
Andy, can you post a v3 with just 'I2C' in the subject instead of 'I²C'? If nothing else, I'd like to know if that's the reason it ended up in my spam folder.
Sure. Will do ASAP.
Signature · 2 lines
With Best Regards, Andy Shevchenko