Skip to contentSkip to conversation

pmdomain: thead: fix TH1520_AON_PROTOCOL dependency

PATCH In review Arnd Bergmann 3 participants 3 messages Mar 14, 2025 – Mar 17, 2025

Subsystems (3)
RISC-V Generic PM domains RISC-V T-Head SoC support
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 pmdomain: thead: fix TH1520_AON_PROTOCOL dependency

From: Arnd Bergmann <[email protected]>

Kconfig treats the dependency as optional, but the header file only provides normal declarations and no empty API stubs:

ld: fs/btrfs/extent_io.o: in function `writepage_delalloc':
extent_io.c:(.text+0x2b42): undefined reference to `__udivdi3'
ld: drivers/pmdomain/thead/th1520-pm-domains.o: in function `th1520_pd_power_off':
th1520-pm-domains.c:(.text+0x57): undefined reference to `th1520_aon_power_update'
ld: drivers/pmdomain/thead/th1520-pm-domains.o: in function `th1520_pd_power_on':
th1520-pm-domains.c:(.text+0x8a): undefined reference to `th1520_aon_power_update'
ld: drivers/pmdomain/thead/th1520-pm-domains.o: in function `th1520_pd_probe':
th1520-pm-domains.c:(.text+0xb8): undefined reference to `th1520_aon_init'
ld: th1520-pm-domains.c:(.text+0x1c6): undefined reference to `th1520_aon_power_update'

Since the firmware code can easily be enabled for compile testing, there is no need to add stubs either, so just make it a hard dependency.

Fixes dc9a897dbb03 ("pmdomain: thead: Add power-domain driver for TH1520")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/pmdomain/thead/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pmdomain/thead/Kconfig +1 -1
index c7a1ac0c61dc..7d52f8374b07 100644
@@ -2,7 +2,7 @@
 
 config TH1520_PM_DOMAINS
 	tristate "Support TH1520 Power Domains"
-	depends on TH1520_AON_PROTOCOL || !TH1520_AON_PROTOCOL
+	depends on TH1520_AON_PROTOCOL
 	select REGMAP_MMIO
 	help
 	  This driver enables power domain management for the T-HEAD
Signature · 1 line
2.39.5
Reviewed-by on v1 1/1
#1 lore raw
Quoted 29 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Kconfig treats the dependency as optional, but the header file only provides normal declarations and no empty API stubs:

ld: fs/btrfs/extent_io.o: in function `writepage_delalloc':
extent_io.c:(.text+0x2b42): undefined reference to `__udivdi3'
ld: drivers/pmdomain/thead/th1520-pm-domains.o: in function `th1520_pd_power_off':
th1520-pm-domains.c:(.text+0x57): undefined reference to `th1520_aon_power_update'
ld: drivers/pmdomain/thead/th1520-pm-domains.o: in function `th1520_pd_power_on':
th1520-pm-domains.c:(.text+0x8a): undefined reference to `th1520_aon_power_update'
ld: drivers/pmdomain/thead/th1520-pm-domains.o: in function `th1520_pd_probe':
th1520-pm-domains.c:(.text+0xb8): undefined reference to `th1520_aon_init'
ld: th1520-pm-domains.c:(.text+0x1c6): undefined reference to `th1520_aon_power_update'

Since the firmware code can easily be enabled for compile testing, there is no need to add stubs either, so just make it a hard dependency.

Fixes dc9a897dbb03 ("pmdomain: thead: Add power-domain driver for TH1520")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/pmdomain/thead/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pmdomain/thead/Kconfig +0 -0
index c7a1ac0c61dc..7d52f8374b07 100644

drivers/pmdomain/thead/Kconfig line 8

Quoted 8 lines
drivers/pmdomain/thead/Kconfig +1 -1
@@ -2,7 +2,7 @@
 
 config TH1520_PM_DOMAINS
 	tristate "Support TH1520 Power Domains"
-	depends on TH1520_AON_PROTOCOL || !TH1520_AON_PROTOCOL
+	depends on TH1520_AON_PROTOCOL
 	select REGMAP_MMIO
 	help
 	  This driver enables power domain management for the T-HEAD

Thanks a lot !

Reviewed-by Michal Wilczynski <[email protected]>
#2 lore raw
In reply to Arnd Bergmann
Quoted 16 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Kconfig treats the dependency as optional, but the header file only provides normal declarations and no empty API stubs:

ld: fs/btrfs/extent_io.o: in function `writepage_delalloc':
extent_io.c:(.text+0x2b42): undefined reference to `__udivdi3'
ld: drivers/pmdomain/thead/th1520-pm-domains.o: in function `th1520_pd_power_off':
th1520-pm-domains.c:(.text+0x57): undefined reference to `th1520_aon_power_update'
ld: drivers/pmdomain/thead/th1520-pm-domains.o: in function `th1520_pd_power_on':
th1520-pm-domains.c:(.text+0x8a): undefined reference to `th1520_aon_power_update'
ld: drivers/pmdomain/thead/th1520-pm-domains.o: in function `th1520_pd_probe':
th1520-pm-domains.c:(.text+0xb8): undefined reference to `th1520_aon_init'
ld: th1520-pm-domains.c:(.text+0x1c6): undefined reference to `th1520_aon_power_update'

Quoted 5 lines

Since the firmware code can easily be enabled for compile testing, there is no need to add stubs either, so just make it a hard dependency.

Fixes dc9a897dbb03 ("pmdomain: thead: Add power-domain driver for TH1520")
Signed-off-by Arnd Bergmann <[email protected]>

Applied for next, thanks!

Kind regards
Uffe

Quoted 20 lines
---
 drivers/pmdomain/thead/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pmdomain/thead/Kconfig +1 -2
index c7a1ac0c61dc..7d52f8374b07 100644
@@ -2,7 +2,7 @@
 
 config TH1520_PM_DOMAINS
        tristate "Support TH1520 Power Domains"
-       depends on TH1520_AON_PROTOCOL || !TH1520_AON_PROTOCOL
+       depends on TH1520_AON_PROTOCOL
        select REGMAP_MMIO
        help
          This driver enables power domain management for the T-HEAD
--

2.39.5