spi: spi-mux: Fix coverity issue, unchecked return value
PATCH 1/1 spi: spi-mux: Fix coverity issue, unchecked return value
The return value of spi_setup() is not captured within spi_mux_select() and it is assumed to be always success.
CID: 1638374
Signed-off-by Sergio Perez Gonzalez <[email protected]>
--- drivers/spi/spi-mux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/spi/spi-mux.c +2 -2
@@ -68,9 +68,9 @@ static int spi_mux_select(struct spi_device *spi) priv->current_cs =spi_get_chipselect (spi,0 ); -spi_setup (priv->spi); + ret =spi_setup (priv->spi); -return 0 ; +return ret; }static int spi_mux_setup (struct spi_device *spi)
Signature · 1 line
2.43.0
Hi,
Quoted 16 lines · Sergio Perez Gonzalez
The return value of
spi_setup()is not captured withinspi_mux_select()and it is assumed to be always success.CID: 1638374
Signed-off-by Sergio Perez Gonzalez <[email protected]>--- drivers/spi/spi-mux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/spi/spi-mux.c +0
-0
drivers/spi/spi-mux.c static int spi_mux_select(struct spi_device *spi) · line 73
Quoted 8 lines
drivers/spi/spi-mux.c +2
-2@@ -68,9 +68,9 @@ static int spi_mux_select(struct spi_device *spi) priv->current_cs =spi_get_chipselect (spi,0 ); -spi_setup (priv->spi); + ret =spi_setup (priv->spi); -return 0 ; +return ret;
Maybe just do
return spi_setup(priv->spi);
Best regards,
Jonas