Skip to contentSkip to conversation

spi: spi-mux: Fix coverity issue, unchecked return value

PATCH Superseded Sergio Perez Gonzalez 2 participants 2 messages Mar 15, 2025 SPI

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: spi-mux: Fix coverity issue, unchecked return value

The return value of spi_setup() is not captured within spi_mux_select() and it is assumed to be always success.

CID: 1638374

---
 drivers/spi/spi-mux.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/spi/spi-mux.c +2 -2
index c02c4204442f..0f45a88bfbe7 100644
@@ -68,9 +68,9 @@ static int spi_mux_select(struct spi_device *spi)
 
 	priv->current_cs = spi_get_chipselect(spi, 0);
 
-	spi_setup(priv->spi);
+	ret = spi_setup(priv->spi);
 
-	return 0;
+	return ret;
 }
 
 static int spi_mux_setup(struct spi_device *spi)
Signature · 1 line
2.43.0
#1 lore raw

Hi,

Quoted 16 lines · Sergio Perez Gonzalez

The return value of spi_setup() is not captured within spi_mux_select() and it is assumed to be always success.

CID: 1638374

---
 drivers/spi/spi-mux.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/spi/spi-mux.c +0 -0
index c02c4204442f..0f45a88bfbe7 100644

drivers/spi/spi-mux.c static int spi_mux_select(struct spi_device *spi) · line 73

Quoted 8 lines
drivers/spi/spi-mux.c +2 -2
@@ -68,9 +68,9 @@ static int spi_mux_select(struct spi_device *spi)
 
        priv->current_cs = spi_get_chipselect(spi, 0);
 
-       spi_setup(priv->spi);
+       ret = spi_setup(priv->spi);
 
-       return 0;
+       return ret;

Maybe just do

return spi_setup(priv->spi);

Best regards,
Jonas