Skip to contentSkip to conversation

bcachefs: Remove unnecessary softdeps on crc32c and crc64

PATCH Applied Eric Biggers 2 participants 2 messages Mar 16, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bcachefs: Remove unnecessary softdeps on crc32c and crc64

From: Eric Biggers <[email protected]>

Since bcachefs does not access crc32c and crc64 through the crypto API, there is no need to use module softdeps to ensure they are loaded.

---
 fs/bcachefs/super.c | 2 --
 1 file changed, 2 deletions(-)
fs/bcachefs/super.c +0 -2
index 78a8daa80fcce..6de3a5751561e 100644
@@ -73,12 +73,10 @@
 #include <crypto/hash.h>
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Kent Overstreet <[email protected]>");
 MODULE_DESCRIPTION("bcachefs filesystem");
-MODULE_SOFTDEP("pre: crc32c");
-MODULE_SOFTDEP("pre: crc64");
 MODULE_SOFTDEP("pre: sha256");
 MODULE_SOFTDEP("pre: chacha20");
 MODULE_SOFTDEP("pre: poly1305");
 MODULE_SOFTDEP("pre: xxhash");
 

base-commit: da920b7df701770e006928053672147075587fb2

Signature · 1 line
2.49.0
#1 lore raw
Quoted 6 lines · Eric Biggers

From: Eric Biggers <[email protected]>

Since bcachefs does not access crc32c and crc64 through the crypto API, there is no need to use module softdeps to ensure they are loaded.

Applied

Quoted 26 lines
---
 fs/bcachefs/super.c | 2 --
 1 file changed, 2 deletions(-)
fs/bcachefs/super.c +0 -2
index 78a8daa80fcce..6de3a5751561e 100644
@@ -73,12 +73,10 @@
 #include <crypto/hash.h>
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Kent Overstreet <[email protected]>");
 MODULE_DESCRIPTION("bcachefs filesystem");
-MODULE_SOFTDEP("pre: crc32c");
-MODULE_SOFTDEP("pre: crc64");
 MODULE_SOFTDEP("pre: sha256");
 MODULE_SOFTDEP("pre: chacha20");
 MODULE_SOFTDEP("pre: poly1305");
 MODULE_SOFTDEP("pre: xxhash");
 

base-commit: da920b7df701770e006928053672147075587fb2

Signature · 1 line
2.49.0