Skip to contentSkip to conversation

icu: Adjust ICU_DATA_DIR path on big endian targets

PATCH New Makarios Christakis 1 participant 2 messages Mar 17, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 icu: Adjust ICU_DATA_DIR path on big endian targets

Greetings everyone,

First of all, thanks for the amazing work you're doing on the Yocto project.

Migrating our build system from dunfell to scarthgap, I came across an interesting issue causing Postgres to not be able to start on our big-endian PowerPC boards.

I identified that the root cause was the ICU package which we build with the make-icudata PACKAGECONFIG option enabled.

The icu data file icudt74b.dat is being installed onto the target's rootfs at

${datadir}/${BPN}/${@icu_install_folder(d)}/icudt${ICU_MAJOR_VER}b.dat

by the do_install append of the recipe, which regenerates it for big-endian targets.

The problem seems to be that the runtime ICU data path is being set to the dash-separated version:

$ icuinfo | grep icudata.path
    <param name="icudata.path">/usr/share/icu/74-2</param>

Which causes any application that tries to load the icu data file to fail with U_FILE_ACCESS_ERROR.

The culprit was the C++ preprocessor define -DICU_DATA_PATH which was being set for big-endian targets to the ${PV}-terminated path.

I am therefore proposing to change the PV with a call to icu_install_folder in order to set the ICU_DATA_PATH appropriately.

I am not sure if this is the right way to correct this issue, so any comments would be appreciated :)

#1 lore raw

PATCH 1/1 icu: Adjust ICU_DATA_DIR path on big endian targets

On big-endian systems the preprocessor define ICU_DATA_DIR is currently being set to a path ending with the ${PV} of the recipe.

The PV version string has changed to a '-' separator since oe-core commit cebe8439cdc656d53355506a31a3782312bf03c5 whereas the build system installs the data files into a path ending with the dot-separated version of ICU.

This causes the ICU data file to not be detected at runtime, consequently breaking any dependant applications.

We therefore substitute ${PV} with the dot-separated version string of ICU, as returned from the icu_install_folder function, on the ICU_DATA_DIR define on big-endian targets.

---
 meta/recipes-support/icu/icu_76-1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-support/icu/icu_76-1.bb +1 -1
index 08dabde3ae..f0890fc890 100644
@@ -25,7 +25,7 @@ EXTRA_OECONF:class-native = "--disable-icu-config"
 EXTRA_OECONF:class-nativesdk = "--with-cross-build=${STAGING_ICU_DIR_NATIVE} --disable-icu-config"
 
 EXTRA_OECONF:append:class-target = "${@oe.utils.conditional('SITEINFO_ENDIANNESS', 'be', ' --with-data-packaging=archive', '', d)}"
-TARGET_CXXFLAGS:append = "${@oe.utils.conditional('SITEINFO_ENDIANNESS', 'be', ' -DICU_DATA_DIR=\\""${datadir}/${BPN}/${PV}\\""', '', d)}"
+TARGET_CXXFLAGS:append = "${@oe.utils.conditional('SITEINFO_ENDIANNESS', 'be', ' -DICU_DATA_DIR=\\""${datadir}/${BPN}/${@icu_install_folder(d)}\\""', '', d)}"
 
 ASNEEDED = ""