Skip to contentSkip to conversation

usb: Remove orphaned Marvell UDC drivers

PATCH Superseded Rob Herring (Arm) 2 participants 2 messages Mar 17, 2025 USB

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: Remove orphaned Marvell UDC drivers

These drivers have no way to probe as there are no match tables nor devices created with a matching name in the kernel tree.

UDC was only ever supported by board files which were removed in 2022.

For U3D, which was added in 2012, the PXA2128 aka MMP3 support was never upstreamed with board files and only revived in 2019 with DT support. No U3D DT support has been added since then.

Cc Arnd Bergmann <[email protected]>
Cc Lubomir Rintel <[email protected]>
---
 drivers/usb/gadget/udc/Kconfig       |   15 -
 drivers/usb/gadget/udc/Makefile      |    3 -
 drivers/usb/gadget/udc/mv_u3d.h      |  317 ----
 drivers/usb/gadget/udc/mv_u3d_core.c | 2062 ----------------------
 drivers/usb/gadget/udc/mv_udc.h      |  309 ----
 drivers/usb/gadget/udc/mv_udc_core.c | 2426 --------------------------
 drivers/usb/phy/Kconfig              |   12 -
 drivers/usb/phy/Makefile             |    1 -
 drivers/usb/phy/phy-mv-usb.c         |  881 ----------
 9 files changed, 6026 deletions(-)
 delete mode 100644 drivers/usb/gadget/udc/mv_u3d.h
 delete mode 100644 drivers/usb/gadget/udc/mv_u3d_core.c
 delete mode 100644 drivers/usb/gadget/udc/mv_udc.h
 delete mode 100644 drivers/usb/gadget/udc/mv_udc_core.c
 delete mode 100644 drivers/usb/phy/phy-mv-usb.c
drivers/usb/gadget/udc/Kconfig +0 -15
index aae1787320d4..2171c55ebcdf 100644
@@ -228,21 +228,6 @@ config USB_PXA27X
 	   dynamically linked module called "pxa27x_udc" and force all
 	   gadget drivers to also be dynamically linked.
 
-config USB_MV_UDC
-	tristate "Marvell USB2.0 Device Controller"
-	depends on HAS_DMA
-	help
-	  Marvell Socs (including PXA and MMP series) include a high speed
-	  USB2.0 OTG controller, which can be configured as high speed or
-	  full speed USB peripheral.
-
-config USB_MV_U3D
-	depends on HAS_DMA
-	tristate "MARVELL PXA2128 USB 3.0 controller"
-	help
-	  MARVELL PXA2128 Processor series include a super speed USB3.0 device
-	  controller, which support super speed USB peripheral.
-
 config USB_SNP_CORE
 	depends on (USB_AMD5536UDC || USB_SNP_UDC_PLAT)
 	depends on HAS_DMA
drivers/usb/gadget/udc/Makefile +0 -3
index b52f93e9c61d..76a8d93b3b96 100644
@@ -31,10 +31,7 @@ obj-$(CONFIG_USB_RENESAS_USBF)	+= renesas_usbf.o
 obj-$(CONFIG_USB_FSL_QE)	+= fsl_qe_udc.o
 obj-$(CONFIG_USB_LPC32XX)	+= lpc32xx_udc.o
 obj-$(CONFIG_USB_EG20T)		+= pch_udc.o
-obj-$(CONFIG_USB_MV_UDC)	+= mv_udc.o
-mv_udc-y			:= mv_udc_core.o
 obj-$(CONFIG_USB_FUSB300)	+= fusb300_udc.o
-obj-$(CONFIG_USB_MV_U3D)	+= mv_u3d_core.o
 obj-$(CONFIG_USB_GR_UDC)	+= gr_udc.o
 obj-$(CONFIG_USB_GADGET_XILINX)	+= udc-xilinx.o
 obj-$(CONFIG_USB_SNP_UDC_PLAT) += snps_udc_plat.o
drivers/usb/gadget/udc/mv_u3d.h deleted +0 -317

317 lines not on this page · raw message

drivers/usb/gadget/udc/mv_u3d_core.c deleted +0 -2062

2,062 lines not on this page · raw message

drivers/usb/gadget/udc/mv_udc.h deleted +0 -309

309 lines not on this page · raw message

drivers/usb/gadget/udc/mv_udc_core.c deleted +0 -2426

281 lines not on this page · raw message

drivers/usb/phy/Kconfig +0 -12
index 5f629d7cad64..b7acf3966cd7 100644

Lines of this file are not shown. View the raw message.

drivers/usb/phy/Makefile +0 -1
index e5d619b4d8f6..ceae46c5341d 100644

Lines of this file are not shown. View the raw message.

drivers/usb/phy/phy-mv-usb.c deleted +0 -881

881 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.47.2

Part of the diff is not shown here. View the raw message.

Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Rob Herring (Arm)

These drivers have no way to probe as there are no match tables nor devices created with a matching name in the kernel tree.

UDC was only ever supported by board files which were removed in 2022.

Quoted 7 lines

For U3D, which was added in 2012, the PXA2128 aka MMP3 support was never upstreamed with board files and only revived in 2019 with DT support. No U3D DT support has been added since then.

Cc Arnd Bergmann <[email protected]>
Cc Lubomir Rintel <[email protected]>

Looks ok to me,

I see two additional udc drivers without users:

drivers/usb/gadget/udc/fusb300_udc.c (could not find any users) drivers/usb/gadget/udc/net2272.c (formerly used on blackfin)