scsi: mptspi: Fix reference count leak in mptspi_write_spi_device_pg1
Subsystems (2)
PATCH 1/1 scsi: mptspi: Fix reference count leak in mptspi_write_spi_device_pg1
scsi_device_lookup_by_target() returns a reference that needs to be released with scsi_device_put(). Add missing scsi_device_put() before continue.
Fixes 19fff154e7ee ("[SCSI] mptfusion: Adding inline data padding support for TAPE drive.")
Signed-off-by Miaoqian Lin <[email protected]>
--- drivers/message/fusion/mptspi.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/message/fusion/mptspi.c +6 -1
@@ -908,14 +908,19 @@ static int mptspi_write_spi_device_pg1(struct scsi_target *starget,/* Turn on inline data padding for TAPE when running U320 */ for (i =0 ; i <16 ; i++) { sdev =scsi_device_lookup_by_target (starget, i); -if (sdev && sdev->type ==TYPE_TAPE ) { +if (!sdev) +continue ; + +if (sdev->type ==TYPE_TAPE ) {sdev_printk (KERN_DEBUG , sdev, MYIOC_s_FMT"IDP:ON\n" , ioc->name); nego_parms |=MPI_SCSIDEVPAGE1_RP_IDP ; pg1->RequestedParameters =cpu_to_le32 (nego_parms); +scsi_device_put (sdev);break ; } +scsi_device_put (sdev); } }
Signature · 1 line
2.39.5 (Apple Git-154)