staging: gpib: warning: variable 'nec_priv' set but not used warning
PATCH 1/1 staging: gpib: warning: variable 'nec_priv' set but not used warning
From: sunliming <[email protected]>
Fix below kernel warning:drivers/staging/gpib/eastwood/fluke_gpib.c:196:23: warning: variable 'nec_priv' set but not used [-Wunused-but-set-variable]
--- drivers/staging/gpib/eastwood/fluke_gpib.c | 2 -- 1 file changed, 2 deletions(-)
drivers/staging/gpib/eastwood/fluke_gpib.c +0 -2
@@ -194,10 +194,8 @@ static int fluke_line_status(const gpib_board_t *board)int status = ValidALL;int bsr_bits;struct fluke_priv *e_priv; -struct nec7210_priv *nec_priv; e_priv = board->private_data; - nec_priv = &e_priv->nec7210_priv; bsr_bits =fluke_paged_read_byte (e_priv,BUS_STATUS ,BUS_STATUS_PAGE );
Signature · 1 line
2.25.1
Greg KH
maintainerQuoted 7 lines · On Fri, Mar 21, 2025 at 09:06:49AM +0800, [email protected] wrote:
From: sunliming <[email protected]>
Fix below kernel warning:
drivers/staging/gpib/eastwood/fluke_gpib.c:196:23: warning: variable 'nec_priv' set but not used [-Wunused-but-set-variable]Reported-by kernel test robot <[email protected]>
Please link to where this was reported. The report from the robot will have the needed information in it on how to do this.
Quoted 1 line
Signed-off-by sunliming <[email protected]>
As per our documentation, please use your name, not your email alias, on the signed-off-by line.
thanks,
gregk -h
Quoted 10 lines · Greg KH
Quoted 7 lines · On Fri, Mar 21, 2025 at 09:06:49AM +0800, [email protected] wrote:
From: sunliming <[email protected]>
Fix below kernel warning:
drivers/staging/gpib/eastwood/fluke_gpib.c:196:23: warning: variable 'nec_priv' set but not used [-Wunused-but-set-variable]Reported-by kernel test robot <[email protected]>Please link to where this was reported. The report from the robot will have the needed information in it on how to do this.
Get it, I will resend the patch to fix this.
Thanks.
Quoted 3 lines
Quoted 1 line
Signed-off-by sunliming <[email protected]>As per our documentation, please use your name, not your email alias, on the signed-off-by line.
It's not my email alias,my name is sunliming too.
Thanks.
Quoted 3 lines
thanks,
gregk -h
Quoted 15 lines · Sunliming
Quoted 10 lines · Greg KH
Quoted 7 lines · On Fri, Mar 21, 2025 at 09:06:49AM +0800, [email protected] wrote:
From: sunliming <[email protected]>
Fix below kernel warning:
drivers/staging/gpib/eastwood/fluke_gpib.c:196:23: warning: variable 'nec_priv' set but not used [-Wunused-but-set-variable]Reported-by kernel test robot <[email protected]>Please link to where this was reported. The report from the robot will have the needed information in it on how to do this.
Get it, I will resend the patch to fix this.
Quoted 7 lines
Thanks.
Quoted 3 lines
Quoted 1 line
Signed-off-by sunliming <[email protected]>As per our documentation, please use your name, not your email alias, on the signed-off-by line.
It's not my email alias,my name is sunliming too.
Why is it capitalized on your From header on your email but not in your Signed-off-by?
regards,
dan carpenter
Quoted 14 lines · Dan Carpenter
Quoted 13 lines · Sunliming
Quoted 10 lines · Greg KH
Quoted 7 lines · On Fri, Mar 21, 2025 at 09:06:49AM +0800, [email protected] wrote:
From: sunliming <[email protected]>
Fix below kernel warning:
drivers/staging/gpib/eastwood/fluke_gpib.c:196:23: warning: variable 'nec_priv' set but not used [-Wunused-but-set-variable]Reported-by kernel test robot <[email protected]>Please link to where this was reported. The report from the robot will have the needed information in it on how to do this.
Get it, I will resend the patch to fix this.
Quoted 8 lines
Quoted 6 lines
Thanks.
Quoted 3 lines
Quoted 1 line
Signed-off-by sunliming <[email protected]>As per our documentation, please use your name, not your email alias, on the signed-off-by line.
It's not my email alias,my name is sunliming too.
Why is it capitalized on your From header on your email but not in your Signed-off-by?
I didn't notice that my email and Gitconfig have different names set. Thank you
for letting me know, I will fix it.
Quoted 4 lines
regards,
dan carpenter