Skip to contentSkip to conversation

perf build: filter all combinations of -flto for libperl

PATCH Applied Holger Hoffstätte 2 participants 2 messages Mar 21, 2025 – Mar 24, 2025 perf events

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 perf build: filter all combinations of -flto for libperl

When enabling the libperl feature the build uses perl's build flags (ccopts) but filters out various flags, e.g. for LTO.
While this is conceptually correct, it is insufficient in practice, since only "-flto=auto" is filtered out. When perl itself is built with "-flto" this can cause parts of perf being built with LTO and others without, giving exciting build errors like e.g.:

../tools/perf/pmu-events/pmu-events.c:72851:(.text+0xb79): undefined reference to `strcmp_cpuid_str' collect2: error: ld returned 1 exit status

Fix this by filtering all matching flag values of -flto{=n,auto,..}.

---
 tools/perf/Makefile.config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/Makefile.config +1 -1
index a148ca9ef..4f5a40ab8 100644
@@ -820,7 +820,7 @@ else
   PERL_EMBED_LIBADD = $(call grep-libs,$(PERL_EMBED_LDOPTS))
   PERL_EMBED_CCOPTS = $(shell perl -MExtUtils::Embed -e ccopts 2>/dev/null)
   PERL_EMBED_CCOPTS := $(filter-out -specs=%,$(PERL_EMBED_CCOPTS))
-  PERL_EMBED_CCOPTS := $(filter-out -flto=auto -ffat-lto-objects, $(PERL_EMBED_CCOPTS))
+  PERL_EMBED_CCOPTS := $(filter-out -flto% -ffat-lto-objects, $(PERL_EMBED_CCOPTS))
   PERL_EMBED_LDOPTS := $(filter-out -specs=%,$(PERL_EMBED_LDOPTS))
   FLAGS_PERL_EMBED=$(PERL_EMBED_CCOPTS) $(PERL_EMBED_LDOPTS)
 
Signature · 1 line
2.49.0
maintainer Applied
#1 lore raw
Quoted 8 lines · Holger Hoffstätte

When enabling the libperl feature the build uses perl's build flags (ccopts) but filters out various flags, e.g. for LTO.
While this is conceptually correct, it is insufficient in practice, since only "-flto=auto" is filtered out. When perl itself is built with "-flto" this can cause parts of perf being built with LTO and others without, giving exciting build errors like e.g.:

[...]

Applied to perf-tools-next, thanks!

Best regards,
Namhyung