Skip to contentSkip to conversation

ASoC: SDCA: Correct handling of selected mode DisCo property

PATCH In review Charles Keepax 2 participants 2 messages Mar 21, 2025

Subsystems (3)
lore
Share & tools
lore

Charles Keepax

author maintainer
#0 lore raw

PATCH 1/1 ASoC: SDCA: Correct handling of selected mode DisCo property

mipi-sdca-ge-selectedmode-controls-affected is actually required by the specification so the code should return an error if it is missing.

Fixes d1cd13f80dc6 ("ASoC: SDCA: Add support for GE Entity properties")
---
 sound/soc/sdca/sdca_functions.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/sdca/sdca_functions.c +1 -1
index c8efdc5301b53..493f390f087ad 100644
@@ -1159,7 +1159,7 @@ static int find_sdca_entity_ge(struct device *dev,
 
 	num_affected = fwnode_property_count_u8(entity_node,
 						"mipi-sdca-ge-selectedmode-controls-affected");
-	if (!num_affected || num_affected == -EINVAL) {
+	if (!num_affected) {
 		return 0;
 	} else if (num_affected < 0) {
 		dev_err(dev, "%s: failed to read affected controls: %d\n",
Signature · 1 line
2.39.5
maintainer
#1 lore raw
Quoted 4 lines · Charles Keepax

mipi-sdca-ge-selectedmode-controls-affected is actually required by the specification so the code should return an error if it is missing.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: SDCA: Correct handling of selected mode DisCo property

      commit: 9ef52d529bb75071e03cf85078f724d69c4abe89

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark