Skip to contentSkip to conversation

media: cec: tda9950: Add missing I2C dependency

PATCH In review Yue Haibing 1 participant 2 messages Mar 22, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 media: cec: tda9950: Add missing I2C dependency

If CONFIG_I2C is not set, build fails:

drivers/media/cec/i2c/tda9950.c: In function ‘tda9950_probe’:
drivers/media/cec/i2c/tda9950.c:391:14: error: implicit declaration of function ‘i2c_check_functionality’ [-Werror=implicit-function-declaration]

	if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
      |              ^~~~~~~~~~~~~~~~~~~~~~~
  CC      crypto/aes_generic.o
drivers/media/cec/i2c/tda9950.c: At top level:
drivers/media/cec/i2c/tda9950.c:503:1: warning: data definition has no type or storage class
  503 | module_i2c_driver(tda9950_driver);
      | ^~~~~~~~~~~~~~~~~

drivers/media/cec/i2c/tda9950.c:503:1: error: type defaults to ‘int’ in declaration of ‘module_i2c_driver’ [-Werror=implicit-int] drivers/media/cec/i2c/tda9950.c:503:1: warning: parameter names (without types) in function declaration

Add missing I2C dependency to fix this.

Fixes caa6f4a75e9f ("media: cec: move driver for TDA9950 from drm/i2c")

---
v2: Fix patch title, also cc dri-devel list

---
 drivers/media/cec/i2c/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/media/cec/i2c/Kconfig +1 -0
index b9d21643eef1..c31abc26f602 100644
@@ -16,6 +16,7 @@ config CEC_CH7322
 
 config CEC_NXP_TDA9950
 	tristate "NXP Semiconductors TDA9950/TDA998X HDMI CEC"
+	depends on I2C
 	select CEC_NOTIFIER
 	select CEC_CORE
 	default DRM_I2C_NXP_TDA998X
Signature · 1 line
2.34.1
#1 lore raw
Quoted 11 lines · Yue Haibing

If CONFIG_I2C is not set, build fails:

drivers/media/cec/i2c/tda9950.c: In function ‘tda9950_probe’:
drivers/media/cec/i2c/tda9950.c:391:14: error: implicit declaration of function ‘i2c_check_functionality’ [-Werror=implicit-function-declaration]

	if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
      |              ^~~~~~~~~~~~~~~~~~~~~~~
  CC      crypto/aes_generic.o
drivers/media/cec/i2c/tda9950.c: At top level:
drivers/media/cec/i2c/tda9950.c:503:1: warning: data definition has no type or storage class
  503 | module_i2c_driver(tda9950_driver);
      | ^~~~~~~~~~~~~~~~~
Quoted 6 lines

drivers/media/cec/i2c/tda9950.c:503:1: error: type defaults to ‘int’ in declaration of ‘module_i2c_driver’ [-Werror=implicit-int] drivers/media/cec/i2c/tda9950.c:503:1: warning: parameter names (without types) in function declaration

Add missing I2C dependency to fix this.

Fixes caa6f4a75e9f ("media: cec: move driver for TDA9950 from drm/i2c")

Just FYI,
commit caa6f4a75e9f has only applied to drm-misc-next, so also cc drm drivers maintainer

Quoted 19 lines

---
v2: Fix patch title, also cc dri-devel list

---
 drivers/media/cec/i2c/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/media/cec/i2c/Kconfig +1 -0
index b9d21643eef1..c31abc26f602 100644
@@ -16,6 +16,7 @@ config CEC_CH7322
 
 config CEC_NXP_TDA9950
 	tristate "NXP Semiconductors TDA9950/TDA998X HDMI CEC"
+	depends on I2C
 	select CEC_NOTIFIER
 	select CEC_CORE
 	default DRM_I2C_NXP_TDA998X