Skip to contentSkip to conversation

tests/intel/xe_fault_injection: Do not treat probe success as error

PATCH Superseded Marcin Bernatowicz 1 participant 1 message Mar 27, 2025

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/intel/xe_fault_injection: Do not treat probe success as error

Certain functions may not be called at all, such as xe_wopcm_init, xe_guc_log_init, and xe_guc_ads_init during VF probe.
In such cases, a successful probe should not be treated as an error.

Cc Francois Dugast <[email protected]>
Cc Lucas De Marchi <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Satyanarayana K V P <[email protected]>
---
 tests/intel/xe_fault_injection.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
tests/intel/xe_fault_injection.c +7 -1
index 24c114ba7..f559d7c98 100644
@@ -185,6 +185,8 @@ static void set_retval(const char function_name[], long long retval)
 static void
 inject_fault_probe(int fd, char pci_slot[], const char function_name[])
 {
+	int err = 0;
+
 	igt_info("Injecting error \"%s\" (%d) in function \"%s\"\n",
 		 strerror(-INJECT_ERRNO), INJECT_ERRNO, function_name);
 
@@ -192,8 +194,12 @@ inject_fault_probe(int fd, char pci_slot[], const char function_name[])
 	injection_list_do(INJECTION_LIST_ADD, function_name);
 	set_retval(function_name, INJECT_ERRNO);
 	xe_sysfs_driver_do(fd, pci_slot, XE_SYSFS_DRIVER_TRY_BIND);
-	igt_assert_eq(-errno, INJECT_ERRNO);
+	err = -errno;
 	injection_list_do(INJECTION_LIST_REMOVE, function_name);
+	if (err)
+		igt_assert_eq(err, INJECT_ERRNO);
+	else
+		xe_sysfs_driver_do(fd, pci_slot, XE_SYSFS_DRIVER_UNBIND);
 }
 
 /**
Signature · 1 line
2.31.1