Skip to contentSkip to conversation

ASoC: amd: acp: Remove (explicitly) unused header

PATCH Superseded Andy Shevchenko 2 participants 6 messages Mar 31, 2025 – Aug 26, 2025

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: amd: acp: Remove (explicitly) unused header

The fwnode.h is not supposed to be used by the drivers as it has the definitions for the core parts for different device property provider implementations. Drop it.

Note, that fwnode API for drivers is provided in property.h which is included here.

---
 sound/soc/amd/acp/amd-sdw-acpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/amd/acp/amd-sdw-acpi.c +1 -1
index 238b584887ee..0160b0df26a0 100644
@@ -17,8 +17,8 @@
 #include <linux/device.h>
 #include <linux/errno.h>
 #include <linux/export.h>
-#include <linux/fwnode.h>
 #include <linux/module.h>
+#include <linux/property.h>
 #include <linux/soundwire/sdw_amd.h>
 #include <linux/string.h>
 
Signature · 1 line
2.47.2
#1 lore raw
Quoted 6 lines · Andy Shevchenko

The fwnode.h is not supposed to be used by the drivers as it has the definitions for the core parts for different device property provider implementations. Drop it.

Note, that fwnode API for drivers is provided in property.h which is included here.

Any news here?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#2 lore raw
Quoted 9 lines · Andy Shevchenko
Quoted 6 lines · Andy Shevchenko

The fwnode.h is not supposed to be used by the drivers as it has the definitions for the core parts for different device property provider implementations. Drop it.

Note, that fwnode API for drivers is provided in property.h which is included here.

Any news here?

Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled.

#3 lore raw
Quoted 17 lines · Mark Brown
Quoted 9 lines · Andy Shevchenko
Quoted 6 lines · Andy Shevchenko

The fwnode.h is not supposed to be used by the drivers as it has the definitions for the core parts for different device property provider implementations. Drop it.

Note, that fwnode API for drivers is provided in property.h which is included here.

Any news here?

Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed.

Quoted 6 lines

Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled.

I truly believe the 5 month is reasonable time for review, no?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#4 lore raw
Quoted 9 lines · Andy Shevchenko
Quoted 5 lines · Mark Brown

all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled.

I truly believe the 5 month is reasonable time for review, no?

You're missing the part about how you should resend instead.

#5 lore raw
Quoted 9 lines · Mark Brown
Quoted 7 lines · Andy Shevchenko
Quoted 5 lines · Mark Brown

all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled.

Quoted 3 lines
Quoted 1 line

I truly believe the 5 month is reasonable time for review, no?

You're missing the part about how you should resend instead.

Noted, thanks!

Signature · 2 lines
With Best Regards,
Andy Shevchenko