Skip to contentSkip to conversation

ACPI: EC: Set ec_no_wakeup for Lenovo Go S

PATCH In review Mario Limonciello 2 participants 4 messages Apr 1, 2025 – Apr 7, 2025 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ACPI: EC: Set ec_no_wakeup for Lenovo Go S

From: Mario Limonciello <[email protected]>

When AC adapter is unplugged or plugged in EC wakes from HW sleep but APU doesn't enter back into HW sleep.

The reason this happens is that when APU exits HW sleep the power rails the EC controls will power up the TCON. The TCON has a GPIO that will be toggled during this time. The GPIO is not marked as a wakeup source, however GPIO controller still has an unserviced interrupt. Unserviced interrupts will block entering HW sleep again. Clearing the GPIO doesn't help as the TCON continues to assert it until it's been initialized by i2c-hid.

Fixing this would require TCON F/W changes and it's already broken in the wild on production hardware.

To avoid triggering this issue add a quirk to avoid letting EC wake up system at all. The power button still works properly on this system.

---
v2:
Add more tags
Fix a typo and grammar in commit

---
 drivers/acpi/ec.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
drivers/acpi/ec.c +28 -0
index 8db09d81918fb..3c5f34892734e 100644
@@ -2301,6 +2301,34 @@ static const struct dmi_system_id acpi_ec_no_wakeup[] = {
 			DMI_MATCH(DMI_PRODUCT_FAMILY, "103C_5336AN HP ZHAN 66 Pro"),
 		},
 	},
+	/*
+	 * Lenovo Legion Go S; touchscreen blocks HW sleep when woken up from EC
+	 * https://gitlab.freedesktop.org/drm/amd/-/issues/3929
+	 */
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "83L3"),
+		}
+	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "83N6"),
+		}
+	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "83Q2"),
+		}
+	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "83Q3"),
+		}
+	},
 	{ },
 };
 
Signature · 1 line
2.43.0
#1 lore raw
Quoted 8 lines · Mario Limonciello

From: Mario Limonciello <[email protected]>

When AC adapter is unplugged or plugged in EC wakes from HW sleep but APU doesn't enter back into HW sleep.

The reason this happens is that when APU exits HW sleep the power rails the EC controls will power up the TCON.

I think that the above should be

"The reason this happens is that, when the APU exits HW sleep, the power rails controlled by the EC will power up the TCON."

If I'm not mistaken, please let me know and I'll make this change when applying the patch.

Quoted 70 lines

The TCON has a GPIO that will
be toggled during this time. The GPIO is not marked as a wakeup source, however GPIO controller still has an unserviced interrupt. Unserviced interrupts will block entering HW sleep again. Clearing the GPIO doesn't help as the TCON continues to assert it until it's been initialized by i2c-hid.

Fixing this would require TCON F/W changes and it's already broken in the wild on production hardware.

To avoid triggering this issue add a quirk to avoid letting EC wake up system at all. The power button still works properly on this system.

---
v2:
Add more tags
Fix a typo and grammar in commit

---
 drivers/acpi/ec.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
drivers/acpi/ec.c +28 -1
index 8db09d81918fb..3c5f34892734e 100644
@@ -2301,6 +2301,34 @@ static const struct dmi_system_id acpi_ec_no_wakeup[] = {
                        DMI_MATCH(DMI_PRODUCT_FAMILY, "103C_5336AN HP ZHAN 66 Pro"),
                },
        },
+       /*
+        * Lenovo Legion Go S; touchscreen blocks HW sleep when woken up from EC
+        * https://gitlab.freedesktop.org/drm/amd/-/issues/3929
+        */
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "83L3"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "83N6"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "83Q2"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "83Q3"),
+               }
+       },
        { },
 };
 
--

2.43.0

#2 lore raw
Quoted 10 lines · Rafael J. Wysocki
Quoted 8 lines · Mario Limonciello

From: Mario Limonciello <[email protected]>

When AC adapter is unplugged or plugged in EC wakes from HW sleep but APU doesn't enter back into HW sleep.

The reason this happens is that when APU exits HW sleep the power rails the EC controls will power up the TCON.

Quoted 7 lines

I think that the above should be

"The reason this happens is that, when the APU exits HW sleep, the power rails controlled by the EC will power up the TCON."

If I'm not mistaken, please let me know and I'll make this change when applying the patch.

Sounds good, thanks!

Quoted 71 lines
Quoted 71 lines

The TCON has a GPIO that will
be toggled during this time. The GPIO is not marked as a wakeup source, however GPIO controller still has an unserviced interrupt. Unserviced interrupts will block entering HW sleep again. Clearing the GPIO doesn't help as the TCON continues to assert it until it's been initialized by i2c-hid.

Fixing this would require TCON F/W changes and it's already broken in the wild on production hardware.

To avoid triggering this issue add a quirk to avoid letting EC wake up system at all. The power button still works properly on this system.

---
v2:
Add more tags
Fix a typo and grammar in commit

---
  drivers/acpi/ec.c | 28 ++++++++++++++++++++++++++++
  1 file changed, 28 insertions(+)
drivers/acpi/ec.c +28 -1
index 8db09d81918fb..3c5f34892734e 100644
@@ -2301,6 +2301,34 @@ static const struct dmi_system_id acpi_ec_no_wakeup[] = {
                         DMI_MATCH(DMI_PRODUCT_FAMILY, "103C_5336AN HP ZHAN 66 Pro"),
                 },
         },
+       /*
+        * Lenovo Legion Go S; touchscreen blocks HW sleep when woken up from EC
+        * https://gitlab.freedesktop.org/drm/amd/-/issues/3929
+        */
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "83L3"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "83N6"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "83Q2"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "83Q3"),
+               }
+       },
         { },
  };
 
--

2.43.0

#3 lore raw
Quoted 14 lines · Mario Limonciello
Quoted 12 lines · Rafael J. Wysocki
Quoted 8 lines · Mario Limonciello

From: Mario Limonciello <[email protected]>

When AC adapter is unplugged or plugged in EC wakes from HW sleep but APU doesn't enter back into HW sleep.

The reason this happens is that when APU exits HW sleep the power rails the EC controls will power up the TCON.

I think that the above should be

Quoted 7 lines
Quoted 5 lines

"The reason this happens is that, when the APU exits HW sleep, the power rails controlled by the EC will power up the TCON."

If I'm not mistaken, please let me know and I'll make this change when applying the patch.

Sounds good, thanks!

Now applied as 6.15-rc material with the above modification and some other minor edits in the changelog.

Thanks!

Quoted 71 lines
Quoted 70 lines
Quoted 70 lines

The TCON has a GPIO that will
be toggled during this time. The GPIO is not marked as a wakeup source, however GPIO controller still has an unserviced interrupt. Unserviced interrupts will block entering HW sleep again. Clearing the GPIO doesn't help as the TCON continues to assert it until it's been initialized by i2c-hid.

Fixing this would require TCON F/W changes and it's already broken in the wild on production hardware.

To avoid triggering this issue add a quirk to avoid letting EC wake up system at all. The power button still works properly on this system.

---
v2:
Add more tags
Fix a typo and grammar in commit

---
  drivers/acpi/ec.c | 28 ++++++++++++++++++++++++++++
  1 file changed, 28 insertions(+)
drivers/acpi/ec.c +28 -1
index 8db09d81918fb..3c5f34892734e 100644
@@ -2301,6 +2301,34 @@ static const struct dmi_system_id acpi_ec_no_wakeup[] = {
                         DMI_MATCH(DMI_PRODUCT_FAMILY, "103C_5336AN HP ZHAN 66 Pro"),
                 },
         },
+       /*
+        * Lenovo Legion Go S; touchscreen blocks HW sleep when woken up from EC
+        * https://gitlab.freedesktop.org/drm/amd/-/issues/3929
+        */
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "83L3"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "83N6"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "83Q2"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "83Q3"),
+               }
+       },
         { },
  };
 
--

2.43.0