nfs: add missing selections of CONFIG_CRC32
Subsystems (3)
PATCH 1/1 nfs: add missing selections of CONFIG_CRC32
From: Eric Biggers <[email protected]>
nfs.ko, nfsd.ko, and lockd.ko all use crc32_le(), which is available only when CONFIG_CRC32 is enabled. But the only NFS kconfig option that selected CONFIG_CRC32 was CONFIG_NFS_DEBUG, which is client-specific and did not actually guard the use of crc32_le() even on the client.
The code worked around this bug by only actually calling crc32_le() when CONFIG_CRC32 is built-in, instead hard-coding '0' in other cases. This avoided randconfig build errors, and in real kernels the fallback code was unlikely to be reached since CONFIG_CRC32 is 'default y'. But, this really needs to just be done properly, especially now that I'm planning to update CONFIG_CRC32 to not be 'default y'.
Therefore, make CONFIG_NFS_FS, CONFIG_NFSD, and CONFIG_LOCKD select CONFIG_CRC32. Then remove the fallback code that becomes unnecessary, as well as the selection of CONFIG_CRC32 from CONFIG_NFS_DEBUG.
--- fs/Kconfig | 1 + fs/nfs/Kconfig | 2 +- fs/nfs/internal.h | 7 ------- fs/nfs/nfs4session.h | 4 ---- fs/nfsd/Kconfig | 1 + fs/nfsd/nfsfh.h | 7 ------- include/linux/nfs.h | 7 ------- 7 files changed, 3 insertions(+), 26 deletions(-)
fs/Kconfig +1 -0
@@ -366,10 +366,11 @@ config GRACE_PERIOD tristate config LOCKD tristate depends on FILE_LOCKING + select CRC32 select GRACE_PERIOD config LOCKD_V4 bool depends on NFSD || NFS_V3
fs/nfs/Kconfig +1 -1
@@ -1,9 +1,10 @@ # SPDX-License-Identifier: GPL-2.0-only config NFS_FS tristate "NFS client support" depends on INET && FILE_LOCKING && MULTIUSER + select CRC32 select LOCKD select SUNRPC select NFS_COMMON select NFS_ACL_SUPPORT if NFS_V3_ACL help
@@ -194,11 +195,10 @@ config NFS_USE_KERNEL_DNS default y config NFS_DEBUG bool depends on NFS_FS && SUNRPC_DEBUG - select CRC32 default y config NFS_DISABLE_UDP_SUPPORT bool "NFS: Disable NFS UDP protocol support" depends on NFS_FS
fs/nfs/internal.h +0 -7
@@ -897,22 +897,15 @@ static inlineu64 nfs_timespec_to_change_attr (const struct timespec64 *ts) {return ((u64 )ts->tv_sec <<30 ) + ts->tv_nsec; } -#ifdef CONFIG_CRC32 static inline u32 nfs_stateid_hash (const nfs4_stateid *stateid) {return ~crc32_le (0xFFFFFFFF , &stateid->other[0 ],NFS4_STATEID_OTHER_SIZE ); } -#else -static inline u32 nfs_stateid_hash (nfs4_stateid *stateid) -{ -return 0 ; -} -#endif static inline bool nfs_error_is_fatal (int err) {switch (err) {case -ERESTARTSYS :
fs/nfs/nfs4session.h +0 -4
@@ -146,20 +146,16 @@ static inline void nfs4_copy_sessionid(struct nfs4_sessionid *dst, const struct nfs4_sessionid *src) {memcpy (dst->data, src->data,NFS4_MAX_SESSIONID_LEN ); } -#ifdef CONFIG_CRC32 /* * nfs_session_id_hash - calculate the crc32 hash for the session id * @session - pointer to session */ #define nfs_session_id_hash (sess_id) \ (~crc32_le(0xFFFFFFFF, &(sess_id)->data[0], sizeof((sess_id)->data))) -#else -#define nfs_session_id_hash (session) (0) -#endif #else /* defined(CONFIG_NFS_V4_1) */ static inline int nfs4_init_session (struct nfs_client *clp) {return 0 ;
fs/nfsd/Kconfig +1 -0
@@ -2,10 +2,11 @@ config NFSD tristate "NFS server support" depends on INET depends on FILE_LOCKING depends on FSNOTIFY + select CRC32 select LOCKD select SUNRPC select EXPORTFS select NFS_COMMON select NFS_ACL_SUPPORT if NFSD_V2_ACL
fs/nfsd/nfsfh.h +0 -7
@@ -265,11 +265,10 @@ static inline bool fh_fsid_match(const struct knfsd_fh *fh1,if (memcmp (fh1->fh_fsid, fh2->fh_fsid,key_len (fh1->fh_fsid_type)) !=0 )return false;return true; } -#ifdef CONFIG_CRC32 /** * knfsd_fh_hash - calculate the crc32 hash for the filehandle * @fh - pointer to filehandle * * returns a crc32 hash for the filehandle that is compatible with
@@ -277,16 +276,10 @@ static inline bool fh_fsid_match(const struct knfsd_fh *fh1,*/ static inline u32 knfsd_fh_hash (const struct knfsd_fh *fh) {return ~crc32_le (0xFFFFFFFF , fh->fh_raw, fh->fh_size); } -#else -static inline u32 knfsd_fh_hash (const struct knfsd_fh *fh) -{ -return 0 ; -} -#endif /** * fh_clear_pre_post_attrs - Reset pre/post attributes * @fhp: file handle to be updated *
include/linux/nfs.h +0 -7
@@ -53,11 +53,10 @@ enum nfs3_stable_how {/* used by direct.c to mark verf as invalid */ NFS_INVALID_STABLE_HOW = -1 }; -#ifdef CONFIG_CRC32 /** * nfs_fhandle_hash - calculate the crc32 hash for the filehandle * @fh - pointer to filehandle * * returns a crc32 hash for the filehandle that is compatible with
@@ -65,12 +64,6 @@ enum nfs3_stable_how {*/ static inline u32 nfs_fhandle_hash (const struct nfs_fh *fh) {return ~crc32_le (0xFFFFFFFF , &fh->data[0 ], fh->size); } -#else /* CONFIG_CRC32 */ -static inline u32 nfs_fhandle_hash (const struct nfs_fh *fh) -{ -return 0 ; -} -#endif /* CONFIG_CRC32 */ #endif /* _LINUX_NFS_H */
base-commit: 91e5bfe317d8f8471fbaa3e70cf66cae1314a516
Signature · 1 line
2.49.0
Quoted 7 lines · Eric Biggers
From: Eric Biggers <[email protected]>
nfs.ko, nfsd.ko, and lockd.ko all use
crc32_le(), which is available only whenCONFIG_CRC32is enabled. But the only NFS kconfig option that selectedCONFIG_CRC32wasCONFIG_NFS_DEBUG, which is client-specific and did not actually guard the use ofcrc32_le()even on the client.
Quoted 6 lines
The code worked around this bug by only actually calling
crc32_le()whenCONFIG_CRC32is built-in, instead hard-coding '0' in other cases. This avoided randconfig build errors, and in real kernels the fallback code was unlikely to be reached sinceCONFIG_CRC32is 'default y'. But, this really needs to just be done properly, especially now that I'm planning to updateCONFIG_CRC32to not be 'default y'.
It's interesting that no-one has noticed this before. dprintk is not the only consumer of the FH hash function: NFS/NFSD trace points also use it.
Eric, assuming you would like to carry this patch forward instead of us taking it through one of the NFS client or server trees:
for the hunks related to nfsd and lockd.
Quoted 191 lines
Therefore, make
CONFIG_NFS_FS,CONFIG_NFSD, andCONFIG_LOCKDselectCONFIG_CRC32. Then remove the fallback code that becomes unnecessary, as well as the selection ofCONFIG_CRC32fromCONFIG_NFS_DEBUG.Fixes 1264a2f053a3 ("NFS: refactor code for calculating the crc32 hash of a filehandle")Signed-off-by Eric Biggers <[email protected]>--- fs/Kconfig | 1 + fs/nfs/Kconfig | 2 +- fs/nfs/internal.h | 7 ------- fs/nfs/nfs4session.h | 4 ---- fs/nfsd/Kconfig | 1 + fs/nfsd/nfsfh.h | 7 ------- include/linux/nfs.h | 7 ------- 7 files changed, 3 insertions(+), 26 deletions(-)fs/Kconfig +1
-0@@ -366,10 +366,11 @@ config GRACE_PERIOD tristate config LOCKD tristate depends on FILE_LOCKING + select CRC32 select GRACE_PERIOD config LOCKD_V4 bool depends on NFSD || NFS_V3fs/nfs/Kconfig +1
-1@@ -1,9 +1,10 @@ # SPDX-License-Identifier: GPL-2.0-only config NFS_FS tristate "NFS client support" depends on INET && FILE_LOCKING && MULTIUSER + select CRC32 select LOCKD select SUNRPC select NFS_COMMON select NFS_ACL_SUPPORT if NFS_V3_ACL help@@ -194,11 +195,10 @@ config NFS_USE_KERNEL_DNS default y config NFS_DEBUG bool depends on NFS_FS && SUNRPC_DEBUG - select CRC32 default y config NFS_DISABLE_UDP_SUPPORT bool "NFS: Disable NFS UDP protocol support" depends on NFS_FSfs/nfs/internal.h +0
-7@@ -897,22 +897,15 @@ static inlineu64 nfs_timespec_to_change_attr (const struct timespec64 *ts) {return ((u64 )ts->tv_sec <<30 ) + ts->tv_nsec; } -#ifdef CONFIG_CRC32 static inline u32 nfs_stateid_hash (const nfs4_stateid *stateid) {return ~crc32_le (0xFFFFFFFF , &stateid->other[0 ],NFS4_STATEID_OTHER_SIZE ); } -#else -static inline u32 nfs_stateid_hash (nfs4_stateid *stateid) -{ -return 0 ; -} -#endif static inline bool nfs_error_is_fatal (int err) {switch (err) {case -ERESTARTSYS :fs/nfs/nfs4session.h +0
-4@@ -146,20 +146,16 @@ static inline void nfs4_copy_sessionid(struct nfs4_sessionid *dst, const struct nfs4_sessionid *src) {memcpy (dst->data, src->data,NFS4_MAX_SESSIONID_LEN ); } -#ifdef CONFIG_CRC32 /* * nfs_session_id_hash - calculate the crc32 hash for the session id * @session - pointer to session */ #define nfs_session_id_hash (sess_id) \ (~crc32_le(0xFFFFFFFF, &(sess_id)->data[0], sizeof((sess_id)->data))) -#else -#define nfs_session_id_hash (session) (0) -#endif #else /* defined(CONFIG_NFS_V4_1) */ static inline int nfs4_init_session (struct nfs_client *clp) {return 0 ;fs/nfsd/Kconfig +1
-0@@ -2,10 +2,11 @@ config NFSD tristate "NFS server support" depends on INET depends on FILE_LOCKING depends on FSNOTIFY + select CRC32 select LOCKD select SUNRPC select EXPORTFS select NFS_COMMON select NFS_ACL_SUPPORT if NFSD_V2_ACLfs/nfsd/nfsfh.h +0
-7@@ -265,11 +265,10 @@ static inline bool fh_fsid_match(const struct knfsd_fh *fh1,if (memcmp (fh1->fh_fsid, fh2->fh_fsid,key_len (fh1->fh_fsid_type)) !=0 )return false;return true; } -#ifdef CONFIG_CRC32 /** * knfsd_fh_hash - calculate the crc32 hash for the filehandle * @fh - pointer to filehandle * * returns a crc32 hash for the filehandle that is compatible with @@ -277,16 +276,10 @@ static inline bool fh_fsid_match(const struct knfsd_fh *fh1,*/ static inline u32 knfsd_fh_hash (const struct knfsd_fh *fh) {return ~crc32_le (0xFFFFFFFF , fh->fh_raw, fh->fh_size); } -#else -static inline u32 knfsd_fh_hash (const struct knfsd_fh *fh) -{ -return 0 ; -} -#endif /** * fh_clear_pre_post_attrs - Reset pre/post attributes * @fhp: file handle to be updated * include/linux/nfs.h +0
-7@@ -53,11 +53,10 @@ enum nfs3_stable_how {/* used by direct.c to mark verf as invalid */ NFS_INVALID_STABLE_HOW = -1 }; -#ifdef CONFIG_CRC32 /** * nfs_fhandle_hash - calculate the crc32 hash for the filehandle * @fh - pointer to filehandle * * returns a crc32 hash for the filehandle that is compatible with @@ -65,12 +64,6 @@ enum nfs3_stable_how {*/ static inline u32 nfs_fhandle_hash (const struct nfs_fh *fh) {return ~crc32_le (0xFFFFFFFF , &fh->data[0 ], fh->size); } -#else /* CONFIG_CRC32 */ -static inline u32 nfs_fhandle_hash (const struct nfs_fh *fh) -{ -return 0 ; -} -#endif /* CONFIG_CRC32 */ #endif /* _LINUX_NFS_H */ base-commit:
91e5bfe317d8f8471fbaa3e70cf66cae1314a516
Signature · 1 line
Chuck Lever
Quoted 19 lines · Chuck Lever
Quoted 7 lines · Eric Biggers
From: Eric Biggers <[email protected]>
nfs.ko, nfsd.ko, and lockd.ko all use
crc32_le(), which is available only whenCONFIG_CRC32is enabled. But the only NFS kconfig option that selectedCONFIG_CRC32wasCONFIG_NFS_DEBUG, which is client-specific and did not actually guard the use ofcrc32_le()even on the client.Quoted 6 lines
The code worked around this bug by only actually calling
crc32_le()whenCONFIG_CRC32is built-in, instead hard-coding '0' in other cases. This avoided randconfig build errors, and in real kernels the fallback code was unlikely to be reached sinceCONFIG_CRC32is 'default y'. But, this really needs to just be done properly, especially now that I'm planning to updateCONFIG_CRC32to not be 'default y'.It's interesting that no-one has noticed this before. dprintk is not the only consumer of the FH hash function: NFS/NFSD trace points also use it.
Quoted 6 lines
Eric, assuming you would like to carry this patch forward instead of us taking it through one of the NFS client or server trees:
Acked-by Chuck Lever <[email protected]>for the hunks related to nfsd and lockd.
Please go ahead and take it through one of the NFS trees. Thanks!
- Eric
Quoted 14 lines · Eric Biggers
From: Eric Biggers <[email protected]>
nfs.ko, nfsd.ko, and lockd.ko all use
crc32_le(), which is available only whenCONFIG_CRC32is enabled. But the only NFS kconfig option that selectedCONFIG_CRC32wasCONFIG_NFS_DEBUG, which is client-specific and did not actually guard the use ofcrc32_le()even on the client.The code worked around this bug by only actually calling
crc32_le()whenCONFIG_CRC32is built-in, instead hard-coding '0' in other cases. This avoided randconfig build errors, and in real kernels the fallback code was unlikely to be reached sinceCONFIG_CRC32is 'default y'. But, this really needs to just be done properly, especially now that I'm planning to updateCONFIG_CRC32to not be 'default y'.
Quoted 6 lines
Therefore, make
CONFIG_NFS_FS,CONFIG_NFSD, andCONFIG_LOCKDselectCONFIG_CRC32. Then remove the fallback code that becomes unnecessary, as well as the selection ofCONFIG_CRC32fromCONFIG_NFS_DEBUG.Fixes 1264a2f053a3 ("NFS: refactor code for calculating the crc32 hash of a filehandle")Signed-off-by Eric Biggers <[email protected]>
For the NFS client bits:
Thanks for looking at this!
Anna
Quoted 185 lines
--- fs/Kconfig | 1 + fs/nfs/Kconfig | 2 +- fs/nfs/internal.h | 7 ------- fs/nfs/nfs4session.h | 4 ---- fs/nfsd/Kconfig | 1 + fs/nfsd/nfsfh.h | 7 ------- include/linux/nfs.h | 7 ------- 7 files changed, 3 insertions(+), 26 deletions(-)fs/Kconfig +1
-0@@ -366,10 +366,11 @@ config GRACE_PERIOD tristate config LOCKD tristate depends on FILE_LOCKING + select CRC32 select GRACE_PERIOD config LOCKD_V4 bool depends on NFSD || NFS_V3fs/nfs/Kconfig +1
-1@@ -1,9 +1,10 @@ # SPDX-License-Identifier: GPL-2.0-only config NFS_FS tristate "NFS client support" depends on INET && FILE_LOCKING && MULTIUSER + select CRC32 select LOCKD select SUNRPC select NFS_COMMON select NFS_ACL_SUPPORT if NFS_V3_ACL help@@ -194,11 +195,10 @@ config NFS_USE_KERNEL_DNS default y config NFS_DEBUG bool depends on NFS_FS && SUNRPC_DEBUG - select CRC32 default y config NFS_DISABLE_UDP_SUPPORT bool "NFS: Disable NFS UDP protocol support" depends on NFS_FSfs/nfs/internal.h +0
-7@@ -897,22 +897,15 @@ static inlineu64 nfs_timespec_to_change_attr (const struct timespec64 *ts) {return ((u64 )ts->tv_sec <<30 ) + ts->tv_nsec; } -#ifdef CONFIG_CRC32 static inline u32 nfs_stateid_hash (const nfs4_stateid *stateid) {return ~crc32_le (0xFFFFFFFF , &stateid->other[0 ],NFS4_STATEID_OTHER_SIZE ); } -#else -static inline u32 nfs_stateid_hash (nfs4_stateid *stateid) -{ -return 0 ; -} -#endif static inline bool nfs_error_is_fatal (int err) {switch (err) {case -ERESTARTSYS :fs/nfs/nfs4session.h +0
-4@@ -146,20 +146,16 @@ static inline void nfs4_copy_sessionid(struct nfs4_sessionid *dst, const struct nfs4_sessionid *src) {memcpy (dst->data, src->data,NFS4_MAX_SESSIONID_LEN ); } -#ifdef CONFIG_CRC32 /* * nfs_session_id_hash - calculate the crc32 hash for the session id * @session - pointer to session */ #define nfs_session_id_hash (sess_id) \ (~crc32_le(0xFFFFFFFF, &(sess_id)->data[0], sizeof((sess_id)->data))) -#else -#define nfs_session_id_hash (session) (0) -#endif #else /* defined(CONFIG_NFS_V4_1) */ static inline int nfs4_init_session (struct nfs_client *clp) {return 0 ;fs/nfsd/Kconfig +1
-0@@ -2,10 +2,11 @@ config NFSD tristate "NFS server support" depends on INET depends on FILE_LOCKING depends on FSNOTIFY + select CRC32 select LOCKD select SUNRPC select EXPORTFS select NFS_COMMON select NFS_ACL_SUPPORT if NFSD_V2_ACLfs/nfsd/nfsfh.h +0
-7@@ -265,11 +265,10 @@ static inline bool fh_fsid_match(const struct knfsd_fh *fh1,if (memcmp (fh1->fh_fsid, fh2->fh_fsid,key_len (fh1->fh_fsid_type)) !=0 )return false;return true; } -#ifdef CONFIG_CRC32 /** * knfsd_fh_hash - calculate the crc32 hash for the filehandle * @fh - pointer to filehandle * * returns a crc32 hash for the filehandle that is compatible with @@ -277,16 +276,10 @@ static inline bool fh_fsid_match(const struct knfsd_fh *fh1,*/ static inline u32 knfsd_fh_hash (const struct knfsd_fh *fh) {return ~crc32_le (0xFFFFFFFF , fh->fh_raw, fh->fh_size); } -#else -static inline u32 knfsd_fh_hash (const struct knfsd_fh *fh) -{ -return 0 ; -} -#endif /** * fh_clear_pre_post_attrs - Reset pre/post attributes * @fhp: file handle to be updated * include/linux/nfs.h +0
-7@@ -53,11 +53,10 @@ enum nfs3_stable_how {/* used by direct.c to mark verf as invalid */ NFS_INVALID_STABLE_HOW = -1 }; -#ifdef CONFIG_CRC32 /** * nfs_fhandle_hash - calculate the crc32 hash for the filehandle * @fh - pointer to filehandle * * returns a crc32 hash for the filehandle that is compatible with @@ -65,12 +64,6 @@ enum nfs3_stable_how {*/ static inline u32 nfs_fhandle_hash (const struct nfs_fh *fh) {return ~crc32_le (0xFFFFFFFF , &fh->data[0 ], fh->size); } -#else /* CONFIG_CRC32 */ -static inline u32 nfs_fhandle_hash (const struct nfs_fh *fh) -{ -return 0 ; -} -#endif /* CONFIG_CRC32 */ #endif /* _LINUX_NFS_H */ base-commit:
91e5bfe317d8f8471fbaa3e70cf66cae1314a516
[email protected]
maintainerFrom: Chuck Lever <[email protected]>
Quoted 5 lines · Eric Biggers
nfs.ko, nfsd.ko, and lockd.ko all use
crc32_le(), which is available only whenCONFIG_CRC32is enabled. But the only NFS kconfig option that selectedCONFIG_CRC32wasCONFIG_NFS_DEBUG, which is client-specific and did not actually guard the use ofcrc32_le()even on the client.
Quoted 8 lines
The code worked around this bug by only actually calling
crc32_le()whenCONFIG_CRC32is built-in, instead hard-coding '0' in other cases. This avoided randconfig build errors, and in real kernels the fallback code was unlikely to be reached sinceCONFIG_CRC32is 'default y'. But, this really needs to just be done properly, especially now that I'm planning to updateCONFIG_CRC32to not be 'default y'.[...]
Applied to nfsd-testing, thanks!
[1/1] nfs: add missing selections of CONFIG_CRC32
commit: 3d28468e53a519bb8adc0675e5000f56f11e0602
--
Chuck Lever
Quoted 20 lines · Eric Biggers
Quoted 19 lines · Chuck Lever
Quoted 7 lines · Eric Biggers
From: Eric Biggers <[email protected]>
nfs.ko, nfsd.ko, and lockd.ko all use
crc32_le(), which is available only whenCONFIG_CRC32is enabled. But the only NFS kconfig option that selectedCONFIG_CRC32wasCONFIG_NFS_DEBUG, which is client-specific and did not actually guard the use ofcrc32_le()even on the client.Quoted 6 lines
The code worked around this bug by only actually calling
crc32_le()whenCONFIG_CRC32is built-in, instead hard-coding '0' in other cases. This avoided randconfig build errors, and in real kernels the fallback code was unlikely to be reached sinceCONFIG_CRC32is 'default y'. But, this really needs to just be done properly, especially now that I'm planning to updateCONFIG_CRC32to not be 'default y'.It's interesting that no-one has noticed this before. dprintk is not the only consumer of the FH hash function: NFS/NFSD trace points also use it.
Quoted 9 lines
Quoted 6 lines
Eric, assuming you would like to carry this patch forward instead of us taking it through one of the NFS client or server trees:
Acked-by Chuck Lever <[email protected]>for the hunks related to nfsd and lockd.
Please go ahead and take it through one of the NFS trees. Thanks!
I ended up sending in the removal of 'default y' from CONFIG_CRC32 for 6.15. So I recommend that you send this NFS patch in for 6.15 as well, as it's now slightly more likely that people can end up with CONFIG_CRC32 disabled (though many other parts of the kernel select it anyway, so it still tends to be enabled).
- Eric
Quoted 28 lines · Eric Biggers
Quoted 27 lines · Eric Biggers
Quoted 25 lines · Chuck Lever
Quoted 7 lines · Eric Biggers
From: Eric Biggers <[email protected]>
nfs.ko, nfsd.ko, and lockd.ko all use
crc32_le(), which is available only whenCONFIG_CRC32is enabled. But the only NFS kconfig option that selectedCONFIG_CRC32wasCONFIG_NFS_DEBUG, which is client-specific and did not actually guard the use ofcrc32_le()even on the client.Quoted 6 lines
The code worked around this bug by only actually calling
crc32_le()whenCONFIG_CRC32is built-in, instead hard-coding '0' in other cases. This avoided randconfig build errors, and in real kernels the fallback code was unlikely to be reached sinceCONFIG_CRC32is 'default y'. But, this really needs to just be done properly, especially now that I'm planning to updateCONFIG_CRC32to not be 'default y'.It's interesting that no-one has noticed this before. dprintk is not the only consumer of the FH hash function: NFS/NFSD trace points also use it.
Eric, assuming you would like to carry this patch forward instead of us taking it through one of the NFS client or server trees:
Acked-by Chuck Lever <[email protected]>for the hunks related to nfsd and lockd.
Quoted 8 lines
Quoted 2 lines
Please go ahead and take it through one of the NFS trees. Thanks!
I ended up sending in the removal of 'default y' from
CONFIG_CRC32for 6.15. So I recommend that you send this NFS patch in for 6.15 as well, as it's now slightly more likely that people can end up withCONFIG_CRC32disabled (though many other parts of the kernel select it anyway, so it still tends to be enabled).
I've moved the patch to nfsd-next, which has exposure to community automated testing robots. If no problems are reported, I will move the patch to nfsd-fixes and push it to v6.15-rc in a couple of weeks.
Signature · 1 line
Chuck Lever