Skip to contentSkip to conversation

nfsd: remove redundant WARN_ON_ONCE in nfsd4_write

PATCH In review Guoqing Jiang 2 participants 2 messages Apr 2, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfsd: remove redundant WARN_ON_ONCE in nfsd4_write

It can be removed since svc_fill_write_vector already has the same WARN_ON_ONCE.

---
 fs/nfsd/nfs4proc.c | 1 -
 1 file changed, 1 deletion(-)
fs/nfsd/nfs4proc.c +0 -1
index b397246dae7b..d1be58b557d1 100644
@@ -1228,7 +1228,6 @@ nfsd4_write(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
 	write->wr_how_written = write->wr_stable_how;
 
 	nvecs = svc_fill_write_vector(rqstp, &write->wr_payload);
-	WARN_ON_ONCE(nvecs > ARRAY_SIZE(rqstp->rq_vec));
 
 	status = nfsd_vfs_write(rqstp, &cstate->current_fh, nf,
 				write->wr_offset, rqstp->rq_vec, nvecs, &cnt,
Signature · 1 line
2.35.3
#1 lore raw

From: Chuck Lever <[email protected]>

Quoted 2 lines · Guoqing Jiang

It can be removed since svc_fill_write_vector already has the same WARN_ON_ONCE.

Applied to nfsd-testing, thanks!

[1/1] nfsd: remove redundant WARN_ON_ONCE in nfsd4_write

      commit: e20ef2bd835ca8c6e4b835a8e3f7cfa09957b7ab

--
Chuck Lever