drm/amdgpu: Enable per-queue reset for SDMA v4.4.2 on IP v9.5.0
Subsystems (2)
PATCH 1/2 drm/amdgpu: Enable per-queue reset for SDMA v4.4.2 on IP v9.5.0
Add support for per-queue reset on SDMA v4.4.2 when running with:
1. MEC firmware version 0xb0 or later
2. DPM indicates SDMA reset is supported
--- drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c +3 -1
@@ -2373,7 +2373,9 @@ static void sdma_v4_4_2_update_reset_mask(struct amdgpu_device *adev) adev->sdma.supported_reset |=AMDGPU_RESET_TYPE_PER_QUEUE ;break ;case IP_VERSION (9 ,5 ,0 ): -/*TODO: enable the queue reset flag until fw supported */ +if ((adev->gfx.mec_fw_version >=0xb0 ) &&amdgpu_dpm_reset_sdma_is_supported (adev)) + adev->sdma.supported_reset |=AMDGPU_RESET_TYPE_PER_QUEUE ; +break ;default :break ; }
Signature · 1 line
2.25.1
PATCH 2/2 drm/amdgpu: Enable TMZ support for GC 11.0.0
Add IP_VERSION(11, 0, 0) to the list of GPU generations that support TMZ.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c +1 -0
@@ -843,6 +843,7 @@ void amdgpu_gmc_tmz_set(struct amdgpu_device *adev)case IP_VERSION (9 ,3 ,0 ):/* GC 10.3.7 */ case IP_VERSION (10 ,3 ,7 ): +case IP_VERSION (11 ,0 ,0 ):/* GC 11.0.1 */ case IP_VERSION (11 ,0 ,1 ):if (amdgpu_tmz ==0 ) {
Signature · 1 line
2.25.1
Re: [PATCH 2/2] drm/amdgpu: Enable TMZ support for GC 11.0.0
Quoted 2 lines · On Thu, Apr 3, 2025 at 5:44 AM [email protected] <[email protected]> wrote:
Add
IP_VERSION(11, 0, 0)to the list of GPU generations that support TMZ.
Are you sure about that? TMZ will only work with user queues on gfx11 dGPUs.
Alex
Quoted 21 lines
Signed-off-by Jesse Zhang <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c +1
-1@@ -843,6 +843,7 @@ void amdgpu_gmc_tmz_set(struct amdgpu_device *adev)case IP_VERSION (9 ,3 ,0 ):/* GC 10.3.7 */ case IP_VERSION (10 ,3 ,7 ): +case IP_VERSION (11 ,0 ,0 ):/* GC 11.0.1 */ case IP_VERSION (11 ,0 ,1 ):if (amdgpu_tmz ==0 ) { --2.25.1
Quoted 2 lines · On 4/3/2025 3:13 PM, [email protected] wrote:
Add support for per-queue reset on SDMA v4.4.2 when running with:
1. MEC firmware version0xb0or later
This is not correct the version. Firmware team mentioned Rev 15.
Thanks,
Lijo
Quoted 22 lines
2. DPM indicates SDMA reset is supported
Signed-off-by Jesse.Zhang <[email protected]>--- drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c +3
-1@@ -2373,7 +2373,9 @@ static void sdma_v4_4_2_update_reset_mask(struct amdgpu_device *adev) adev->sdma.supported_reset |=AMDGPU_RESET_TYPE_PER_QUEUE ;break ;case IP_VERSION (9 ,5 ,0 ): -/*TODO: enable the queue reset flag until fw supported */ +if ((adev->gfx.mec_fw_version >=0xb0 ) &&amdgpu_dpm_reset_sdma_is_supported (adev)) + adev->sdma.supported_reset |=AMDGPU_RESET_TYPE_PER_QUEUE ; +break ;default :break ; }