Skip to contentSkip to conversation

RDMA/hfi1: use a struct group to avoid warning

PATCH Superseded Arnd Bergmann 4 participants 4 messages Apr 3, 2025 – Apr 10, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RDMA/hfi1: use a struct group to avoid warning

From: Arnd Bergmann <[email protected]>

On gcc-11 and earlier, the driver sometimes produces a warning for memset:

In file included from include/linux/string.h:392,
from drivers/infiniband/hw/hfi1/mad.c:6:
In function 'fortify_memset_chk',

    inlined from '__subn_get_opa_hfi1_cong_log' at drivers/infiniband/hw/hfi1/mad.c:3873:2,
    inlined from 'subn_get_opa_sma' at drivers/infiniband/hw/hfi1/mad.c:4114:9:
include/linux/fortify-string.h:480:4: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror]
    __write_overflow_field(p_size_field, size);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This seems to be a false positive, and I found no nice way to rewrite the code to avoid the warning, but adding a a struct group works.

---
 drivers/infiniband/hw/hfi1/hfi.h | 6 ++++--
 drivers/infiniband/hw/hfi1/mad.c | 4 ++--
 2 files changed, 6 insertions(+), 4 deletions(-)
drivers/infiniband/hw/hfi1/hfi.h +4 -2
index cb630551cf1a..fca37eb167cc 100644
@@ -883,8 +883,10 @@ struct hfi1_pportdata {
 	 * cc_log_lock protects all congestion log related data
 	 */
 	spinlock_t cc_log_lock ____cacheline_aligned_in_smp;
-	u8 threshold_cong_event_map[OPA_MAX_SLS / 8];
-	u16 threshold_event_counter;
+	struct_group (zero_event_map,
+		u8 threshold_cong_event_map[OPA_MAX_SLS / 8];
+		u16 threshold_event_counter;
+	);
 	struct opa_hfi1_cong_log_event_internal cc_events[OPA_CONG_LOG_ELEMS];
 	int cc_log_idx; /* index for logging events */
 	int cc_mad_idx; /* index for reporting events */
drivers/infiniband/hw/hfi1/mad.c +2 -2
index b39f63ce6dfc..0dea8d01e868 100644
@@ -3870,8 +3870,8 @@ static int __subn_get_opa_hfi1_cong_log(struct opa_smp *smp, u32 am,
 	 * Reset threshold_cong_event_map, and threshold_event_counter
 	 * to 0 when log is read.
 	 */
-	memset(ppd->threshold_cong_event_map, 0x0,
-	       sizeof(ppd->threshold_cong_event_map));
+	memset(&ppd->zero_event_map, 0x0,
+	       sizeof(ppd->zero_event_map));
 	ppd->threshold_event_counter = 0;
 
 	spin_unlock_irq(&ppd->cc_log_lock);
Signature · 1 line
2.39.5
#1 lore raw
Quoted 8 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

On gcc-11 and earlier, the driver sometimes produces a warning for memset:

In file included from include/linux/string.h:392,
from drivers/infiniband/hw/hfi1/mad.c:6:
In function 'fortify_memset_chk',

Quoted 8 lines
    inlined from '__subn_get_opa_hfi1_cong_log' at drivers/infiniband/hw/hfi1/mad.c:3873:2,
    inlined from 'subn_get_opa_sma' at drivers/infiniband/hw/hfi1/mad.c:4114:9:
include/linux/fortify-string.h:480:4: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror]
    __write_overflow_field(p_size_field, size);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This seems to be a false positive, and I found no nice way to rewrite the code to avoid the warning, but adding a a struct group works.

Er.. so do we really want to fix it or just ignore this on gcc-11? Or is there really a compile bug here and it is mis-generating the code?

The unneeded struct group seems ugly to me?

Jason

#2 lore raw
Quoted 15 lines · Jason Gunthorpe
Quoted 14 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

On gcc-11 and earlier, the driver sometimes produces a warning for memset:

In file included from include/linux/string.h:392,
from drivers/infiniband/hw/hfi1/mad.c:6:
In function 'fortify_memset_chk',

    inlined from '__subn_get_opa_hfi1_cong_log' at drivers/infiniband/hw/hfi1/mad.c:3873:2,
    inlined from 'subn_get_opa_sma' at drivers/infiniband/hw/hfi1/mad.c:4114:9:
include/linux/fortify-string.h:480:4: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror]
    __write_overflow_field(p_size_field, size);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Quoted 7 lines
Quoted 2 lines

This seems to be a false positive, and I found no nice way to rewrite the code to avoid the warning, but adding a a struct group works.

Er.. so do we really want to fix it or just ignore this on gcc-11? Or is there really a compile bug here and it is mis-generating the code?

The unneeded struct group seems ugly to me?

Having a clean build would be nice though. Do you think a patch that just turns off the warning locally would be better?

Arnd

#3 lore raw
Quoted 19 lines · Arnd Bergmann
Quoted 18 lines · Jason Gunthorpe
Quoted 16 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

On gcc-11 and earlier, the driver sometimes produces a warning for memset:

In file included from include/linux/string.h:392,
from drivers/infiniband/hw/hfi1/mad.c:6:
In function 'fortify_memset_chk',

    inlined from '__subn_get_opa_hfi1_cong_log' at drivers/infiniband/hw/hfi1/mad.c:3873:2,
    inlined from 'subn_get_opa_sma' at drivers/infiniband/hw/hfi1/mad.c:4114:9:
include/linux/fortify-string.h:480:4: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror]
    __write_overflow_field(p_size_field, size);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This seems to be a false positive, and I found no nice way to rewrite the code to avoid the warning, but adding a a struct group works.

Quoted 7 lines
Quoted 4 lines

Er.. so do we really want to fix it or just ignore this on gcc-11? Or is there really a compile bug here and it is mis-generating the code?

The unneeded struct group seems ugly to me?

Having a clean build would be nice though. Do you think a patch that just turns off the warning locally would be better?

I don't think so, as you will need to disable warning for specific compiler, which won't be nice.

My preference is to have a fix.

Thanks

Quoted 2 lines

Arnd