rpmsg: Use strscpy() instead of strscpy_pad()
Subsystems (2)
PATCH 1/1 rpmsg: Use strscpy() instead of strscpy_pad()
kzalloc() already zero-initializes the destination buffer, making strscpy() sufficient for safely copying the name. The additional NUL- padding performed by strscpy_pad() is unnecessary.
The size parameter is optional, and strscpy() automatically determines the size of the destination buffer using sizeof() when the argument is omitted. RPMSG_NAME_SIZE is equal to sizeof(rpdev->id.name) and can be removed - remove it.
No functional changes intended.
Signed-off-by Thorsten Blum <[email protected]>
--- drivers/rpmsg/qcom_glink_native.c | 2 +- drivers/rpmsg/qcom_smd.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/rpmsg/qcom_glink_native.c +1 -1
@@ -1663,7 +1663,7 @@ static int qcom_glink_rx_open(struct qcom_glink *glink, unsigned int rcid, } rpdev->ept = &channel->ept; -strscpy_pad (rpdev->id.name, name,RPMSG_NAME_SIZE ); +strscpy (rpdev->id.name, name); rpdev->src =RPMSG_ADDR_ANY ; rpdev->dst =RPMSG_ADDR_ANY ; rpdev->ops = &glink_device_ops;
drivers/rpmsg/qcom_smd.c +1 -1
@@ -1089,7 +1089,7 @@ static int qcom_smd_create_device(struct qcom_smd_channel *channel)/* Assign public information to the rpmsg_device */ rpdev = &qsdev->rpdev; -strscpy_pad (rpdev->id.name, channel->name,RPMSG_NAME_SIZE ); +strscpy (rpdev->id.name, channel->name); rpdev->src =RPMSG_ADDR_ANY ; rpdev->dst =RPMSG_ADDR_ANY ;
Signature · 1 line
2.49.0