Skip to contentSkip to conversation

drm,efi: Export efi_mem_desc_lookup for efidrm

PATCH In review Thomas Zimmermann 3 participants 7 messages Apr 8, 2025

Subsystems (4)
lore
Share & tools
lore

Thomas Zimmermann

author maintainer
#0 lore raw

cover drm,efi: Export efi_mem_desc_lookup for efidrm

Efidrm invokes efi_mem_desc_lookup(). Export the symbol to enable module builds of efidrm.

Thomas Zimmermann (2):
efi: Export symbol efi_mem_desc_lookup
drm/sysfb: efidrm: Support module builds

 drivers/firmware/efi/efi.c    | 1 +
 drivers/gpu/drm/sysfb/Kconfig | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)
Signature · 1 line
2.49.0
author maintainer
#1 lore raw

PATCH 1/2 efi: Export symbol efi_mem_desc_lookup

Building efidrm as module requires efi_mem_desc_lookup(). Export the symbol.

---
 drivers/firmware/efi/efi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/firmware/efi/efi.c +1 -0
index 7309394b8fc98..e57bff702b5f4 100644
@@ -558,6 +558,7 @@ int __efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
 
 extern int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
 	__weak __alias(__efi_mem_desc_lookup);
+EXPORT_SYMBOL_GPL(efi_mem_desc_lookup);
 
 /*
  * Calculate the highest address of an efi memory descriptor.
Signature · 1 line
2.49.0
maintainer Acked-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] efi: Export symbol efi_mem_desc_lookup

Quoted 9 lines · Thomas Zimmermann

Building efidrm as module requires efi_mem_desc_lookup(). Export the symbol.

---
 drivers/firmware/efi/efi.c | 1 +
 1 file changed, 1 insertion(+)

Feel free to take this via a DRM tree.

Quoted 15 lines
drivers/firmware/efi/efi.c +1 -1
index 7309394b8fc98..e57bff702b5f4 100644
@@ -558,6 +558,7 @@ int __efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
 
 extern int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
        __weak __alias(__efi_mem_desc_lookup);
+EXPORT_SYMBOL_GPL(efi_mem_desc_lookup);
 
 /*
  * Calculate the highest address of an efi memory descriptor.
--

2.49.0

author maintainer
#3 lore raw

Re: [PATCH 1/2] efi: Export symbol efi_mem_desc_lookup

Am 08.04.25 um 11:40 schrieb Ard Biesheuvel:

Quoted 10 lines · Thomas Zimmermann
Quoted 8 lines

Building efidrm as module requires efi_mem_desc_lookup(). Export the symbol.

---
  drivers/firmware/efi/efi.c | 1 +
  1 file changed, 1 insertion(+)

Thanks a lot.

Quoted 2 lines

Feel free to take this via a DRM tree.

I'll do that.

Best regards
Thomas

Quoted 17 lines
Quoted 17 lines
drivers/firmware/efi/efi.c +1 -1
index 7309394b8fc98..e57bff702b5f4 100644
@@ -558,6 +558,7 @@ int __efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
 
  extern int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
         __weak __alias(__efi_mem_desc_lookup);
+EXPORT_SYMBOL_GPL(efi_mem_desc_lookup);
 
  /*
   * Calculate the highest address of an efi memory descriptor.
--

2.49.0

Signature · 7 lines
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
author maintainer
#5 lore raw

PATCH 2/2 drm/sysfb: efidrm: Support module builds

In reply to Thomas Zimmermann

Make CONFIG_DRM_EFIDRM a tristate to enable module builds.

---
 drivers/gpu/drm/sysfb/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/sysfb/Kconfig +2 -2
index 5ac71d5ff8edf..9c9884c7efc6c 100644
@@ -8,8 +8,8 @@ config DRM_SYSFB_HELPER
 	depends on DRM
 
 config DRM_EFIDRM
-	bool "EFI framebuffer driver"
-	depends on (DRM=y) && MMU && EFI && (!SYSFB_SIMPLEFB || COMPILE_TEST)
+	tristate "EFI framebuffer driver"
+	depends on DRM && MMU && EFI && (!SYSFB_SIMPLEFB || COMPILE_TEST)
 	select APERTURE_HELPERS
 	select DRM_CLIENT_SELECTION
 	select DRM_GEM_SHMEM_HELPER
Signature · 1 line
2.49.0