drm/amdgpu: Clear overflow for SRIOV
Subsystems (2)
PATCH 1/1 drm/amdgpu: Clear overflow for SRIOV
For VF, it doesn't have the permission to clear overflow, clear the bit by reset.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c | 10 ++++++++-- drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h | 1 + drivers/gpu/drm/amd/amdgpu/ih_v6_0.c | 6 +++++- drivers/gpu/drm/amd/amdgpu/vega20_ih.c | 6 +++++- 4 files changed, 19 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c +8 -2
@@ -227,13 +227,19 @@ int amdgpu_ih_process(struct amdgpu_device *adev, struct amdgpu_ih_ring *ih) ih->rptr &= ih->ptr_mask; } -amdgpu_ih_set_rptr (adev, ih); +if (!ih->overflow) +amdgpu_ih_set_rptr (adev, ih); +wake_up_all (&ih->wait_process);/* make sure wptr hasn't changed while processing */ wptr =amdgpu_ih_get_wptr (adev, ih);if (wptr != ih->rptr) - goto restart_ih; +if (!ih->overflow) + goto restart_ih; + +if (ih->overflow) +amdgpu_amdkfd_gpu_reset (adev);return IRQ_HANDLED ; }
drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h +1 -0
@@ -72,6 +72,7 @@ struct amdgpu_ih_ring {/* For waiting on IH processing at checkpoint. */ wait_queue_head_t wait_process;uint64_t processed_timestamp; +bool overflow; };/* return true if time stamp t2 is after t1 with 48bit wrap around */
drivers/gpu/drm/amd/amdgpu/ih_v6_0.c +5 -1
@@ -349,6 +349,7 @@ static int ih_v6_0_irq_init(struct amdgpu_device *adev)if (ret)return ret; } + ih[i]->overflow = false; }/* update doorbell range for ih ring 0 */
@@ -446,7 +447,10 @@ static u32 ih_v6_0_get_wptr(struct amdgpu_device *adev, wptr =RREG32_NO_KIQ (ih_regs->ih_rb_wptr);if (!REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) goto out; - wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); +if (!amdgpu_sriov_vf (adev)) + wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); +else + ih->overflow = true;/* When a ring buffer overflow happen start parsing interrupt * from the last not overwritten vector (wptr + 32). Hopefully
drivers/gpu/drm/amd/amdgpu/vega20_ih.c +5 -1
@@ -350,6 +350,7 @@ static int vega20_ih_irq_init(struct amdgpu_device *adev)if (ret)return ret; } + ih[i]->overflow = false; }if (!amdgpu_sriov_vf (adev))
@@ -437,7 +438,10 @@ static u32 vega20_ih_get_wptr(struct amdgpu_device *adev,if (!REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) goto out; - wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); +if (!amdgpu_sriov_vf (adev)) + wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); +else + ih->overflow = true;/* When a ring buffer overflow happen start parsing interrupt * from the last not overwritten vector (wptr + 32). Hopefully
Signature · 1 line
2.34.1
Quoted 25 lines · Emily Deng
For VF, it doesn't have the permission to clear overflow, clear the bit by reset.
Signed-off-by Emily Deng <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c | 10 ++++++++-- drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h | 1 + drivers/gpu/drm/amd/amdgpu/ih_v6_0.c | 6 +++++- drivers/gpu/drm/amd/amdgpu/vega20_ih.c | 6 +++++- 4 files changed, 19 insertions(+), 4 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c +3
-1@@ -227,13 +227,19 @@ int amdgpu_ih_process(struct amdgpu_device *adev, struct amdgpu_ih_ring *ih) ih->rptr &= ih->ptr_mask; } -amdgpu_ih_set_rptr (adev, ih); +if (!ih->overflow) +amdgpu_ih_set_rptr (adev, ih); +wake_up_all (&ih->wait_process);
drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c int amdgpu_ih_process(struct amdgpu_device *adev, struct amdgpu_ih_ring *ih) · line 242
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c +5
-1/* make sure wptr hasn't changed while processing */ wptr =amdgpu_ih_get_wptr (adev, ih);if (wptr != ih->rptr) - goto restart_ih; +if (!ih->overflow) + goto restart_ih; + +if (ih->overflow) +amdgpu_amdkfd_gpu_reset (adev);
This won't work if KFD is not compiled in your kernel config.
Alex
Quoted 66 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c +0
-0return IRQ_HANDLED ; }drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h +1
-0@@ -72,6 +72,7 @@ struct amdgpu_ih_ring {/* For waiting on IH processing at checkpoint. */ wait_queue_head_t wait_process;uint64_t processed_timestamp; +bool overflow; };/* return true if time stamp t2 is after t1 with 48bit wrap around */ drivers/gpu/drm/amd/amdgpu/ih_v6_0.c +5
-1@@ -349,6 +349,7 @@ static int ih_v6_0_irq_init(struct amdgpu_device *adev)if (ret)return ret; } + ih[i]->overflow = false; }/* update doorbell range for ih ring 0 */ @@ -446,7 +447,10 @@ static u32 ih_v6_0_get_wptr(struct amdgpu_device *adev, wptr =RREG32_NO_KIQ (ih_regs->ih_rb_wptr);if (!REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) goto out; - wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); +if (!amdgpu_sriov_vf (adev)) + wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); +else + ih->overflow = true;/* When a ring buffer overflow happen start parsing interrupt * from the last not overwritten vector (wptr + 32). Hopefully drivers/gpu/drm/amd/amdgpu/vega20_ih.c +5
-2@@ -350,6 +350,7 @@ static int vega20_ih_irq_init(struct amdgpu_device *adev)if (ret)return ret; } + ih[i]->overflow = false; }if (!amdgpu_sriov_vf (adev))@@ -437,7 +438,10 @@ static u32 vega20_ih_get_wptr(struct amdgpu_device *adev,if (!REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) goto out; - wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); +if (!amdgpu_sriov_vf (adev)) + wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); +else + ih->overflow = true;/* When a ring buffer overflow happen start parsing interrupt * from the last not overwritten vector (wptr + 32). Hopefully -- 2.34.1
[AMD Official Use Only - AMD Internal Distribution Only]
Quoted 48 lines
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Alex Deucher
Sent: Friday, April 11, 2025 9:11 PM
To: Deng, Emily <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] drm/amdgpu: Clear overflow for SRIOVdrivers/gpu/drm/amd/amdgpu/amdgpu_ih.c int amdgpu_ih_process(struct amdgpu_device *adev,
Quoted 18 lines · Emily Deng
For VF, it doesn't have the permission to clear overflow, clear the bit by reset.
Signed-off-by Emily Deng <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c | 10 ++++++++-- drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h | 1 + drivers/gpu/drm/amd/amdgpu/ih_v6_0.c | 6 +++++- drivers/gpu/drm/amd/amdgpu/vega20_ih.c | 6 +++++- 4 files changed, 19 insertions(+), 4 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c +0
-0@@ -227,13 +227,19 @@ int amdgpu_ih_process(struct amdgpu_device *adev,struct
amdgpu_ih_ring*ih)Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c +3
-1ih->rptr &= ih->ptr_mask; } -amdgpu_ih_set_rptr (adev, ih); +if (!ih->overflow) +amdgpu_ih_set_rptr (adev, ih); +wake_up_all (&ih->wait_process);drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c int amdgpu_ih_process(struct amdgpu_device *adev, struct amdgpu_ih_ring *ih) · line 242
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c +5
-1/* make sure wptr hasn't changed while processing */ wptr =amdgpu_ih_get_wptr (adev, ih);if (wptr != ih->rptr) - goto restart_ih; +if (!ih->overflow) + goto restart_ih; + +if (ih->overflow) +amdgpu_amdkfd_gpu_reset (adev);This won't work if KFD is not compiled in your kernel config.
Quoted 1 line
Alex
Thanks, will modify and sent to review again.
Emily Deng
Best Wishes
Quoted 71 lines
drivers/gpu/drm/amd/amdgpu/vega20_ih.c static u32 vega20_ih_get_wptr(struct amdgpu_device
Quoted 56 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c +0
-0return IRQ_HANDLED ; }drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h +1
-0@@ -72,6 +72,7 @@ struct amdgpu_ih_ring {/* For waiting on IH processing at checkpoint. */ wait_queue_head_t wait_process;uint64_t processed_timestamp; +bool overflow; };/* return true if time stamp t2 is after t1 with 48bit wrap around */ drivers/gpu/drm/amd/amdgpu/ih_v6_0.c +1
-0@@ -349,6 +349,7 @@ static int ih_v6_0_irq_init(struct amdgpu_device *adev)if (ret)return ret; } + ih[i]->overflow = false; } /* update doorbell range for ih ring 0 */ @@ -446,7 +447,10 @@static u32 ih_v6_0_get_wptr(struct
amdgpu_device*adev,wptr = RREG32_NO_KIQ(ih_regs->ih_rb_wptr); if (!REG_GET_FIELD(wptr, IH_RB_WPTR, RB_OVERFLOW)) goto out;drivers/gpu/drm/amd/amdgpu/ih_v6_0.c +4
-1- wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); +if (!amdgpu_sriov_vf (adev)) + wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); +else + ih->overflow = true;/* When a ring buffer overflow happen start parsing interrupt * from the last not overwritten vector (wptr + 32). Hopefully drivers/gpu/drm/amd/amdgpu/vega20_ih.c +1
-0@@ -350,6 +350,7 @@ static int vega20_ih_irq_init(struct amdgpu_device *adev)if (ret)return ret; } + ih[i]->overflow = false; }if (!amdgpu_sriov_vf (adev))@@ -437,7 +438,10 @@ static u32 vega20_ih_get_wptr(struct amdgpu_device*adev,
Quoted 14 lines
drivers/gpu/drm/amd/amdgpu/vega20_ih.c +4
-2if (!REG_GET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW )) goto out; - wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); +if (!amdgpu_sriov_vf (adev)) + wptr =REG_SET_FIELD (wptr,IH_RB_WPTR ,RB_OVERFLOW ,0 ); +else + ih->overflow = true;/* When a ring buffer overflow happen start parsing interrupt * from the last not overwritten vector (wptr + 32). Hopefully -- 2.34.1