x86-mm-pat-untrack_pfn_copy-fix-doc-improvements.patch removed from -mm tree
The quilt patch titled
Subject: mm: (un)track_pfn_copy() fix + doc improvements
has been removed from the -mm tree. Its filename was
x86-mm-pat-untrack_pfn_copy-fix-doc-improvements.patch
This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: David Hildenbrand <[email protected]>
Subject: mm: (un)track_pfn_copy() fix + doc improvements
Date: Tue, 8 Apr 2025 10:59:50 +0200
We got a late smatch warning and some additional review feedback.
smatch warnings:
mm/memory.c:1428 copy_page_range() error: uninitialized symbol 'pfn'.
We actually use the pfn only when it is properly initialized; however, we may pass an uninitialized value to a function -- although it will not use it that likely still is UB in C.
So let's just fix it by always initializing pfn in the caller of track_pfn_copy(), and improving the documentation of track_pfn_copy().
While at it, clarify the doc of untrack_pfn_copy(), that internal checks make sure if we actually have to untrack anything.
---
include/linux/pgtable.h | 9 ++++++--- mm/memory.c | 2 +- 2 files changed, 7 insertions(+), 4 deletions(-)
include/linux/pgtable.h renamed from include/linux/pgtable.h~x86-mm-pat-untrack_pfn_copy-fix-doc-improvements +6 -3
@@ -1511,8 +1511,9 @@ static inline void track_pfn_insert(stru/* * track_pfn_copy is called when a VM_PFNMAP VMA is about to get the page -* tables copied during copy_page_range(). On success, stores the pfn to be -* passed to untrack_pfn_copy(). +* tables copied during copy_page_range(). Will store the pfn to be +* passed to untrack_pfn_copy() only if there is something to be untracked. +* Callers should initialize the pfn to 0. */ static inline int track_pfn_copy (struct vm_area_struct *dst_vma,struct vm_area_struct *src_vma,unsigned long *pfn)
@@ -1522,7 +1523,9 @@ static inline int track_pfn_copy(struct/* * untrack_pfn_copy is called when a VM_PFNMAP VMA failed to copy during -* copy_page_range(), but after track_pfn_copy() was already called. +* copy_page_range(), but after track_pfn_copy() was already called. Can +* be called even if track_pfn_copy() did not actually track anything: +* handled internally. */ static inline void untrack_pfn_copy (struct vm_area_struct *dst_vma,unsigned long pfn)
mm/memory.c renamed from mm/memory.c~x86-mm-pat-untrack_pfn_copy-fix-doc-improvements +1 -1
@@ -1361,7 +1361,7 @@ copy_page_range(struct vm_area_struct *dstruct mm_struct *dst_mm = dst_vma->vm_mm;struct mm_struct *src_mm = src_vma->vm_mm;struct mmu_notifier_range range; -unsigned long next, pfn; +unsigned long next, pfn =0 ;bool is_cow;int ret;
_
Patches currently in -mm which might be from [email protected] are
fs-dax-fix-folio-splitting-issue-by-resetting-old-folio-order-_nr_pages.patch kernel-events-uprobes-pass-vma-instead-of-mm-to-remove_breakpoint.patch kernel-events-uprobes-pass-vma-to-set_swbp-set_orig_insn-and-uprobe_write_opcode.patch kernel-events-uprobes-uprobe_write_opcode-rewrite.patch