security/selinux/hooks.c:3173: warning: Function parameter or struct member 'avd' not described in 'task_avdcache_update'
kernel test robot
build bottree: https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git next head: 5d7ddc59b3d89b724a5aa8f30d0db94ff8d2d93f commit: 5d7ddc59b3d89b724a5aa8f30d0db94ff8d2d93f [7/7] selinux: reduce path walk overhead config: i386-buildonly-randconfig-003-20250412 (https://download.01.org/0day-ci/archive/20250412/[email protected]/config) compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250412/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All warnings (new ones prefixed by >>):
>> security/selinux/hooks.c:3173: warning: Function parameter or struct member 'avd' not described in 'task_avdcache_update' >> security/selinux/hooks.c:3173: warning: Excess function parameter 'avdc' description in 'task_avdcache_update'
vim +3173 security/selinux/hooks.c
3158
3159 /**
3160 * task_avdcache_update - Update the task's AVD cache
3161 * @tsec: the task's security state
3162 * @isec: the inode associated with the cache entry
3163 * @avdc: the AVD info to cache
3164 * @audited: the permission audit bitmask to cache
3165 *
3166 * Update the AVD cache in @tsec with the @avdc and @audited info associated
3167 * with @isec.
3168 */
3169 static inline void task_avdcache_update(struct task_security_struct *tsec,
3170 struct inode_security_struct *isec,
3171 struct av_decision *avd,
3172 u32 audited)
> 3173 { 3174 int spot;
3175
3176 /* focused on path walk optimization, only cache directories */
3177 if (isec->sclass != SECCLASS_DIR)
3178 return;
3179
3180 /* update cache */
3181 spot = (tsec->avdcache.dir_spot + 1) & (TSEC_AVDC_DIR_SIZE - 1);
3182 tsec->avdcache.dir_spot = spot;
3183 tsec->avdcache.dir[spot].isid = isec->sid;
3184 tsec->avdcache.dir[spot].audited = audited;
3185 tsec->avdcache.dir[spot].allowed = avd->allowed;
3186 tsec->avdcache.dir[spot].permissive = avd->flags & AVD_FLAGS_PERMISSIVE;
3187 }
3188
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
Paul Moore
maintainerQuoted 50 lines · kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git next head: 5d7ddc59b3d89b724a5aa8f30d0db94ff8d2d93f commit: 5d7ddc59b3d89b724a5aa8f30d0db94ff8d2d93f [7/7] selinux: reduce path walk overhead config: i386-buildonly-randconfig-003-20250412 (https://download.01.org/0day-ci/archive/20250412/[email protected]/config) compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250412/[email protected]/reproduce)If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/All warnings (new ones prefixed by >>):
Quoted 2 lines
Quoted 2 lines
security/selinux/hooks.c:3173: warning: Function parameter or struct member 'avd' not described in 'task_avdcache_update'security/selinux/hooks.c:3173: warning: Excess function parameter 'avdc' description in 'task_avdcache_update'vim +3173
security/selinux/hooks.c3158
3159 /**3160 * task_avdcache_update - Update the task's AVD cache 3161 * @tsec: the task's security state 3162 * @isec: the inode associated with the cache entry 3163 * @avdc: the AVD info to cache 3164 * @audited: the permission audit bitmask to cache 3165 * 3166 * Update the AVD cache in @tsec with the @avdc and @audited info associated 3167 * with @isec. 3168 */ 3169 static inline void task_avdcache_update(struct task_security_struct *tsec, 3170 struct inode_security_struct *isec, 3171 struct av_decision *avd, 3172 u32 audited)Quoted 1 line
3173 {
3174 int spot;
3175
3176 /* focused on path walk optimization, only cache directories */
3177 if (isec->sclass!=SECCLASS_DIR)
3178 return;
31793180 /* update cache */ 3181 spot = (tsec->avdcache.dir_spot + 1) & (TSEC_AVDC_DIR_SIZE - 1); 3182 tsec->avdcache.dir_spot = spot; 3183 tsec->avdcache.dir[spot].isid = isec->sid; 3184 tsec->avdcache.dir[spot].audited = audited; 3185 tsec->avdcache.dir[spot].allowed = avd->allowed; 3186 tsec->avdcache.dir[spot].permissive = avd->flags & AVD_FLAGS_PERMISSIVE;
Quoted 6 lines
3187 }
3188--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Fixed.
https://lore.kernel.org/selinux/[email protected]/
Signature · 1 line
paul-moore.com