x86/Kconfig: Fix allyesconfig
Subsystems (2)
RFC PATCH 1/1 x86/Kconfig: Fix allyesconfig
64-bit allyesconfig builds fail with
x86_64-linux-ld: kernel image bigger than KERNEL_IMAGE_SIZE
Bisect points to commit 6f110a5e4f99 ("Disable SLUB_TINY for build testing") as the responsible commit. Reverting that patch does indeed fix the problem. Further analysis shows that disabling SLUB_TINY enables CONFIG_KASAN, and that CONFIG_KASAN is responsible for the image size increase.
Solve the test build problem by selectively disabling CONFIG_KASAN for 'allyesconfig' build tests of 64-bit X86 builds.
---
RFC: Maybe there is a better solution for the problem.
Even increasing the maximum image size to 1.5GB did not help. Also, maybe there is a better way to determine if this is an "allyesconfig" build test.
On top of that, I am not sure if the "Fixes" tag is really appropriate.
lib/Kconfig.kasan | 5 +++++ 1 file changed, 5 insertions(+)
lib/Kconfig.kasan +5 -0
@@ -31,6 +31,10 @@ config CC_HAS_KASAN_SW_TAGS config CC_HAS_WORKING_NOSANITIZE_ADDRESS def_bool !CC_IS_GCC || GCC_VERSION >= 80300 +config KASAN_COMPILE_TEST + tristate "KASAN compile test" + depends on COMPILE_TEST && 64BIT && X86 + menuconfig KASAN bool "KASAN: dynamic memory safety error detector" depends on (((HAVE_ARCH_KASAN && CC_HAS_KASAN_GENERIC) || \
@@ -38,6 +42,7 @@ menuconfig KASAN CC_HAS_WORKING_NOSANITIZE_ADDRESS) || \ HAVE_ARCH_KASAN_HW_TAGS depends on SYSFS && !SLUB_TINY + depends on KASAN_COMPILE_TEST!=y select STACKDEPOT_ALWAYS_INIT help Enables KASAN (Kernel Address Sanitizer) - a dynamic memory safety
Signature · 1 line
2.45.2
Quoted 3 lines · Guenter Roeck
Solve the test build problem by selectively disabling
CONFIG_KASANfor 'allyesconfig' build tests of 64-bit X86 builds.
I think we might as well just disable KASAN for COMPILE_TEST entirely
- not artificially limit it to just x86-64.
Apparently it was effectively disabled anyway due to that SLUB_TINY interaction, so while it would be nice to have bigger build coverage, clearly we haven't had it before, and it causes problems.
Linus
Quoted 5 lines · Linus Torvalds
Quoted 3 lines · Guenter Roeck
Solve the test build problem by selectively disabling
CONFIG_KASANfor 'allyesconfig' build tests of 64-bit X86 builds.
Quoted 7 lines
I think we might as well just disable KASAN for
COMPILE_TESTentirely
- not artificially limit it to just x86-64.Apparently it was effectively disabled anyway due to that
SLUB_TINYinteraction, so while it would be nice to have bigger build coverage, clearly we haven't had it before, and it causes problems.
sgtm. I'll wait another day or two to give others time to provide feedback and then send v2.
Guenter