Skip to contentSkip to conversation

acpica: Removing deprecated strncpy()

PATCH In review Kevin Paul Reddy Janagari 2 participants 2 messages Apr 14, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 acpica: Removing deprecated strncpy()

This patch suggests the replacement of strncpy with strscpy
as per Documentation/process/deprecated.
The strncpy() fails to guarantee NULL termination,
The function adds zero pads which isn't really convenient for short strings as it may cause performance issues.

strscpy() is a preferred replacement because
it overcomes the limitations of strncpy mentioned above.

Compile Tested

---
 drivers/acpi/acpica/exconvrt.c | 2 +-
 drivers/acpi/acpica/tbfind.c   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/acpi/acpica/exconvrt.c +1 -1
index bb1be42daee1..648e68a31e1f 100644
@@ -226,7 +226,7 @@ acpi_ex_convert_to_buffer(union acpi_operand_object *obj_desc,
 		/* Copy the string to the buffer */
 
 		new_buf = return_desc->buffer.pointer;
-		strncpy((char *)new_buf, (char *)obj_desc->string.pointer,
+		strscpy((char *)new_buf, (char *)obj_desc->string.pointer,
 			obj_desc->string.length);
 		break;
 
drivers/acpi/acpica/tbfind.c +2 -2
index 1c1b2e284bd9..5536d1755188 100644
@@ -57,8 +57,8 @@ acpi_tb_find_table(char *signature,
 
 	memset(&header, 0, sizeof(struct acpi_table_header));
 	ACPI_COPY_NAMESEG(header.signature, signature);
-	strncpy(header.oem_id, oem_id, ACPI_OEM_ID_SIZE);
-	strncpy(header.oem_table_id, oem_table_id, ACPI_OEM_TABLE_ID_SIZE);
+	strscpy(header.oem_id, oem_id, ACPI_OEM_ID_SIZE);
+	strscpy(header.oem_table_id, oem_table_id, ACPI_OEM_TABLE_ID_SIZE);
 
 	/* Search for the table */
 
Signature · 1 line
2.39.5
#1 lore raw
Quoted 11 lines · Kevin Paul Reddy Janagari

This patch suggests the replacement of strncpy with strscpy
as per Documentation/process/deprecated.
The strncpy() fails to guarantee NULL termination,
The function adds zero pads which isn't really convenient for short strings as it may cause performance issues.

strscpy() is a preferred replacement because
it overcomes the limitations of strncpy mentioned above.

Compile Tested

ACPICA material is primarily handled by the upstream ACPICA project on GitHub, so ACPICA changes should first be submitted to upstream ACPICA as indicated on this list for many times, see for instance:

https://lore.kernel.org/linux-acpi/CAJZ5v0gUDxrAn4W+Rf3ifjrg8Z9ZzTTOZjPFSSN5488mPqzXeA@mail.gmail.com/

Quoted 38 lines
---
 drivers/acpi/acpica/exconvrt.c | 2 +-
 drivers/acpi/acpica/tbfind.c   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/acpi/acpica/exconvrt.c +1 -1
index bb1be42daee1..648e68a31e1f 100644
@@ -226,7 +226,7 @@ acpi_ex_convert_to_buffer(union acpi_operand_object *obj_desc,
                /* Copy the string to the buffer */
 
                new_buf = return_desc->buffer.pointer;
-               strncpy((char *)new_buf, (char *)obj_desc->string.pointer,
+               strscpy((char *)new_buf, (char *)obj_desc->string.pointer,
                        obj_desc->string.length);
                break;
 
drivers/acpi/acpica/tbfind.c +2 -3
index 1c1b2e284bd9..5536d1755188 100644
@@ -57,8 +57,8 @@ acpi_tb_find_table(char *signature,
 
        memset(&header, 0, sizeof(struct acpi_table_header));
        ACPI_COPY_NAMESEG(header.signature, signature);
-       strncpy(header.oem_id, oem_id, ACPI_OEM_ID_SIZE);
-       strncpy(header.oem_table_id, oem_table_id, ACPI_OEM_TABLE_ID_SIZE);
+       strscpy(header.oem_id, oem_id, ACPI_OEM_ID_SIZE);
+       strscpy(header.oem_table_id, oem_table_id, ACPI_OEM_TABLE_ID_SIZE);
 
        /* Search for the table */
 
--

2.39.5