dt-bindings: phy: rockchip: Convert RK3399 PCIe PHY to schema
Subsystems (3)
Rob Herring (Arm)
maintainerPATCH 1/1 dt-bindings: phy: rockchip: Convert RK3399 PCIe PHY to schema
Convert the Rockchip RK3399 PCIe PHY to DT schema format. Move the example to the GRF binding as that has the complete block.
--- .../bindings/phy/rockchip-pcie-phy.txt | 36 ------------------- .../devicetree/bindings/soc/rockchip/grf.yaml | 13 +++++-- 2 files changed, 11 insertions(+), 38 deletions(-) delete mode 100644 Documentation/devicetree/bindings/phy/rockchip-pcie-phy.txt
Documentation/devicetree/bindings/phy/rockchip-pcie-phy.txt deleted +0 -36
@@ -1,36 +0,0 @@ -Rockchip PCIE PHY ------------------------ - -Required properties: - - compatible: rockchip,rk3399-pcie-phy - - clocks: Must contain an entry in clock-names. - See ../clocks/clock-bindings.txt for details. - - clock-names: Must be "refclk" - - resets: Must contain an entry in reset-names. - See ../reset/reset.txt for details. - - reset-names: Must be "phy" - -Required properties for legacy PHY mode (deprecated): - - #phy-cells: must be 0 - -Required properties for per-lane PHY mode (preferred): - - #phy-cells: must be 1 - -Example: - -grf: syscon@ff770000 { - compatible = "rockchip,rk3399-grf", "syscon", "simple-mfd"; - #address-cells = <1>; - #size-cells = <1>; - - ... - - pcie_phy: pcie-phy { - compatible = "rockchip,rk3399-pcie-phy"; - #phy-cells = <0>; - clocks = <&cru SCLK_PCIEPHY_REF>; - clock-names = "refclk"; - resets = <&cru SRST_PCIEPHY>; - reset-names = "phy"; - }; -};
Documentation/devicetree/bindings/soc/rockchip/grf.yaml +11 -2
@@ -201,8 +201,8 @@ allOf: pcie-phy: type: object - description: - Documentation/devicetree/bindings/phy/rockchip-pcie-phy.txt + $ref: /schemas/phy/rockchip,rk3399-pcie-phy.yaml# + unevaluatedProperties: false patternProperties: "^phy@[0-9a-f]+$":
@@ -326,6 +326,15 @@ examples: #phy-cells = <0>; }; + pcie-phy { + compatible = "rockchip,rk3399-pcie-phy"; + #phy-cells = <1>; + clocks = <&cru SCLK_PCIEPHY_REF>; + clock-names = "refclk"; + resets = <&cru SRST_PCIEPHY>; + reset-names = "phy"; + }; + phy@f780 { compatible = "rockchip,rk3399-emmc-phy"; reg = <0xf780 0x20>;
Signature · 1 line
2.47.2
Rob Herring (Arm)
maintainerQuoted 10 lines · Rob Herring (Arm)
Convert the Rockchip RK3399 PCIe PHY to DT schema format. Move the example to the GRF binding as that has the complete block.
Signed-off-by Rob Herring (Arm) <[email protected]>--- .../bindings/phy/rockchip-pcie-phy.txt | 36 ------------------- .../devicetree/bindings/soc/rockchip/grf.yaml | 13 +++++-- 2 files changed, 11 insertions(+), 38 deletions(-) delete mode 100644 Documentation/devicetree/bindings/phy/rockchip-pcie-phy.txt
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/rockchip/grf.example.dtb: syscon@ff770000 (rockchip,rk3399-grf): pcie-phy: False schema does not allow {'compatible': ['rockchip,rk3399-pcie-phy'], '#phy-cells': 1, 'clocks': [[4294967295, 138]], 'clock-names': ['refclk'], 'resets': [[4294967295, 135]], 'reset-names': ['phy']}
from schema $id: http://devicetree.org/schemas/soc/rockchip/grf.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/rockchip/grf.example.dtb: syscon@ff770000 (rockchip,rk3399-grf): pcie-phy: Unevaluated properties are not allowed ('#phy-cells', 'clock-names', 'clocks', 'compatible', 'reset-names', 'resets' were unexpected)
from schema $id: http://devicetree.org/schemas/soc/rockchip/grf.yaml#Documentation/devicetree/bindings/soc/rockchip/grf.example.dtb: /example-0/syscon@ff770000/pcie-phy: failed to match any schema with compatible: ['rockchip,rk3399-pcie-phy']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Rob Herring
maintainerQuoted 8 lines · Rob Herring (Arm)
Convert the Rockchip RK3399 PCIe PHY to DT schema format. Move the example to the GRF binding as that has the complete block.
Signed-off-by Rob Herring (Arm) <[email protected]>--- .../bindings/phy/rockchip-pcie-phy.txt | 36 ------------------- .../devicetree/bindings/soc/rockchip/grf.yaml | 13 +++++--
Sigh. Forgot the new schema...