PCI: Use PCI_STD_NUM_BARS instead of 6
PATCH 1/1 PCI: Use PCI_STD_NUM_BARS instead of 6
pci_read_bases() is given literal 6 that means PCI_STD_NUM_BARS. Replace the literal with the define to annotate the code better.
Signed-off-by Ilpo Järvinen <[email protected]>
--- drivers/pci/probe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/probe.c +1 -1
@@ -2058,7 +2058,7 @@ int pci_setup_device(struct pci_dev *dev)if (class ==PCI_CLASS_BRIDGE_PCI ) goto bad;pci_read_irq (dev); -pci_read_bases (dev,6 ,PCI_ROM_ADDRESS ); +pci_read_bases (dev,PCI_STD_NUM_BARS ,PCI_ROM_ADDRESS );pci_subsystem_ids (dev, &dev->subsystem_vendor, &dev->subsystem_device);
base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
Signature · 1 line
2.39.5
Quoted 22 lines · Ilpo Järvinen
pci_read_bases()is given literal 6 that meansPCI_STD_NUM_BARS. Replace the literal with the define to annotate the code better.Signed-off-by Ilpo Järvinen <[email protected]>--- drivers/pci/probe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/pci/probe.c +1
-1@@ -2058,7 +2058,7 @@ int pci_setup_device(struct pci_dev *dev)if (class ==PCI_CLASS_BRIDGE_PCI ) goto bad;pci_read_irq (dev); -pci_read_bases (dev,6 ,PCI_ROM_ADDRESS ); +pci_read_bases (dev,PCI_STD_NUM_BARS ,PCI_ROM_ADDRESS );pci_subsystem_ids (dev, &dev->subsystem_vendor, &dev->subsystem_device);
Quoted 4 lines
base-commit:
0af2f6be1b4281385b618cb86ad946eded089ac8Signature · 1 line
2.39.5
Reviewed-by Niklas Cassel <[email protected]>
Bjorn Helgaas
AppliedQuoted 4 lines · Ilpo Järvinen
pci_read_bases()is given literal 6 that meansPCI_STD_NUM_BARS. Replace the literal with the define to annotate the code better.Signed-off-by Ilpo Järvinen <[email protected]>
Applied to pci/enumeration for v6.16, thanks!
Quoted 22 lines
--- drivers/pci/probe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/pci/probe.c +1
-1@@ -2058,7 +2058,7 @@ int pci_setup_device(struct pci_dev *dev)if (class ==PCI_CLASS_BRIDGE_PCI ) goto bad;pci_read_irq (dev); -pci_read_bases (dev,6 ,PCI_ROM_ADDRESS ); +pci_read_bases (dev,PCI_STD_NUM_BARS ,PCI_ROM_ADDRESS );pci_subsystem_ids (dev, &dev->subsystem_vendor, &dev->subsystem_device);base-commit:
0af2f6be1b4281385b618cb86ad946eded089ac8Signature · 1 line
2.39.5