Skip to contentSkip to conversation

PCI: rockchip-ep: Mark RK3399 as intx_capable

PATCH RESEND Applied Niklas Cassel 2 participants 2 messages Apr 16, 2025 – Apr 20, 2025

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 PCI: rockchip-ep: Mark RK3399 as intx_capable

RK3399 can raise INTx interrupts, as can be seen by rockchip_pcie_ep_send_intx_irq().

This is also in line with the register description of PCIE_CLIENT_LEGACY_INT_CTRL, section "17.6.3 PCIe Client Detail Register Description" of the RK3399 TRM.

Thus, mark RK3399 as intx_capable.

---
 drivers/pci/controller/pcie-rockchip-ep.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pci/controller/pcie-rockchip-ep.c +1 -0
index 85ea36df2f59..626f6b31b0f6 100644
@@ -694,6 +694,7 @@ static const struct pci_epc_features rockchip_pcie_epc_features = {
 	.linkup_notifier = true,
 	.msi_capable = true,
 	.msix_capable = false,
+	.intx_capable = true,
 	.align = ROCKCHIP_PCIE_AT_SIZE_ALIGN,
 };
 
Signature · 1 line
2.49.0
#1 lore raw
Quoted 8 lines · Niklas Cassel

RK3399 can raise INTx interrupts, as can be seen by rockchip_pcie_ep_send_intx_irq().

This is also in line with the register description of PCIE_CLIENT_LEGACY_INT_CTRL, section "17.6.3 PCIe Client Detail Register Description" of the RK3399 TRM.

[...]

Applied, thanks!

[1/1] PCI: rockchip-ep: Mark RK3399 as intx_capable

      commit: a7d824b2df0d8b9e19c334594cdbffab97ff8d66

Best regards,

Signature · 1 line
Manivannan Sadhasivam <[email protected]>