drm/cirrus: Use non-hybrid PCI devres API
Subsystems (4)
PATCH 1/1 drm/cirrus: Use non-hybrid PCI devres API
cirrus enables its PCI device with pcim_enable_device(). This, implicitly, switches the function pci_request_regions() into managed mode, where it becomes a devres function.
The PCI subsystem wants to remove this hybrid nature from its interfaces. To do so, users of the aforementioned combination of functions must be ported to non-hybrid functions.
Replace the call to sometimes-managed pci_request_regions() with one to the always-managed pcim_request_all_regions().
--- drivers/gpu/drm/tiny/cirrus-qemu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/tiny/cirrus-qemu.c +1 -1
@@ -681,7 +681,7 @@ static int cirrus_pci_probe(struct pci_dev *pdev,if (ret)return ret; - ret =pci_request_regions (pdev,DRIVER_NAME ); + ret =pcim_request_all_regions (pdev,DRIVER_NAME );if (ret)return ret;
Signature · 1 line
2.48.1
Philipp Stanner <[email protected]> writes:
Hello Philipp,
Quoted 8 lines
cirrus enables its PCI device with
pcim_enable_device(). This, implicitly, switches the functionpci_request_regions()into managed mode, where it becomes a devres function.The PCI subsystem wants to remove this hybrid nature from its interfaces. To do so, users of the aforementioned combination of functions must be ported to non-hybrid functions.
Quoted 5 lines
Replace the call to sometimes-managed
pci_request_regions()with one to the always-managedpcim_request_all_regions().Signed-off-by Philipp Stanner <[email protected]>---
Signature · 5 lines
Best regards, Javier Martinez Canillas Core Platforms Red Hat
Quoted 13 lines · Javier Martinez Canillas
Philipp Stanner <[email protected]> writes:
Hello Philipp,
Quoted 9 lines
cirrus enables its PCI device with
pcim_enable_device(). This, implicitly, switches the functionpci_request_regions()into managed
mode, where it becomes a devres function.The PCI subsystem wants to remove this hybrid nature from its interfaces. To do so, users of the aforementioned combination of functions must be ported to non-hybrid functions.
Quoted 9 lines
Quoted 6 lines
Replace the call to sometimes-managed
pci_request_regions()with one to
the always-managedpcim_request_all_regions().Signed-off-by Philipp Stanner <[email protected]>---
Reviewed-by Javier Martinez Canillas <[email protected]>
Who's in charge of applying this? Any objections with me just putting it into drm-misc-next?
P.
Philipp Stanner <[email protected]> writes:
Hello Philipp,
Quoted 18 lines · Javier Martinez Canillas
Quoted 17 lines
Philipp Stanner <[email protected]> writes:
Hello Philipp,
Quoted 13 lines
cirrus enables its PCI device with
pcim_enable_device(). This, implicitly, switches the functionpci_request_regions()into managed
mode, where it becomes a devres function.The PCI subsystem wants to remove this hybrid nature from its interfaces. To do so, users of the aforementioned combination of functions must be ported to non-hybrid functions.
Replace the call to sometimes-managed
pci_request_regions()with one to
the always-managedpcim_request_all_regions().
Quoted 9 lines
Quoted 5 lines
Quoted 2 lines
Signed-off-by Philipp Stanner <[email protected]>---
Reviewed-by Javier Martinez Canillas <[email protected]>Who's in charge of applying this? Any objections with me just putting it into drm-misc-next?
Sure, go ahead.
Quoted 2 lines
P.
Signature · 5 lines
Best regards, Javier Martinez Canillas Core Platforms Red Hat
Philipp Stanner
AppliedQuoted 30 lines · Javier Martinez Canillas
Philipp Stanner <[email protected]> writes:
Hello Philipp,
Quoted 26 lines · Javier Martinez Canillas
Quoted 24 lines
Philipp Stanner <[email protected]> writes:
Hello Philipp,
Quoted 10 lines
cirrus enables its PCI device with
pcim_enable_device(). This, implicitly, switches the functionpci_request_regions()into managed
mode, where it becomes a devres function.The PCI subsystem wants to remove this hybrid nature from its interfaces. To do so, users of the aforementioned combination of
functions must be ported to non-hybrid functions.Quoted 7 lines
Replace the call to sometimes-managed
pci_request_regions()with
one to
the always-managedpcim_request_all_regions().Signed-off-by Philipp Stanner <[email protected]>---
Reviewed-by Javier Martinez Canillas <[email protected]>
Quoted 6 lines
Quoted 4 lines
Who's in charge of applying this? Any objections with me just putting
it into drm-misc-next?Sure, go ahead.
Applied, thx
Quoted 4 lines
Quoted 3 lines
P.