classes/recipes: remove unnecessary qemu inherit and use qemuwrapper-cross
PATCH v4 1/5 classes/recipes: remove unnecessary qemu inherit and use qemuwrapper-cross
From: Chen Qi <[email protected]>
These classes/recipes inherit qemu.bbclass but do not use anything from it. What they use is qemuwrapper-cross, which is needed at do_rootfs time and needs to be pulled-in by PACKAGE_WRITE_DEPS.
Also, in meta/conf/layer.conf, exclude qemuwrapper-cross deps for all arch recipes that depend on it. This it ensure allarch recipes have the same signature across different machines.
--- meta/classes-recipe/fontcache.bbclass | 3 +-- meta/classes-recipe/gio-module-cache.bbclass | 3 +-- meta/classes-recipe/gtk-immodules-cache.bbclass | 4 +--- meta/classes-recipe/manpages.bbclass | 2 +- meta/classes-recipe/pixbufcache.bbclass | 5 +---- meta/conf/layer.conf | 3 +++ meta/recipes-core/systemd/systemd_257.5.bb | 5 +++-- meta/recipes-core/udev/eudev_3.2.14.bb | 4 ++-- 8 files changed, 13 insertions(+), 16 deletions(-)
meta/classes-recipe/fontcache.bbclass +1 -2
@@ -9,8 +9,7 @@ # packages. # -PACKAGE_WRITE_DEPS += "qemu-native" -inherit qemu +PACKAGE_WRITE_DEPS += "qemuwrapper-cross" FONT_PACKAGES ??= "${PN}" FONT_PACKAGES:class-native = ""
meta/classes-recipe/gio-module-cache.bbclass +1 -2
@@ -4,8 +4,7 @@ # SPDX-License-Identifier: MIT # -PACKAGE_WRITE_DEPS += "qemu-native" -inherit qemu +PACKAGE_WRITE_DEPS += "qemuwrapper-cross" GIO_MODULE_PACKAGES ??= "${PN}"
meta/classes-recipe/gtk-immodules-cache.bbclass +1 -3
@@ -8,9 +8,7 @@ # # Usage: Set GTKIMMODULES_PACKAGES to the packages that needs to update the inputmethod modules -PACKAGE_WRITE_DEPS += "qemu-native" - -inherit qemu +PACKAGE_WRITE_DEPS += "qemuwrapper-cross" GTKIMMODULES_PACKAGES ?= "${PN}"
meta/classes-recipe/manpages.bbclass +1 -1
@@ -10,7 +10,7 @@ # by default. PACKAGECONFIG:append:class-target = " ${@bb.utils.contains('DISTRO_FEATURES', 'api-documentation', 'manpages', '', d)}" -inherit qemu +PACKAGE_WRITE_DEPS += "${@bb.utils.contains('DISTRO_FEATURES', 'api-documentation', 'qemuwrapper-cross', '', d)}" # usually manual files are packaged to ${PN}-doc except man-pages MAN_PKG ?= "${PN}-doc"
meta/classes-recipe/pixbufcache.bbclass +1 -4
@@ -9,12 +9,9 @@ # packages. # -DEPENDS:append:class-target = " qemu-native" -inherit qemu - PIXBUF_PACKAGES ??= "${PN}" -PACKAGE_WRITE_DEPS += "qemu-native gdk-pixbuf-native" +PACKAGE_WRITE_DEPS += "qemuwrapper-cross gdk-pixbuf-native" pixbufcache_common() { if [ "x$D" != "x" ]; then
meta/conf/layer.conf +3 -0
@@ -89,6 +89,9 @@ SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \ adwaita-icon-theme->gdk-pixbuf \ adwaita-icon-theme->gtk+3 \ run-postinsts->util-linux \ + cantarell-fonts->qemuwrapper-cross \ + liberation-fonts->qemuwrapper-cross \ + ttf-bitstream-vera->qemuwrapper-cross \ " # Avoid adding bison-native to the sysroot without a specific
meta/recipes-core/systemd/systemd_257.5.bb +3 -2
@@ -8,7 +8,7 @@ DEPENDS = "gperf-native libcap util-linux python3-jinja2-native" SECTION = "base/shell" -inherit useradd pkgconfig meson perlnative update-rc.d update-alternatives qemu systemd gettext bash-completion manpages features_check mime +inherit useradd pkgconfig meson perlnative update-rc.d update-alternatives systemd gettext bash-completion manpages features_check mime # unmerged-usr support is deprecated upstream, taints the system and will be # removed in the near future. Fail the build if it is not enabled.
@@ -932,7 +932,8 @@ pkg_prerm:${PN}:libc-glibc () { fi } -PACKAGE_WRITE_DEPS += "qemu-native" +PACKAGE_WRITE_DEPS += "qemuwrapper-cross" + pkg_postinst:udev-hwdb () { if test -n "$D"; then $INTERCEPT_DIR/postinst_intercept update_udev_hwdb ${PKG} mlprefix=${MLPREFIX} binprefix=${MLPREFIX} \
meta/recipes-core/udev/eudev_3.2.14.bb +2 -2
@@ -20,7 +20,7 @@ SRC_URI[sha256sum] = "8da4319102f24abbf7fff5ce9c416af848df163b29590e666d334cc192 GITHUB_BASE_URI = "https://github.com/eudev-project/eudev/releases" -inherit autotools update-rc.d qemu pkgconfig features_check manpages github-releases +inherit autotools update-rc.d pkgconfig features_check manpages github-releases CONFLICT_DISTRO_FEATURES = "systemd"
@@ -77,7 +77,7 @@ RDEPENDS:${PN} += "kmod" RPROVIDES:${PN} = "hotplug udev" RPROVIDES:${PN}-hwdb += "udev-hwdb" -PACKAGE_WRITE_DEPS += "qemu-native" +PACKAGE_WRITE_DEPS += "qemuwrapper-cross" pkg_postinst:${PN}-hwdb () { if test -n "$D"; then $INTERCEPT_DIR/postinst_intercept update_udev_hwdb ${PKG} mlprefix=${MLPREFIX} binprefix=${MLPREFIX}
Signature · 1 line
2.34.1
PATCH v4 2/5 cpio: fix ptest-runner dependency
From: Chen Qi <[email protected]>
ptest is only meaningful for target. So we need to specify class-target override to ensure correct dependency.
Also, the above DEPENDS:append:class-targets lacks a leading whitespace, add it.
--- meta/recipes-extended/cpio/cpio_2.15.bb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-extended/cpio/cpio_2.15.bb +2 -2
@@ -66,8 +66,8 @@ do_install_ptest_base:append() { } # The tests need to run as a non-root user, so pull in the ptest user -DEPENDS:append:class-target = "${@bb.utils.contains('PTEST_ENABLED', '1', ' ptest-runner', '', d)}" -PACKAGE_WRITE_DEPS += "ptest-runner" +DEPENDS:append:class-target = " ${@bb.utils.contains('PTEST_ENABLED', '1', ' ptest-runner', '', d)}" +PACKAGE_WRITE_DEPS:append:class-target = " ${@bb.utils.contains('PTEST_ENABLED', '1', ' ptest-runner', '', d)}" RDEPENDS:${PN}-ptest += "ptest-runner"
Signature · 1 line
2.34.1
PATCH v4 3/5 nativesdk.bbclass: handle PACKAGE_WRITE_DEPS
In reply to [email protected]From: Chen Qi <[email protected]>
We want nativesdk packages to depend on correct recipes introduced by PACKAGE_WRITE_DEPS, so do the same mapping just as we do for DEPENDS.
Before this change:
nativesdk-glib-2.0 -> qemuwrapper-cross
After this change:
nativesdk-glib-2.0 -> nativesdk-qemuwrapper-cross
This can fix do_populate_sdk failure complaining missing of nativesdk-qemuwrapper. Error message is like below:
NOTE: > Executing update_gio_module_cache-nativesdk intercept ...
NOTE: Exit code 127. Output:
/xxx/lib32-core-image-sato/1.0/intercept_scripts-xxxx/ update_gio_module_cache-nativesdk: 13: nativesdk-qemuwrapper: not found
--- meta/classes-recipe/nativesdk.bbclass | 1 + 1 file changed, 1 insertion(+)
meta/classes-recipe/nativesdk.bbclass +1 -0
@@ -104,6 +104,7 @@ python () { clsextend.rename_package_variables((d.getVar("PACKAGEVARS") or "").split()) clsextend.map_depends_variable("DEPENDS") + clsextend.map_depends_variable("PACKAGE_WRITE_DEPS") clsextend.map_packagevars() clsextend.map_variable("PROVIDES") clsextend.map_regexp_variable("PACKAGES_DYNAMIC")
Signature · 1 line
2.34.1
PATCH v4 4/5 image/populate_sdk.bbclass: drop qemuwrapper-cross from DEPENDS
In reply to [email protected]From: Chen Qi <[email protected]>
For packages that need qemuwrapper-cross, they should have it in PAKAGE_WRITE_DEPS.
Now that we've used 'qemuwrapper-cross' to replace 'qemu-native' for recipes that need qemu-native for their postinsts, and we've now mapped PACKAGE_WRITE_DEPS for nativesdk recipes, these qemuwrapper-cross dependencies can be dropped from image.bbclass and populate_sdk.bbclass.
--- meta/classes-recipe/image.bbclass | 2 +- meta/classes-recipe/populate_sdk_base.bbclass | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
meta/classes-recipe/image.bbclass +1 -1
@@ -30,7 +30,7 @@ POPULATE_SDK_POST_TARGET_COMMAND += "rootfs_sysroot_relativelinks" LICENSE ?= "MIT" PACKAGES = "" -DEPENDS += "${@' '.join(["%s-qemuwrapper-cross" % m for m in d.getVar("MULTILIB_VARIANTS").split()])} qemuwrapper-cross depmodwrapper-cross cross-localedef-native" +DEPENDS += "depmodwrapper-cross cross-localedef-native" RDEPENDS += "${PACKAGE_INSTALL} ${LINGUAS_INSTALL} ${IMAGE_INSTALL_DEBUGFS}" RRECOMMENDS += "${PACKAGE_INSTALL_ATTEMPTONLY}" PATH:prepend = "${@":".join(all_multilib_tune_values(d, 'STAGING_BINDIR_CROSS').split())}:"
meta/classes-recipe/populate_sdk_base.bbclass +1 -1
@@ -109,7 +109,7 @@ python () { } SDK_RDEPENDS = "${TOOLCHAIN_TARGET_TASK} ${TOOLCHAIN_HOST_TASK}" -SDK_DEPENDS = "virtual/fakeroot-native ${SDK_ARCHIVE_DEPENDS} cross-localedef-native nativesdk-qemuwrapper-cross ${@' '.join(["%s-qemuwrapper-cross" % m for m in d.getVar("MULTILIB_VARIANTS").split()])} qemuwrapper-cross" +SDK_DEPENDS = "virtual/fakeroot-native ${SDK_ARCHIVE_DEPENDS} cross-localedef-native" PATH:prepend = "${WORKDIR}/recipe-sysroot/${SDKPATHNATIVE}${bindir}/crossscripts:${@":".join(all_multilib_tune_values(d, 'STAGING_BINDIR_CROSS').split())}:" SDK_DEPENDS += "nativesdk-glibc-locale"
Signature · 1 line
2.34.1
PATCH v4 5/5 lib/classes/recipes: refactor qemu.bbclass functions into library functions
In reply to [email protected]From: Chen Qi <[email protected]>
Move the functions in qemu.bbclass to meta/lib/oe/qemu.py as they are generally useful. Add a deprecation notice in qemu.bbclass so that we can remove it in the future.
The re-definition of qemu_wrapper_cmdline in allarch.bbclass is replaced by re-definition of the write_qemuwrapper function. We need to do this because we need to have the same signature across different machines for recipes inheriting both allarch and meson.
Note that we cannot use vardepsexclude on oe.qemu.qemu_xxx functions conditionally in allarch.bbclass because python module functions currently do not support per-recipe vardepsexclude handling.
--- meta/classes-recipe/allarch.bbclass | 3 +- meta/classes-recipe/cmake-qemu.bbclass | 4 +- meta/classes-recipe/gtk-doc.bbclass | 4 +- meta/classes-recipe/libc-package.bbclass | 4 +- meta/classes-recipe/meson.bbclass | 4 +- meta/classes-recipe/qemu.bbclass | 57 +++---------------- meta/conf/bitbake.conf | 9 +++ meta/lib/oe/__init__.py | 2 +- meta/lib/oe/qemu.py | 54 ++++++++++++++++++ .../glibc/glibc-testsuite_2.41.bb | 4 +- meta/recipes-devtools/gcc/gcc-testsuite.inc | 4 +- .../recipes-devtools/python/python3_3.13.2.bb | 4 +- .../qemu/qemuwrapper-cross_1.0.bb | 4 +- .../gobject-introspection_1.84.0.bb | 4 +- 14 files changed, 89 insertions(+), 72 deletions(-) create mode 100644 meta/lib/oe/qemu.py
meta/classes-recipe/allarch.bbclass +2 -1
@@ -64,7 +64,8 @@ python () { d.appendVarFlag("write_specfile", "vardepsexclude", " MULTILIBS") d.appendVarFlag("do_package", "vardepsexclude", " package_do_shlibs") - d.setVar("qemu_wrapper_cmdline", "def qemu_wrapper_cmdline(data, rootfs_path, library_paths):\n return 'false'") + # Avoid write_qemuwrapper to depend on oe.qemu.qemu_wrapper_cmdline. + d.setVar("write_qemuwrapper", "write_qemuwrapper() {\n false \n}") elif bb.data.inherits_class('packagegroup', d) and not bb.data.inherits_class('nativesdk', d): bb.error("Please ensure recipe %s sets PACKAGE_ARCH before inherit packagegroup" % d.getVar("FILE")) }
meta/classes-recipe/cmake-qemu.bbclass +2 -2
@@ -14,7 +14,7 @@ # with this use case in mind this works very nicely also out of an IDE # configured to use cmake-native for cross compiling. -inherit qemu cmake +inherit cmake DEPENDS:append:class-target = "${@' qemu-native' if bb.utils.contains('MACHINE_FEATURES', 'qemu-usermode', True, False, d) else ''}"
@@ -22,7 +22,7 @@ cmake_do_generate_toolchain_file:append:class-target() { if ${@bb.utils.contains('MACHINE_FEATURES', 'qemu-usermode', 'true', 'false', d)}; then # Write out a qemu wrapper that will be used as exe_wrapper so that cmake # can run target helper binaries through that. This also allows to execute ctest. - qemu_binary="${@qemu_wrapper_cmdline(d, '${STAGING_DIR_HOST}', ['${STAGING_DIR_HOST}/${libdir}','${STAGING_DIR_HOST}/${base_libdir}'])}" + qemu_binary="${@oe.qemu.qemu_wrapper_cmdline(d, '${STAGING_DIR_HOST}', ['${STAGING_DIR_HOST}/${libdir}','${STAGING_DIR_HOST}/${base_libdir}'])}" echo "#!/bin/sh" > "${WORKDIR}/cmake-qemuwrapper" echo "$qemu_binary \"\$@\"" >> "${WORKDIR}/cmake-qemuwrapper" chmod +x "${WORKDIR}/cmake-qemuwrapper"
meta/classes-recipe/gtk-doc.bbclass +2 -2
@@ -35,14 +35,14 @@ DEPENDS:append = " gtk-doc-native" export STAGING_DIR_HOST -inherit python3native pkgconfig qemu +inherit python3native pkgconfig DEPENDS:append = "${@' qemu-native' if d.getVar('GTKDOC_ENABLED') == 'True' else ''}" do_compile:prepend:class-target () { if [ ${GTKDOC_ENABLED} = True ]; then # Write out a qemu wrapper that will be given to gtkdoc-scangobj so that it # can run target helper binaries through that. - qemu_binary="${@qemu_wrapper_cmdline(d, '$STAGING_DIR_HOST', ['\\$GIR_EXTRA_LIBS_PATH','$STAGING_DIR_HOST/${libdir}','$STAGING_DIR_HOST/${base_libdir}'])}" + qemu_binary="${@oe.qemu.qemu_wrapper_cmdline(d, '$STAGING_DIR_HOST', ['\\$GIR_EXTRA_LIBS_PATH','$STAGING_DIR_HOST/${libdir}','$STAGING_DIR_HOST/${base_libdir}'])}" cat > ${B}/gtkdoc-qemuwrapper << EOF #!/bin/sh # Use a modules directory which doesn't exist so we don't load random things
meta/classes-recipe/libc-package.bbclass +1 -3
@@ -94,8 +94,6 @@ do_collect_bins_from_locale_tree() { cross-localedef-hardlink -c -v ${WORKDIR}/locale-tree } -inherit qemu - python package_do_split_gconvs () { import re if (d.getVar('PACKAGE_NO_GCONV') == '1'):
@@ -284,7 +282,7 @@ python package_do_split_gconvs () { cmd = "PATH=\"%s\" I18NPATH=\"%s\" GCONV_PATH=\"%s\" cross-localedef %s" % \ (path, i18npath, gconvpath, localedef_opts) else: # earlier slower qemu way - qemu = qemu_target_binary(d) + qemu = oe.qemu.qemu_target_binary(d) localedef_opts = "--force --no-hard-links --no-archive --prefix=%s \ --inputfile=%s/i18n/locales/%s --charmap=%s %s" \ % (treedir, datadir, locale, encoding, name)
meta/classes-recipe/meson.bbclass +2 -2
@@ -4,7 +4,7 @@ # SPDX-License-Identifier: MIT # -inherit python3native meson-routines qemu +inherit python3native meson-routines DEPENDS:append = " meson-native ninja-native"
@@ -132,7 +132,7 @@ EOF write_qemuwrapper() { # Write out a qemu wrapper that will be used as exe_wrapper so that meson # can run target helper binaries through that. - qemu_binary="${@qemu_wrapper_cmdline(d, '$STAGING_DIR_HOST', ['$STAGING_DIR_HOST/${libdir}','$STAGING_DIR_HOST/${base_libdir}'])}" + qemu_binary="${@oe.qemu.qemu_wrapper_cmdline(d, '$STAGING_DIR_HOST', ['$STAGING_DIR_HOST/${libdir}','$STAGING_DIR_HOST/${base_libdir}'])}" cat > ${WORKDIR}/meson-qemuwrapper << EOF #!/bin/sh # Use a modules directory which doesn't exist so we don't load random things
meta/classes-recipe/qemu.bbclass +9 -48
65 lines not on this page · raw message
meta/conf/bitbake.conf +9 -0
@@ -896,6 +896,15 @@ ZSTD_DEFAULTS[vardepsexclude] = "ZSTD_THREADS" # may fallback to using all CPUs export OMP_NUM_THREADS = "${BB_NUMBER_THREADS}" +# QEMU_EXTRAOPTIONS is not meant to be directly used, the extensions are +# PACKAGE_ARCH, *NOT* overrides. +# In some cases (e.g. ppc) simply being arch specific (apparently) isn't good +# enough and a PACKAGE_ARCH specific -cpu option is needed (hence we have to do +# this dance). For others (e.g. arm) a -cpu option is not necessary, since the +# qemu-arm default CPU supports all required architecture levels. +QEMU_OPTIONS = "-r ${OLDEST_KERNEL} ${@d.getVar("QEMU_EXTRAOPTIONS:tune-%s" % d.getVar('TUNE_PKGARCH')) or ""}" +QEMU_OPTIONS[vardeps] += "QEMU_EXTRAOPTIONS:tune-${TUNE_PKGARCH}" + ################################################################## # Magic Cookie for SANITY CHECK ##################################################################
meta/lib/oe/__init__.py +1 -1
@@ -10,6 +10,6 @@ __path__ = extend_path(__path__, __name__) # Modules with vistorcode need to go first else anything depending on them won't be # processed correctly (e.g. qa) BBIMPORTS = ["qa", "data", "path", "utils", "types", "package", "packagedata", \ - "packagegroup", "sstatesig", "lsb", "cachedpath", "license", \ + "packagegroup", "sstatesig", "lsb", "cachedpath", "license", "qemu", \ "reproducible", "rust", "buildcfg", "go", "spdx30_tasks", "spdx_common", \ "cve_check"]
meta/lib/oe/qemu.py new file +54 -0
54 lines not on this page · raw message
meta/recipes-core/glibc/glibc-testsuite_2.41.bb +1 -3
@@ -1,8 +1,6 @@ require glibc_${PV}.bb require glibc-tests.inc -inherit qemu - SRC_URI += "file://check-test-wrapper" # strip provides
@@ -22,7 +20,7 @@ do_check:append () { oe_runmake -i \ QEMU_SYSROOT="${RECIPE_SYSROOT}" \ - QEMU_OPTIONS="${@qemu_target_binary(d)} ${QEMU_OPTIONS}" \ + QEMU_OPTIONS="${@oe.qemu.qemu_target_binary(d)} ${QEMU_OPTIONS}" \ SSH_HOST="${TOOLCHAIN_TEST_HOST}" \ SSH_HOST_USER="${TOOLCHAIN_TEST_HOST_USER}" \ SSH_HOST_PORT="${TOOLCHAIN_TEST_HOST_PORT}" \
meta/recipes-devtools/gcc/gcc-testsuite.inc +1 -3
@@ -1,5 +1,3 @@ -inherit qemu - TOOLCHAIN_TEST_TARGET ??= "user" TOOLCHAIN_TEST_HOST ??= "localhost" TOOLCHAIN_TEST_HOST_USER ??= "root"
@@ -41,7 +39,7 @@ python check_prepare() { content.append('process_multilib_options ""') # qemu args - qemu_binary = qemu_target_binary(d) + qemu_binary = oe.qemu.qemu_target_binary(d) if not qemu_binary: bb.fatal("Missing target qemu linux-user binary")
meta/recipes-devtools/python/python3_3.13.2.bb +2 -2
@@ -57,7 +57,7 @@ S = "${WORKDIR}/Python-${PV}" BBCLASSEXTEND = "native nativesdk" -inherit autotools pkgconfig qemu ptest multilib_header update-alternatives +inherit autotools pkgconfig ptest multilib_header update-alternatives MULTILIB_SUFFIX = "${@d.getVar('base_libdir',1).split('/')[-1]}"
@@ -168,7 +168,7 @@ write_pgo_wrapper() { cat >pgo-wrapper <<EOF #!/bin/sh cd ${B} -${@qemu_wrapper_cmdline(d, '${STAGING_DIR_TARGET}', ['${B}', '${STAGING_DIR_TARGET}/${base_libdir}'])} "\$@" +${@oe.qemu.qemu_wrapper_cmdline(d, '${STAGING_DIR_TARGET}', ['${B}', '${STAGING_DIR_TARGET}/${base_libdir}'])} "\$@" EOF chmod +x pgo-wrapper fi
meta/recipes-devtools/qemu/qemuwrapper-cross_1.0.bb +1 -3
@@ -7,14 +7,12 @@ UNPACKDIR = "${S}" DEPENDS += "qemu-native" -inherit qemu - do_populate_sysroot[depends] = "" do_install () { install -d ${D}${bindir_crossscripts}/ - qemu_binary=${@qemu_target_binary(d)} + qemu_binary=${@oe.qemu.qemu_target_binary(d)} qemu_options='${QEMU_OPTIONS} -E LD_LIBRARY_PATH=$D${libdir}:$D${base_libdir}' cat >> ${D}${bindir_crossscripts}/${MLPREFIX}qemuwrapper << EOF
meta/recipes-gnome/gobject-introspection/gobject-introspection_1.84.0.bb +2 -2
@@ -20,7 +20,7 @@ SRC_URI[sha256sum] = "945b57da7ec262e5c266b89e091d14be800cc424277d82a02872b7d794 SRC_URI:append:class-native = " file://0001-Relocate-the-repository-directory-for-native-builds.patch" -inherit meson pkgconfig gtk-doc python3targetconfig qemu gobject-introspection-data upstream-version-is-even multilib_script +inherit meson pkgconfig gtk-doc python3targetconfig gobject-introspection-data upstream-version-is-even multilib_script GTKDOC_MESON_OPTION = "gtk_doc"
@@ -64,7 +64,7 @@ do_configure:prepend:class-native() { do_configure:prepend:class-target() { # Write out a qemu wrapper that will be given to gi-scanner so that it # can run target helper binaries through that. - qemu_binary="${@qemu_wrapper_cmdline(d, '$STAGING_DIR_HOST', ['\\$GIR_EXTRA_LIBS_PATH','.libs','$STAGING_DIR_HOST/${libdir}','$STAGING_DIR_HOST/${base_libdir}'])}" + qemu_binary="${@oe.qemu.qemu_wrapper_cmdline(d, '$STAGING_DIR_HOST', ['\\$GIR_EXTRA_LIBS_PATH','.libs','$STAGING_DIR_HOST/${libdir}','$STAGING_DIR_HOST/${base_libdir}'])}" cat > ${B}/g-ir-scanner-qemuwrapper << EOF #!/bin/sh # Use a modules directory which doesn't exist so we don't load random things
Signature · 1 line
2.34.1
Re: [OE-core][PATCH V4 5/5] lib/classes/recipes: refactor qemu.bbclass functions into library functions
Quoted 6 lines · Chen Qi via lists.openembedded.org
From: Chen Qi <[email protected]>
Move the functions in qemu.bbclass to
meta/lib/oe/qemu.pyas they are generally useful. Add a deprecation notice in qemu.bbclass so that we can remove it in the future.
Quoted 8 lines
The re-definition of
qemu_wrapper_cmdlinein allarch.bbclass is replaced by re-definition of thewrite_qemuwrapperfunction. We need to do this because we need to have the same signature across different machines for recipes inheriting both allarch and meson.Note that we cannot use vardepsexclude on oe.qemu.qemu_xxx functions conditionally in allarch.bbclass because python module functions currently do not support per-recipe vardepsexclude handling.
I've been slowly merging in pieces of this series and in general I'm supportive of what it is doing. It has been a long term goal to get more of the python code into the python library directory in particular.
One thing this patch does which I don't like is that it moves QEMU_OPTIONS into bitbake.conf.
When the original patch set was discussed, I was very clear that I didn't like user mode qemu being available everywhere by default. I wanted recipes to have some clear sign they were using user mode qemu and that it should be something we strongly discourage.
With this patch applied, there becomes zero barrier to using qemu from recipes, it is effectively hidden.
I'm particularly frustrated that the patch commit log makes no mention of the QEMU_OPTIONS change.
I'd ask this patch is split up further, into the function change with the QEMU_OPTIONS part and the class deprecation left out. We can then further discuss that separately. As you might gather, I'm less keen on taking that aspect of it.
I do realise why WindRiver want to do this and I believe the changes are helping make what you want to do easier but I suspect dropping the qemu class entirely isn't going to be something we can do.
Cheers,
Richard
RE: [OE-core][PATCH V4 5/5] lib/classes/recipes: refactor qemu.bbclass functions into library functions
Hi Richard,
Sorry for any inconvenience. I never got the information that you want to set some barrier on using qemu user mode. I think I might have missed some emails.
Now the idea is clear to me. I will follow it. I'll send out a new patchset, removing the class deprecation and all related changes.
Regards,
Qi
-----Original Message-----
From: Richard Purdie <[email protected]>
Sent: Friday, April 25, 2025 11:33 PM
To: Chen, Qi <[email protected]>; [email protected]
Subject: Re: [OE-core][PATCH V4 5/5] lib/classes/recipes: refactor qemu.bbclass functions into library functions
Quoted 6 lines · Chen Qi via lists.openembedded.org
From: Chen Qi <[email protected]>
Move the functions in qemu.bbclass to
meta/lib/oe/qemu.pyas they are generally useful. Add a deprecation notice in qemu.bbclass so that we can remove it in the future.
Quoted 8 lines
The re-definition of
qemu_wrapper_cmdlinein allarch.bbclass is replaced by re-definition of thewrite_qemuwrapperfunction. We need to do this because we need to have the same signature across different machines for recipes inheriting both allarch and meson.Note that we cannot use vardepsexclude on oe.qemu.qemu_xxx functions conditionally in allarch.bbclass because python module functions currently do not support per-recipe vardepsexclude handling.
I've been slowly merging in pieces of this series and in general I'm supportive of what it is doing. It has been a long term goal to get more of the python code into the python library directory in particular.
One thing this patch does which I don't like is that it moves QEMU_OPTIONS into bitbake.conf.
When the original patch set was discussed, I was very clear that I didn't like user mode qemu being available everywhere by default. I wanted recipes to have some clear sign they were using user mode qemu and that it should be something we strongly discourage.
With this patch applied, there becomes zero barrier to using qemu from recipes, it is effectively hidden.
I'm particularly frustrated that the patch commit log makes no mention of the QEMU_OPTIONS change.
I'd ask this patch is split up further, into the function change with the QEMU_OPTIONS part and the class deprecation left out. We can then further discuss that separately. As you might gather, I'm less keen on taking that aspect of it.
I do realise why WindRiver want to do this and I believe the changes are helping make what you want to do easier but I suspect dropping the qemu class entirely isn't going to be something we can do.
Cheers,
Richard