Skip to contentSkip to conversation

crypto: atmel-sha204a - Set hwrng quality to lowest possible

PATCH In review Marek Behún 4 participants 4 messages Apr 22, 2025 – Apr 23, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: atmel-sha204a - Set hwrng quality to lowest possible

According to the review by Bill Cox [1], the Atmel SHA204A random number generator produces random numbers with very low entropy.

Set the lowest possible entropy for this chip just to be safe.

[1] https://www.metzdowd.com/pipermail/cryptography/2014-December/023858.html

Fixes da001fb651b00e1d ("crypto: atmel-i2c - add support for SHA204A random number generator")
---
 drivers/crypto/atmel-sha204a.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/crypto/atmel-sha204a.c +6 -0
index 75bebec2c757..0fcf4a39de27 100644
@@ -163,6 +163,12 @@ static int atmel_sha204a_probe(struct i2c_client *client)
 	i2c_priv->hwrng.name = dev_name(&client->dev);
 	i2c_priv->hwrng.read = atmel_sha204a_rng_read;
 
+	/*
+	 * According to review by Bill Cox [1], this HWRNG has very low entropy.
+	 * [1] https://www.metzdowd.com/pipermail/cryptography/2014-December/023858.html
+	 */
+	i2c_priv->hwrng.quality = 1;
+
 	ret = devm_hwrng_register(&client->dev, &i2c_priv->hwrng);
 	if (ret)
 		dev_warn(&client->dev, "failed to register RNG (%d)\n", ret);
Signature · 1 line
2.49.0
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Marek Behún

According to the review by Bill Cox [1], the Atmel SHA204A random number generator produces random numbers with very low entropy.

Set the lowest possible entropy for this chip just to be safe.

Quoted 8 lines

[1] https://www.metzdowd.com/pipermail/cryptography/2014-December/023858.html

Fixes da001fb651b00e1d ("crypto: atmel-i2c - add support for SHA204A random number generator")
---
 drivers/crypto/atmel-sha204a.c | 6 ++++++
 1 file changed, 6 insertions(+)

Wow, that is terrible

Quoted 20 lines
drivers/crypto/atmel-sha204a.c +6 -1
index 75bebec2c757..0fcf4a39de27 100644
@@ -163,6 +163,12 @@ static int atmel_sha204a_probe(struct i2c_client *client)
        i2c_priv->hwrng.name = dev_name(&client->dev);
        i2c_priv->hwrng.read = atmel_sha204a_rng_read;
 
+       /*
+        * According to review by Bill Cox [1], this HWRNG has very low entropy.
+        * [1] https://www.metzdowd.com/pipermail/cryptography/2014-December/023858.html
+        */
+       i2c_priv->hwrng.quality = 1;
+
        ret = devm_hwrng_register(&client->dev, &i2c_priv->hwrng);
        if (ret)
                dev_warn(&client->dev, "failed to register RNG (%d)\n", ret);
--

2.49.0

Reviewed-by on v1 1/1
#2 lore raw
In reply to Marek Behún
Quoted 9 lines · Marek Behún

According to the review by Bill Cox [1], the Atmel SHA204A random number generator produces random numbers with very low entropy.

Set the lowest possible entropy for this chip just to be safe.

[1] https://www.metzdowd.com/pipermail/cryptography/2014-December/023858.html

Fixes da001fb651b00e1d ("crypto: atmel-i2c - add support for SHA204A random number generator")

Ugh

I would even tag:
Cc: [email protected]

on this, but it's up to Herbert.

Yours,
Linus Walleij

maintainer
#3 lore raw
In reply to Marek Behún
Quoted 5 lines · Marek Behún

According to the review by Bill Cox [1], the Atmel SHA204A random number generator produces random numbers with very low entropy.

Set the lowest possible entropy for this chip just to be safe.

Quoted 7 lines

[1] https://www.metzdowd.com/pipermail/cryptography/2014-December/023858.html

Fixes da001fb651b00e1d ("crypto: atmel-i2c - add support for SHA204A random number generator")
---
 drivers/crypto/atmel-sha204a.c | 6 ++++++
 1 file changed, 6 insertions(+)

Patch appiled. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt