Skip to contentSkip to conversation

kernel/dma/mapping.c: Fix warning reported for missing prototype

PATCH Applied Balbir Singh 2 participants 2 messages Apr 22, 2025 DMA mapping helpers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel/dma/mapping.c: Fix warning reported for missing prototype

lkp reported a warning about missing prototype for a recent patch.

The kernel-doc style comments are out of sync, move them to the right function.

Cc Marek Szyprowski <[email protected]>
Cc Christoph Hellwig <[email protected]>
---
 kernel/dma/mapping.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
kernel/dma/mapping.c +8 -8
index 67da08fa6723..051a32988040 100644
@@ -910,14 +910,6 @@ int dma_set_coherent_mask(struct device *dev, u64 mask)
 }
 EXPORT_SYMBOL(dma_set_coherent_mask);
 
-/**
- * dma_addressing_limited - return if the device is addressing limited
- * @dev:	device to check
- *
- * Return %true if the devices DMA mask is too small to address all memory in
- * the system, else %false.  Lack of addressing bits is the prime reason for
- * bounce buffering, but might not be the only one.
- */
 static bool __dma_addressing_limited(struct device *dev)
 {
 	const struct dma_map_ops *ops = get_dma_ops(dev);
@@ -931,6 +923,14 @@ static bool __dma_addressing_limited(struct device *dev)
 	return !dma_direct_all_ram_mapped(dev);
 }
 
+/**
+ * dma_addressing_limited - return if the device is addressing limited
+ * @dev:	device to check
+ *
+ * Return %true if the devices DMA mask is too small to address all memory in
+ * the system, else %false.  Lack of addressing bits is the prime reason for
+ * bounce buffering, but might not be the only one.
+ */
 bool dma_addressing_limited(struct device *dev)
 {
 	if (!__dma_addressing_limited(dev))
Signature · 1 line
2.49.0
maintainer Applied
#1 lore raw
Quoted 5 lines · Balbir Singh

lkp reported a warning about missing prototype for a recent patch.

The kernel-doc style comments are out of sync, move them to the right function.

Quoted 7 lines
Cc Marek Szyprowski <[email protected]>
Cc Christoph Hellwig <[email protected]>

Thanks, applied to dma-mapping-fixes branch with reformatted subject.

Best regards

Signature · 2 lines
Marek Szyprowski, PhD
Samsung R&D Institute Poland