rxrpc: Remove deadcode
Subsystems (4)
PATCH v2 1/1 rxrpc: Remove deadcode
From: "Dr. David Alan Gilbert" <[email protected]>
Remove three functions that are no longer used.
rxrpc_get_txbuf() last use was removed by 2020's
commit 5e6ef4f1017c ("rxrpc: Make the I/O thread take over the call and local processor work")
rxrpc_kernel_get_epoch() last use was removed by 2020's
commit 44746355ccb1 ("afs: Don't get epoch from a server because it may be ambiguous")
rxrpc_kernel_set_max_life() last use was removed by 2023's commit db099c625b13 ("rxrpc: Fix timeout of a call that hasn't yet been granted a channel")
Both of the rxrpc_kernel_* functions were documented. Remove that documentation as well as the code.
---
v2 rebase on top of net-next 45bd443bfd86
Documentation/networking/rxrpc.rst | 24 ----------------- include/net/af_rxrpc.h | 3 --- net/rxrpc/af_rxrpc.c | 41 ------------------------------ net/rxrpc/ar-internal.h | 1 - net/rxrpc/txbuf.c | 8 ------ 5 files changed, 77 deletions(-)
Documentation/networking/rxrpc.rst +0 -24
@@ -1062,30 +1062,6 @@ The kernel interface functions are as follows: first function to change. Note that this must be called in TASK_RUNNING state. - (#) Get remote client epoch:: - - u32 rxrpc_kernel_get_epoch(struct socket *sock, - struct rxrpc_call *call) - - This allows the epoch that's contained in packets of an incoming client - call to be queried. This value is returned. The function always - successful if the call is still in progress. It shouldn't be called once - the call has expired. Note that calling this on a local client call only - returns the local epoch. - - This value can be used to determine if the remote client has been - restarted as it shouldn't change otherwise. - - (#) Set the maximum lifespan on a call:: - - void rxrpc_kernel_set_max_life(struct socket *sock, - struct rxrpc_call *call, - unsigned long hard_timeout) - - This sets the maximum lifespan on a call to hard_timeout (which is in - jiffies). In the event of the timeout occurring, the call will be - aborted and -ETIME or -ETIMEDOUT will be returned. - (#) Apply the RXRPC_MIN_SECURITY_LEVEL sockopt to a socket from within in the kernel::
include/net/af_rxrpc.h +0 -3
@@ -88,9 +88,6 @@ int rxrpc_kernel_charge_accept(struct socket *sock, rxrpc_notify_rx_t notify_rx, unsigned int debug_id);void rxrpc_kernel_set_tx_length (struct socket *,struct rxrpc_call *,s64 );bool rxrpc_kernel_check_life (const struct socket *,const struct rxrpc_call *); -u32 rxrpc_kernel_get_epoch (struct socket *,struct rxrpc_call *); -void rxrpc_kernel_set_max_life (struct socket *,struct rxrpc_call *, -unsigned long );int rxrpc_sock_set_min_security_level (struct sock *sk,unsigned int val);int rxrpc_sock_set_security_keyring (struct sock *,struct key *);
net/rxrpc/af_rxrpc.c +0 -41
53 lines not on this page · raw message
net/rxrpc/ar-internal.h +0 -1
@@ -1503,7 +1503,6 @@ static inline void rxrpc_sysctl_exit(void) {}extern atomic_t rxrpc_nr_txbuf;struct rxrpc_txbuf *rxrpc_alloc_data_txbuf (struct rxrpc_call *call,size_t data_size,size_t data_align,gfp_t gfp); -void rxrpc_get_txbuf (struct rxrpc_txbuf *txb,enum rxrpc_txbuf_trace what);void rxrpc_see_txbuf (struct rxrpc_txbuf *txb,enum rxrpc_txbuf_trace what);void rxrpc_put_txbuf (struct rxrpc_txbuf *txb,enum rxrpc_txbuf_trace what);
net/rxrpc/txbuf.c +0 -8
@@ -60,14 +60,6 @@ struct rxrpc_txbuf *rxrpc_alloc_data_txbuf(struct rxrpc_call *call, size_t data_return txb; } -void rxrpc_get_txbuf (struct rxrpc_txbuf *txb,enum rxrpc_txbuf_trace what) -{ -int r; - -__refcount_inc (&txb->ref, &r); -trace_rxrpc_txbuf (txb->debug_id, txb->call_debug_id, txb->seq, r +1 , what); -} -void rxrpc_see_txbuf (struct rxrpc_txbuf *txb,enum rxrpc_txbuf_trace what) {int r =refcount_read (&txb->ref);
Signature · 1 line
2.49.0
Quoted 12 lines · [email protected] wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
Remove three functions that are no longer used.
rxrpc_get_txbuf()last use was removed by 2020's
commit5e6ef4f1017c("rxrpc: Make the I/O thread take over the call and local processor work")
rxrpc_kernel_get_epoch()last use was removed by 2020's
commit44746355ccb1("afs: Don't get epoch from a server because it may be ambiguous")
Quoted 8 lines
rxrpc_kernel_set_max_life()last use was removed by 2023's commitdb099c625b13("rxrpc: Fix timeout of a call that hasn't yet been granted a channel")Both of the rxrpc_kernel_* functions were documented. Remove that documentation as well as the code.
Signed-off-by Dr. David Alan Gilbert <[email protected]>
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Wed, 23 Apr 2025 00:51:47 +0100 you wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
Remove three functions that are no longer used.
rxrpc_get_txbuf()last use was removed by 2020's
commit5e6ef4f1017c("rxrpc: Make the I/O thread take over the call and local processor work")[...]
Here is the summary with links:
- [net-next,v2] rxrpc: Remove deadcode
https://git.kernel.org/netdev/net-next/c/39144062ea33
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html