Skip to contentSkip to conversation

EISA: Move devlist.h out of obj to always

PATCH In review Kees Cook 3 participants 7 messages Apr 23, 2025 – May 7, 2025

lore
Share & tools
lore

Kees Cook

author
#0 lore raw

PATCH 1/1 EISA: Move devlist.h out of obj to always

I put devlist.h into the wrong Makefile macro ("obj") to get it included in "targets". Put it into "always" so nothing tries to link against it. Solves CONFIG_EISA=y i386 build failure:

ld: vmlinux.a: member drivers/eisa/devlist.h in archive is not an object

Fixes dd09eb0e2cc4 ("EISA: Increase length of device names")

---
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Alejandro Colomar <[email protected]>

---
 drivers/eisa/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/eisa/Makefile +2 -1
index f0d6cf7d1f32..552bd9478340 100644
@@ -1,7 +1,8 @@
 # SPDX-License-Identifier: GPL-2.0
 # Makefile for the Linux device tree
 
-obj-$(CONFIG_EISA)	        += devlist.h eisa-bus.o
+always-$(CONFIG_EISA)		+= devlist.h
+obj-$(CONFIG_EISA)	        += eisa-bus.o
 obj-${CONFIG_EISA_PCI_EISA}     += pci_eisa.o
 
 # virtual_root.o should be the last EISA root device to initialize,
Signature · 1 line
2.34.1
Acked-by Tested-by on v1 1/1
#1 lore raw
Quoted 10 lines · Kees Cook

I put devlist.h into the wrong Makefile macro ("obj") to get it included in "targets". Put it into "always" so nothing tries to link against it. Solves CONFIG_EISA=y i386 build failure:

ld: vmlinux.a: member drivers/eisa/devlist.h in archive is not an object

Fixes dd09eb0e2cc4 ("EISA: Increase length of device names")

Thanks.

Quoted 21 lines

---
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Alejandro Colomar <[email protected]>

---
 drivers/eisa/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/eisa/Makefile +2 -1
index f0d6cf7d1f32..552bd9478340 100644
@@ -1,7 +1,8 @@
 # SPDX-License-Identifier: GPL-2.0
 # Makefile for the Linux device tree
 
-obj-$(CONFIG_EISA)	        += devlist.h eisa-bus.o
+always-$(CONFIG_EISA)		+= devlist.h
+obj-$(CONFIG_EISA)	        += eisa-bus.o
 obj-${CONFIG_EISA_PCI_EISA}     += pci_eisa.o
 
 # virtual_root.o should be the last EISA root device to initialize,
Signature · 1 line
~Randy
#2 lore raw

Hi Kees,

Quoted 14 lines · Randy Dunlap
Quoted 10 lines · Kees Cook

I put devlist.h into the wrong Makefile macro ("obj") to get it included in "targets". Put it into "always" so nothing tries to link against it. Solves CONFIG_EISA=y i386 build failure:

ld: vmlinux.a: member drivers/eisa/devlist.h in archive is not an object

Fixes dd09eb0e2cc4 ("EISA: Increase length of device names")
Quoted 5 lines

Thanks.

Please merge this patch. The build failure is killing lots of i386 builds. Thanks.

Quoted 22 lines
Quoted 21 lines

---
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Alejandro Colomar <[email protected]>

---
 drivers/eisa/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/eisa/Makefile +2 -1
index f0d6cf7d1f32..552bd9478340 100644
@@ -1,7 +1,8 @@
 # SPDX-License-Identifier: GPL-2.0
 # Makefile for the Linux device tree
 
-obj-$(CONFIG_EISA)	        += devlist.h eisa-bus.o
+always-$(CONFIG_EISA)		+= devlist.h
+obj-$(CONFIG_EISA)	        += eisa-bus.o
 obj-${CONFIG_EISA_PCI_EISA}     += pci_eisa.o
 
 # virtual_root.o should be the last EISA root device to initialize,
Signature · 1 line
~Randy
author
#3 lore raw
Quoted 17 lines · Randy Dunlap

Hi Kees,

Quoted 14 lines · Randy Dunlap
Quoted 10 lines · Kees Cook

I put devlist.h into the wrong Makefile macro ("obj") to get it included in "targets". Put it into "always" so nothing tries to link against it. Solves CONFIG_EISA=y i386 build failure:

ld: vmlinux.a: member drivers/eisa/devlist.h in archive is not an object

Fixes dd09eb0e2cc4 ("EISA: Increase length of device names")
Quoted 8 lines
Quoted 5 lines

Thanks.

Please merge this patch. The build failure is killing lots of i386 builds. Thanks.

AFAIK, this needs to go via Greg's tree, but I can see if I can send it to Linus directly.

-Kees

Quoted 27 lines
Quoted 23 lines
Quoted 22 lines

---
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Alejandro Colomar <[email protected]>

---
 drivers/eisa/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/eisa/Makefile +2 -1
index f0d6cf7d1f32..552bd9478340 100644
@@ -1,7 +1,8 @@
 # SPDX-License-Identifier: GPL-2.0
 # Makefile for the Linux device tree
 
-obj-$(CONFIG_EISA)	        += devlist.h eisa-bus.o
+always-$(CONFIG_EISA)		+= devlist.h
+obj-$(CONFIG_EISA)	        += eisa-bus.o
 obj-${CONFIG_EISA_PCI_EISA}     += pci_eisa.o
 
 # virtual_root.o should be the last EISA root device to initialize,
Signature · 1 line
~Randy
Signature · 1 line
Kees Cook
#4 lore raw
Quoted 24 lines · Kees Cook
Quoted 23 lines · Randy Dunlap

Hi Kees,

Quoted 19 lines · Randy Dunlap
Quoted 10 lines · Kees Cook

I put devlist.h into the wrong Makefile macro ("obj") to get it included in "targets". Put it into "always" so nothing tries to link against it. Solves CONFIG_EISA=y i386 build failure:

ld: vmlinux.a: member drivers/eisa/devlist.h in archive is not an object

Fixes dd09eb0e2cc4 ("EISA: Increase length of device names")

Thanks.

Quoted 7 lines
Quoted 2 lines

Please merge this patch. The build failure is killing lots of i386 builds. Thanks.

AFAIK, this needs to go via Greg's tree, but I can see if I can send it to Linus directly.

-Kees

Greg told me that it belongs to one of your trees, but Greg did merge the previous eisa/Makefile patch.

Quoted 29 lines
Quoted 28 lines
Quoted 24 lines
Quoted 23 lines

---
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Alejandro Colomar <[email protected]>

---
 drivers/eisa/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/eisa/Makefile +2 -1
index f0d6cf7d1f32..552bd9478340 100644
@@ -1,7 +1,8 @@
 # SPDX-License-Identifier: GPL-2.0
 # Makefile for the Linux device tree
 
-obj-$(CONFIG_EISA)	        += devlist.h eisa-bus.o
+always-$(CONFIG_EISA)		+= devlist.h
+obj-$(CONFIG_EISA)	        += eisa-bus.o
 obj-${CONFIG_EISA_PCI_EISA}     += pci_eisa.o
 
 # virtual_root.o should be the last EISA root device to initialize,
Signature · 1 line
~Randy
Signature · 1 line
~Randy
author
#6 lore raw
In reply to Randy Dunlap
Quoted 17 lines · Randy Dunlap

Hi Kees,

Quoted 14 lines · Randy Dunlap
Quoted 10 lines · Kees Cook

I put devlist.h into the wrong Makefile macro ("obj") to get it included in "targets". Put it into "always" so nothing tries to link against it. Solves CONFIG_EISA=y i386 build failure:

ld: vmlinux.a: member drivers/eisa/devlist.h in archive is not an object

Fixes dd09eb0e2cc4 ("EISA: Increase length of device names")
Quoted 8 lines
Quoted 5 lines

Thanks.

Please merge this patch. The build failure is killing lots of i386 builds. Thanks.

Greg, please take this into your -next tree. The commit it fixes isn't in Linus's tree, so I don't have any way to land it sanely in -next.

-Kees

Signature · 1 line
Kees Cook
#5 lore raw
In reply to Randy Dunlap
Quoted 30 lines · Randy Dunlap
Quoted 27 lines · Kees Cook
Quoted 25 lines · Randy Dunlap

Hi Kees,

Quoted 14 lines · Randy Dunlap
Quoted 10 lines · Kees Cook

I put devlist.h into the wrong Makefile macro ("obj") to get it included in "targets". Put it into "always" so nothing tries to link against it. Solves CONFIG_EISA=y i386 build failure:

ld: vmlinux.a: member drivers/eisa/devlist.h in archive is not an object

Fixes dd09eb0e2cc4 ("EISA: Increase length of device names")
Quoted 5 lines

Thanks.

Please merge this patch. The build failure is killing lots of i386 builds. Thanks.

Quoted 7 lines
Quoted 4 lines

AFAIK, this needs to go via Greg's tree, but I can see if I can send it to Linus directly.

-Kees

Greg told me that it belongs to one of your trees, but Greg did merge the previous eisa/Makefile patch.

Ah, I thought that was in Kees's tree, sorry about that. I'll take this then, my fault.

greg k-h