Skip to contentSkip to conversation

drivers/acpi: Improve logging around acpi_initialize_tables

PATCH Applied Bartosz Szczepanek 2 participants 2 messages Apr 23, 2025 – May 9, 2025 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/acpi: Improve logging around acpi_initialize_tables

Emit warning that includes return code in a readable format. Example:
ACPI: Failed to initialize tables, status=0x5 (AE_NOT_FOUND)

This commit intends to make no other functional change.

---
 drivers/acpi/tables.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/acpi/tables.c +5 -1
index 2295abbecd14..6a017cc92d4e 100644
@@ -719,8 +719,12 @@ int __init acpi_locate_initial_tables(void)
 	}
 
 	status = acpi_initialize_tables(initial_tables, ACPI_MAX_TABLES, 0);
-	if (ACPI_FAILURE(status))
+	if (ACPI_FAILURE(status)) {
+		const char *msg = acpi_format_exception(status);
+
+		pr_warn("Failed to initialize tables, status=0x%x (%s)", status, msg);
 		return -EINVAL;
+	}
 
 	return 0;
 }
Signature · 1 line
2.47.1
maintainer Applied
#1 lore raw
Quoted 20 lines · Bartosz Szczepanek

Emit warning that includes return code in a readable format. Example:
ACPI: Failed to initialize tables, status=0x5 (AE_NOT_FOUND)

This commit intends to make no other functional change.

---
 drivers/acpi/tables.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/acpi/tables.c +0 -1
index 2295abbecd14..6a017cc92d4e 100644
@@ -719,8 +719,12 @@ int __init acpi_locate_initial_tables(void)
        }
 
        status = acpi_initialize_tables(initial_tables, ACPI_MAX_TABLES, 0);
-       if (ACPI_FAILURE(status))

drivers/acpi/tables.c int __init acpi_locate_initial_tables(void)

Quoted 10 lines
drivers/acpi/tables.c +5 -1
+       if (ACPI_FAILURE(status)) {
+               const char *msg = acpi_format_exception(status);
+
+               pr_warn("Failed to initialize tables, status=0x%x (%s)", status, msg);
                return -EINVAL;
+       }
 
        return 0;
 }
--

Applied as 6.16 material, thanks!