Skip to contentSkip to conversation

eisa: address link failure

PATCH In review Arnd Bergmann 2 participants 2 messages Apr 23, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 eisa: address link failure

From: Arnd Bergmann <[email protected]>

The devlist.h file is generated at build time but is not an object file, so linking fails, at least in some configurations:

ld.lld-21: error: vmlinux.a(drivers/eisa/devlist.h): not an ELF file

Make this an extra-y instead of obj-y target in Kbuild.

Fixes dd09eb0e2cc4 ("EISA: Increase length of device names")
---
 drivers/eisa/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/eisa/Makefile +2 -1
index f0d6cf7d1f32..562d8797e3b4 100644
@@ -1,7 +1,8 @@
 # SPDX-License-Identifier: GPL-2.0
 # Makefile for the Linux device tree
 
-obj-$(CONFIG_EISA)	        += devlist.h eisa-bus.o
+obj-$(CONFIG_EISA)	        += eisa-bus.o
+extra-$(CONFIG_EISA)		+= devlist.h
 obj-${CONFIG_EISA_PCI_EISA}     += pci_eisa.o
 
 # virtual_root.o should be the last EISA root device to initialize,
Signature · 1 line
2.39.5
#1 lore raw
Quoted 11 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The devlist.h file is generated at build time but is not an object file, so linking fails, at least in some configurations:

ld.lld-21: error: vmlinux.a(drivers/eisa/devlist.h): not an ELF file

Make this an extra-y instead of obj-y target in Kbuild.

Fixes dd09eb0e2cc4 ("EISA: Increase length of device names")

Thanks! I already sent this one:

https://lore.kernel.org/all/[email protected]/

-Kees

Quoted 21 lines
---
 drivers/eisa/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/eisa/Makefile +2 -1
index f0d6cf7d1f32..562d8797e3b4 100644
@@ -1,7 +1,8 @@
 # SPDX-License-Identifier: GPL-2.0
 # Makefile for the Linux device tree
 
-obj-$(CONFIG_EISA)	        += devlist.h eisa-bus.o
+obj-$(CONFIG_EISA)	        += eisa-bus.o
+extra-$(CONFIG_EISA)		+= devlist.h
 obj-${CONFIG_EISA_PCI_EISA}     += pci_eisa.o
 
 # virtual_root.o should be the last EISA root device to initialize,
Signature · 1 line
2.39.5
Signature · 1 line
Kees Cook