Skip to contentSkip to conversation

stable request: eaaff9b6702e ("netfilter: fib: avoid lookup if socket is available")

DISCUSSION Florian Westphal 2 participants 2 messages Apr 24, 2025 – Apr 28, 2025 Stable branch

lore
Share & tools
lore
#0 lore raw

Hi Greg, hi Sasha,

Could you please queue up

eaaff9b6702e ("netfilter: fib: avoid lookup if socket is available")

for 6.14 and 6.12?

Unfortunately I did not realize that the missing handling of 'input' is not just a missing optimization but an actual bug fix, else I would have split this patch in two.

The bug exists since 5.19, but its not a regression ('never worked').

Given noone noticed/reported this until this week
(https://lore.kernel.org/netfilter/[email protected]/),
we think it makes sense to only apply this to the two most recent trees and keep the rest as-is, users of those trees evidently don't use the b0rken configuration or they would have complained long ago.

The commit cherry-picks cleanly to both.
If you disagree let me know, I could also make a stable-only patch that only contains the bug fix part of the mentioned commit.

Thanks!

#1 lore raw
Quoted 20 lines · Florian Westphal

Hi Greg, hi Sasha,

Could you please queue up

eaaff9b6702e ("netfilter: fib: avoid lookup if socket is available")

for 6.14 and 6.12?

Unfortunately I did not realize that the missing handling of 'input' is not just a missing optimization but an actual bug fix, else I would have split this patch in two.

The bug exists since 5.19, but its not a regression ('never worked').

Given noone noticed/reported this until this week
(https://lore.kernel.org/netfilter/[email protected]/),
we think it makes sense to only apply this to the two most recent trees and keep the rest as-is, users of those trees evidently don't use the b0rken configuration or they would have complained long ago.

Quoted 3 lines

The commit cherry-picks cleanly to both.
If you disagree let me know, I could also make a stable-only patch that only contains the bug fix part of the mentioned commit.

Now queued up, thanks.

greg k-h