generic/033: Don't call 'fzero' with the KEEP_SIZE flag
Subsystems (2)
Anna Schumaker
maintainerPATCH v2 1/1 generic/033: Don't call 'fzero' with the KEEP_SIZE flag
From: Anna Schumaker <[email protected]>
None of the fzero calls in this test end up writing past the end of the file, so this flag is unnecessary and can cause the test to fail on filesystems that don't implement FALLOC_FL_KEEP_SIZE.
--- tests/generic/033 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tests/generic/033 +2 -2
@@ -37,12 +37,12 @@ $XFS_IO_PROG -f -c "pwrite 0 $bytes" $file >> $seqres.full 2>&1 # delalloc blocks and convert the ranges to unwritten. endoff=$((bytes - 4096)) for i in $(seq 0 8192 $endoff); do - $XFS_IO_PROG -c "fzero -k $i 4k" $file >> $seqres.full 2>&1 + $XFS_IO_PROG -c "fzero $i 4k" $file >> $seqres.full 2>&1 done # now zero the opposite set to remove remaining delalloc extents for i in $(seq 4096 8192 $endoff); do - $XFS_IO_PROG -c "fzero -k $i 4k" $file >> $seqres.full 2>&1 + $XFS_IO_PROG -c "fzero $i 4k" $file >> $seqres.full 2>&1 done _scratch_cycle_mount
Signature · 1 line
2.49.0
Quoted 7 lines · Anna Schumaker
From: Anna Schumaker <[email protected]>
None of the fzero calls in this test end up writing past the end of the file, so this flag is unnecessary and can cause the test to fail on filesystems that don't implement
FALLOC_FL_KEEP_SIZE.Signed-off-by Anna Schumaker <[email protected]>
Looks good to me,
--D
Quoted 27 lines
--- tests/generic/033 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tests/generic/033 +2
-2@@ -37,12 +37,12 @@ $XFS_IO_PROG -f -c "pwrite 0 $bytes" $file >> $seqres.full 2>&1 # delalloc blocks and convert the ranges to unwritten. endoff=$((bytes - 4096)) for i in $(seq 0 8192 $endoff); do - $XFS_IO_PROG -c "fzero -k $i 4k" $file >> $seqres.full 2>&1 + $XFS_IO_PROG -c "fzero $i 4k" $file >> $seqres.full 2>&1 done # now zero the opposite set to remove remaining delalloc extents for i in $(seq 4096 8192 $endoff); do - $XFS_IO_PROG -c "fzero -k $i 4k" $file >> $seqres.full 2>&1 + $XFS_IO_PROG -c "fzero $i 4k" $file >> $seqres.full 2>&1 done _scratch_cycle_mountSignature · 1 line
2.49.0
Quoted 8 lines · Anna Schumaker
From: Anna Schumaker <[email protected]>
None of the fzero calls in this test end up writing past the end of the file, so this flag is unnecessary and can cause the test to fail on filesystems that don't implement
FALLOC_FL_KEEP_SIZE.Signed-off-by Anna Schumaker <[email protected]>---
This version is good to me,
Quoted 26 lines
tests/generic/033 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tests/generic/033 +2
-2@@ -37,12 +37,12 @@ $XFS_IO_PROG -f -c "pwrite 0 $bytes" $file >> $seqres.full 2>&1 # delalloc blocks and convert the ranges to unwritten. endoff=$((bytes - 4096)) for i in $(seq 0 8192 $endoff); do - $XFS_IO_PROG -c "fzero -k $i 4k" $file >> $seqres.full 2>&1 + $XFS_IO_PROG -c "fzero $i 4k" $file >> $seqres.full 2>&1 done # now zero the opposite set to remove remaining delalloc extents for i in $(seq 4096 8192 $endoff); do - $XFS_IO_PROG -c "fzero -k $i 4k" $file >> $seqres.full 2>&1 + $XFS_IO_PROG -c "fzero $i 4k" $file >> $seqres.full 2>&1 done _scratch_cycle_mountSignature · 1 line
2.49.0