Skip to contentSkip to conversation

harfbuzz: remove meson flag work-around

PATCH In review Trevor Woerner 2 participants 3 messages Apr 25, 2025 – Apr 26, 2025 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 harfbuzz: remove meson flag work-around

The issue is committed and resolved upstream, therefore remove the work-around of explicitly having to set the meson flag 'cpp_std=c++17' when using icu >= 75.

https://github.com/harfbuzz/harfbuzz/issues/4671
https://github.com/harfbuzz/harfbuzz/pull/4734

---
 meta/recipes-graphics/harfbuzz/harfbuzz_11.0.1.bb | 3 ---
 1 file changed, 3 deletions(-)
meta/recipes-graphics/harfbuzz/harfbuzz_11.0.1.bb +0 -3
index 8945467a001d..2febcbecda31 100644
@@ -32,9 +32,6 @@ PACKAGES =+ "${PN}-icu ${PN}-icu-dev ${PN}-subset"
 
 LEAD_SONAME = "libharfbuzz.so"
 
-# Remove when https://github.com/harfbuzz/harfbuzz/issues/4671 is resolved
-EXTRA_OEMESON += "-Dcpp_std=c++17"
-
 do_install:append() {
     # If no tools are installed due to PACKAGECONFIG then this directory might
     # still be installed, so remove it to stop packaging warnings.
Signature · 1 line
2.44.0.501.g19981daefd7c
#1 lore raw
Quoted 25 lines · Trevor Woerner via lists.openembedded.org

The issue is committed and resolved upstream, therefore remove the work-around of explicitly having to set the meson flag 'cpp_std=c++17' when using icu >= 75.

https://github.com/harfbuzz/harfbuzz/issues/4671
https://github.com/harfbuzz/harfbuzz/pull/4734

---
 meta/recipes-graphics/harfbuzz/harfbuzz_11.0.1.bb | 3 ---

 1 file changed, 3 deletions(-)
meta/recipes-graphics/harfbuzz/harfbuzz_11.0.1.bb +0 -0
index 8945467a001d..2febcbecda31 100644
@@ -32,9 +32,6 @@ PACKAGES =+ "${PN}-icu ${PN}-icu-dev ${PN}-subset"


 LEAD_SONAME = "libharfbuzz.so"

meta/recipes-graphics/harfbuzz/harfbuzz_11.0.1.bb +0 -3
-# Remove when https://github.com/harfbuzz/harfbuzz/issues/4671 is resolved
-EXTRA_OEMESON += "-Dcpp_std=c++17"
-

 do_install:append() {
     # If no tools are installed due to PACKAGECONFIG then this directory might

Quoted 2 lines
     # still be installed, so remove it to stop packaging warnings.

Removing this caused failures on the autobuilder with gcc 15 e.g.:

https://autobuilder.yoctoproject.org/valkyrie/#/builders/2/builds/1474

but there were more in that build.

Cheers,

Richard

#3 lore raw
In reply to a message not in the archive
Quoted 31 lines · Richard Purdie via lists.openembedded.org
Quoted 25 lines · Trevor Woerner via lists.openembedded.org

The issue is committed and resolved upstream, therefore remove the work-around of explicitly having to set the meson flag 'cpp_std=c++17' when using icu >= 75.

https://github.com/harfbuzz/harfbuzz/issues/4671
https://github.com/harfbuzz/harfbuzz/pull/4734

---
 meta/recipes-graphics/harfbuzz/harfbuzz_11.0.1.bb | 3 ---

 1 file changed, 3 deletions(-)
meta/recipes-graphics/harfbuzz/harfbuzz_11.0.1.bb +0 -0
index 8945467a001d..2febcbecda31 100644
@@ -32,9 +32,6 @@ PACKAGES =+ "${PN}-icu ${PN}-icu-dev ${PN}-subset"


 LEAD_SONAME = "libharfbuzz.so"

meta/recipes-graphics/harfbuzz/harfbuzz_11.0.1.bb +0 -3
-# Remove when https://github.com/harfbuzz/harfbuzz/issues/4671 is resolved
-EXTRA_OEMESON += "-Dcpp_std=c++17"
-

 do_install:append() {
     # If no tools are installed due to PACKAGECONFIG then this directory might

Quoted 2 lines
     # still be installed, so remove it to stop packaging warnings.

Removing this caused failures on the autobuilder with gcc 15 e.g.:

Quoted 3 lines

https://autobuilder.yoctoproject.org/valkyrie/#/builders/2/builds/1474

but there were more in that build.

I did drop this patch and I think we still see the same failure with gcc 15 so there may be more to this...

Cheers,

Richard