Skip to contentSkip to conversation

media: iris: Cast iris_hfi_gen2_get_instance() allocation type

PATCH New Kees Cook 1 participant 1 message Apr 26, 2025

Subsystems (4)
lore
Share & tools
lore

Kees Cook

author
#0 lore raw

PATCH 1/1 media: iris: Cast iris_hfi_gen2_get_instance() allocation type

In preparation for making the kmalloc family of allocators type aware, we need to make sure that the returned type from the allocation matches the type of the variable being assigned. (Before, the allocator would always return "void *", which can be implicitly cast to any pointer type.)

The assigned type is "struct iris_inst *", but the returned type is "struct iris_inst_hfi_gen2 *". The allocation is intentionally larger as the first member of struct iris_inst_hfi_gen2 is struct iris_inst, so this is by design. Cast the allocation type to match the assignment.

---
Cc: Vikash Garodia <[email protected]>
Cc: Dikshita Agarwal <[email protected]>
Cc: Abhinav Kumar <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: <[email protected]>
Cc: <[email protected]>

---
 drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c +1 -1
index a908b41e2868..351820deb893 100644
@@ -953,5 +953,5 @@ void iris_hfi_gen2_command_ops_init(struct iris_core *core)
 
 struct iris_inst *iris_hfi_gen2_get_instance(void)
 {
-	return kzalloc(sizeof(struct iris_inst_hfi_gen2), GFP_KERNEL);
+	return (struct iris_inst *)kzalloc(sizeof(struct iris_inst_hfi_gen2), GFP_KERNEL);
 }
Signature · 1 line
2.34.1