testdisk: add recipe
PATCH 1/1 testdisk: add recipe
testdisk is a free data recovery software primarily designed to help recover lost partitions and/or make non-booting disks bootable again when these symptoms are caused by faulty software.
--- .../recipes-support/testdisk/testdisk_7.2.bb | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 meta-oe/recipes-support/testdisk/testdisk_7.2.bb
meta-oe/recipes-support/testdisk/testdisk_7.2.bb new file +19 -0
@@ -0,0 +1,19 @@ +DESCRIPTION = "TestDisk is a free data recovery software primarily designed to help recover lost partitions and/or make non-booting disks bootable again when these symptoms are caused by faulty software, certain types of viruses or human error (such as accidentally deleting your Partition Table)." +LICENSE = "GPLv2" +LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe" +PR = "r1" + +DEPENDS = "jpeg ncurses e2fsprogs" + +SRC_URI = "https://github.com/cgsecurity/testdisk/archive/refs/tags/v7.2.tar.gz" +S = "${WORKDIR}/testdisk-7.2" + +inherit autotools pkgconfig + +PACKAGES =+ "photorec" + +DESCRIPTION_photorec = "Photorec is file data recovery software designed to recover lost files including video, documents and archives from Hard Disks and CDRom and lost pictures (Photo Recovery) from digital camera memory." +FILES_photorec = "${sbindir}/photorec" + +SRC_URI[md5sum] = "c47d69e2c950b6b2f0dadb2a2921d6c6" +SRC_URI[sha256sum] = "f3fe7ec02cafcbe792a4c783976de3a6312963b0ce8a613d38adbcd8bdca0517"
Signature · 1 line
2.25.1
It looks like this recipe was created with/for an old version of Yocto. Could you please prepare it for master branch?
I have added some comments inline.
Quoted 16 lines · Wen Yang via lists.openembedded.org
testdisk is a free data recovery software primarily designed to help recover lost partitions and/or make non-booting disks bootable again when these symptoms are caused by faulty software.
Signed-off-by Wen Yang <[email protected]>--- .../recipes-support/testdisk/testdisk_7.2.bb | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 meta-oe/recipes-support/testdisk/testdisk_7.2.bbmeta-oe/recipes-support/testdisk/testdisk_7.2.bb new file +0
-0
meta-oe/recipes-support/testdisk/testdisk_7.2.bb line 2
Quoted 2 lines
meta-oe/recipes-support/testdisk/testdisk_7.2.bb new file +2
-0@@ -0,0 +1,19 @@ +DESCRIPTION = "TestDisk is a free data recovery software primarily designed to help recover lost partitions and/or make non-booting disks bootable again when these symptoms are caused by faulty software, certain types of viruses or human error (such as accidentally deleting your Partition Table)." +LICENSE = "GPLv2"
This LICENSE value is deprecated. Please use spdx identifiers if possible/applicable, like GPL-2.0-only or GPL-2.0-or-later
meta-oe/recipes-support/testdisk/testdisk_7.2.bb line 4
Quoted 2 lines
meta-oe/recipes-support/testdisk/testdisk_7.2.bb new file +2
-0+LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe" +PR = "r1"
Is PR needed in this recipe?
meta-oe/recipes-support/testdisk/testdisk_7.2.bb line 8
Quoted 4 lines
meta-oe/recipes-support/testdisk/testdisk_7.2.bb new file +4
-0+ +DEPENDS = "jpeg ncurses e2fsprogs" + +SRC_URI = "https://github.com/cgsecurity/testdisk/archive/refs/tags/v7.2.tar.gz"
Archived tags in Github are unfortunately not immutable, so their use is discouraged (and it also throws a fatal QA check). It is preferred to use the direct commit ID.
meta-oe/recipes-support/testdisk/testdisk_7.2.bb line 13
Quoted 5 lines
meta-oe/recipes-support/testdisk/testdisk_7.2.bb new file +5
-0+S = "${WORKDIR}/testdisk-7.2" + +inherit autotools pkgconfig + +PACKAGES =+ "photorec"
It is recommended to prepend the extra packages' names with the main recipe name, like ${PN}-photorec
meta-oe/recipes-support/testdisk/testdisk_7.2.bb line 16
Quoted 3 lines
meta-oe/recipes-support/testdisk/testdisk_7.2.bb new file +3
-0+ +DESCRIPTION_photorec = "Photorec is file data recovery software designed to recover lost files including video, documents and archives from Hard Disks and CDRom and lost pictures (Photo Recovery) from digital camera memory." +FILES_photorec = "${sbindir}/photorec"
The underscore override syntax has changed to ":".
Quoted 12 lines
meta-oe/recipes-support/testdisk/testdisk_7.2.bb new file +3
-1+ +SRC_URI[md5sum] = "c47d69e2c950b6b2f0dadb2a2921d6c6" +SRC_URI[sha256sum] = "f3fe7ec02cafcbe792a4c783976de3a6312963b0ce8a613d38adbcd8bdca0517" -=-=-=-=-=-=-=-=-=-=-=-Links: You receive all messages sent to this group.
View/Reply Online (#117176): https://lists.openembedded.org/g/openembedded-devel/message/117176
Mute This Topic: https://lists.openembedded.org/mt/112489401/6084445
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Quoted 29 lines · Gyorgy Sarvari via lists.openembedded.org
It looks like this recipe was created with/for an old version of Yocto. Could you please prepare it for master branch?
I have added some comments inline.Quoted 16 lines · Wen Yang via lists.openembedded.org
testdisk is a free data recovery software primarily designed to help recover lost partitions and/or make non-booting disks bootable again when these symptoms are caused by faulty software.
Signed-off-by Wen Yang <[email protected]>--- .../recipes-support/testdisk/testdisk_7.2.bb | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 meta-oe/recipes-support/testdisk/testdisk_7.2.bbmeta-oe/recipes-support/testdisk/testdisk_7.2.bb new file +0
-0meta-oe/recipes-support/testdisk/testdisk_7.2.bb line 2
Quoted 2 lines
meta-oe/recipes-support/testdisk/testdisk_7.2.bb new file +2
-0@@ -0,0 +1,19 @@ +DESCRIPTION = "TestDisk is a free data recovery software primarily designed to help recover lost partitions and/or make non-booting disks bootable again when these symptoms are caused by faulty software, certain types of viruses or human error (such as accidentally deleting your Partition Table)." +LICENSE = "GPLv2"This LICENSE value is deprecated. Please use spdx identifiers if possible/applicable, like GPL-2.0-only or GPL-2.0-or-later
meta-oe/recipes-support/testdisk/testdisk_7.2.bb line 4
Quoted 2 lines
meta-oe/recipes-support/testdisk/testdisk_7.2.bb new file +2
-0+LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe" +PR = "r1"Is PR needed in this recipe?
Quoted 7 lines
meta-oe/recipes-support/testdisk/testdisk_7.2.bb line 8
Quoted 4 lines
meta-oe/recipes-support/testdisk/testdisk_7.2.bb new file +4
-0+ +DEPENDS = "jpeg ncurses e2fsprogs" + +SRC_URI = "https://github.com/cgsecurity/testdisk/archive/refs/tags/v7.2.tar.gz"Archived tags in Github are unfortunately not immutable, so their use is discouraged (and it also throws a fatal QA check). It is preferred to use the direct commit ID.
it should be flagged by build too
ERROR: testdisk-7.2-r1 do_recipe_qa: QA Issue: testdisk: SRC_URI uses unstable GitHub/GitLab archives, convert recipe to use git protocol [src-uri-bad]
Quoted 27 lines
meta-oe/recipes-support/testdisk/testdisk_7.2.bb line 13
Quoted 5 lines
meta-oe/recipes-support/testdisk/testdisk_7.2.bb new file +5
-0+S = "${WORKDIR}/testdisk-7.2" + +inherit autotools pkgconfig + +PACKAGES =+ "photorec"It is recommended to prepend the extra packages' names with the main recipe name, like ${PN}-photorec
meta-oe/recipes-support/testdisk/testdisk_7.2.bb line 16
Quoted 3 lines
meta-oe/recipes-support/testdisk/testdisk_7.2.bb new file +3
-0+ +DESCRIPTION_photorec = "Photorec is file data recovery software designed to recover lost files including video, documents and archives from Hard Disks and CDRom and lost pictures (Photo Recovery) from digital camera memory." +FILES_photorec = "${sbindir}/photorec"The underscore override syntax has changed to ":".
meta-oe/recipes-support/testdisk/testdisk_7.2.bb line 19
Quoted 6 lines
meta-oe/recipes-support/testdisk/testdisk_7.2.bb new file +3
-0+ +SRC_URI[md5sum] = "c47d69e2c950b6b2f0dadb2a2921d6c6" +SRC_URI[sha256sum] = "f3fe7ec02cafcbe792a4c783976de3a6312963b0ce8a613d38adbcd8bdca0517"-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#117189): https://lists.openembedded.org/g/openembedded-devel/message/117189
Mute This Topic: https://lists.openembedded.org/mt/112489401/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-